Bug#621037: scotch: missing inter-library links
On Wed, Apr 6, 2011 at 3:12 PM, Adam C Powell IV wrote: > Hi Johannes, > > On Wed, 2011-04-06 at 14:37 +0200, Johannes Ring wrote: >> Hi Adam, >> >> On Wed, Apr 6, 2011 at 1:47 PM, Adam C Powell IV wrote: >> > Just put a fix in alioth, let me know if it gives you trouble. I plan >> > to upload within 4-5 hours. >> >> Sorry, I tried your fix but it gives me trouble because libptscotch is >> linked against libscotch. This is the same problem as reported in >> #612621. > > Right, I'm sorry about that. I just copied the link commands from -4, > assuming that the changed CFLAGS and LDFLAGS would make the difference. > >> It seems like the build-fixes.patch does not incorporate the >> fixes from libptscotch.patch [1] in that bug report. Would you like me >> to create a new patch against the latest git repository? >> >> [1] >> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=29;filename=libptscotch.patch;att=1;bug=612621 > > Sure, is there anything else that needs to change? The attached patch fixes the problem for me. Thanks, Johannes diff --git a/debian/patches/build-fixes.patch b/debian/patches/build-fixes.patch index 94ad82b..fa8ddc8 100644 --- a/debian/patches/build-fixes.patch +++ b/debian/patches/build-fixes.patch @@ -112,10 +112,10 @@ Index: scotch/src/libscotch/Makefile -libptscotch$(LIB) : $(LIBPTSCOTCHDEPS) $(LIBSCOTCHDEPS) - $(AR) $(ARFLAGS) $(@) $(?) -+libptscotch$(LIB) : $(LIBPTSCOTCHDEPS) $(LIBSCOTCHDEPS) libptscotcherr$(LIB) libscotch$(LIB) -+ $(CC) -shared -Wl,-soname,libptscotch-$(VERSION).so $(LIBPTSCOTCHDEPS) -L. -lptscotcherr -lscotch -lz -lpthread -lm -lrt -o libptscotch-$(VERSION).so ++libptscotch$(LIB) : $(LIBPTSCOTCHDEPS) $(LIBSCOTCHDEPS) libptscotcherr$(LIB) ++ $(CC) -shared -Wl,-soname,libptscotch-$(VERSION).so $(LIBPTSCOTCHDEPS) $(LIBSCOTCHDEPS) -L. -lptscotcherr -lz -lpthread -lm -lrt -o libptscotch-$(VERSION).so + ln -s libptscotch-$(VERSION).so libptscotch.so -+ $(AR) $(ARFLAGS) $(@) $(LIBPTSCOTCHDEPS) ++ $(AR) $(ARFLAGS) $(@) $(?) -$(RANLIB) $(@) -libscotch$(LIB) : $(LIBSCOTCHDEPS)
Bug#621037: scotch: missing inter-library links
On Wed, Apr 6, 2011 at 4:29 PM, Adam C Powell IV wrote: > Thanks very much Johannes. > > On Wed, 2011-04-06 at 16:11 +0200, Johannes Ring wrote: >> On Wed, Apr 6, 2011 at 3:12 PM, Adam C Powell IV wrote: >> > Hi Johannes, >> > >> > On Wed, 2011-04-06 at 14:37 +0200, Johannes Ring wrote: >> >> Hi Adam, >> >> >> >> On Wed, Apr 6, 2011 at 1:47 PM, Adam C Powell IV >> >> wrote: >> >> > Just put a fix in alioth, let me know if it gives you trouble. I plan >> >> > to upload within 4-5 hours. >> >> >> >> Sorry, I tried your fix but it gives me trouble because libptscotch is >> >> linked against libscotch. This is the same problem as reported in >> >> #612621. >> > >> > Right, I'm sorry about that. I just copied the link commands from -4, >> > assuming that the changed CFLAGS and LDFLAGS would make the difference. >> > >> >> It seems like the build-fixes.patch does not incorporate the >> >> fixes from libptscotch.patch [1] in that bug report. Would you like me >> >> to create a new patch against the latest git repository? >> >> >> >> [1] >> >> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=29;filename=libptscotch.patch;att=1;bug=612621 >> > >> > Sure, is there anything else that needs to change? >> >> The attached patch fixes the problem for me. > > Thanks, this answers a couple of questions I had. > > One little detail: using $(AR) ... $(?) would include libptscotcherr.a > in the ar command, wouldn't it? Is that intended? No, I guess not. Should "$(?)" be replaced by "$(LIBPTSCOTCHDEPS) $(LIBSCOTCHDEPS)"? Johannes -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#621037: scotch: missing inter-library links
Thanks very much Johannes. On Wed, 2011-04-06 at 16:11 +0200, Johannes Ring wrote: > On Wed, Apr 6, 2011 at 3:12 PM, Adam C Powell IV wrote: > > Hi Johannes, > > > > On Wed, 2011-04-06 at 14:37 +0200, Johannes Ring wrote: > >> Hi Adam, > >> > >> On Wed, Apr 6, 2011 at 1:47 PM, Adam C Powell IV > >> wrote: > >> > Just put a fix in alioth, let me know if it gives you trouble. I plan > >> > to upload within 4-5 hours. > >> > >> Sorry, I tried your fix but it gives me trouble because libptscotch is > >> linked against libscotch. This is the same problem as reported in > >> #612621. > > > > Right, I'm sorry about that. I just copied the link commands from -4, > > assuming that the changed CFLAGS and LDFLAGS would make the difference. > > > >> It seems like the build-fixes.patch does not incorporate the > >> fixes from libptscotch.patch [1] in that bug report. Would you like me > >> to create a new patch against the latest git repository? > >> > >> [1] > >> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=29;filename=libptscotch.patch;att=1;bug=612621 > > > > Sure, is there anything else that needs to change? > > The attached patch fixes the problem for me. Thanks, this answers a couple of questions I had. One little detail: using $(AR) ... $(?) would include libptscotcherr.a in the ar command, wouldn't it? Is that intended? -Adam -- GPG fingerprint: D54D 1AEE B11C CE9B A02B C5DD 526F 01E8 564E E4B6 Engineering consulting with open source tools http://www.opennovation.com/ signature.asc Description: This is a digitally signed message part
Bug#621037: scotch: missing inter-library links
Hi Johannes, On Wed, 2011-04-06 at 14:37 +0200, Johannes Ring wrote: > Hi Adam, > > On Wed, Apr 6, 2011 at 1:47 PM, Adam C Powell IV wrote: > > Just put a fix in alioth, let me know if it gives you trouble. I plan > > to upload within 4-5 hours. > > Sorry, I tried your fix but it gives me trouble because libptscotch is > linked against libscotch. This is the same problem as reported in > #612621. Right, I'm sorry about that. I just copied the link commands from -4, assuming that the changed CFLAGS and LDFLAGS would make the difference. > It seems like the build-fixes.patch does not incorporate the > fixes from libptscotch.patch [1] in that bug report. Would you like me > to create a new patch against the latest git repository? > > [1] > http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=29;filename=libptscotch.patch;att=1;bug=612621 Sure, is there anything else that needs to change? -Adam -- GPG fingerprint: D54D 1AEE B11C CE9B A02B C5DD 526F 01E8 564E E4B6 Engineering consulting with open source tools http://www.opennovation.com/ signature.asc Description: This is a digitally signed message part
Bug#621037: scotch: missing inter-library links
Hi Adam, On Wed, Apr 6, 2011 at 1:47 PM, Adam C Powell IV wrote: > Just put a fix in alioth, let me know if it gives you trouble. I plan > to upload within 4-5 hours. Sorry, I tried your fix but it gives me trouble because libptscotch is linked against libscotch. This is the same problem as reported in #612621. It seems like the build-fixes.patch does not incorporate the fixes from libptscotch.patch [1] in that bug report. Would you like me to create a new patch against the latest git repository? [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=29;filename=libptscotch.patch;att=1;bug=612621 Johannes -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#621037: scotch: missing inter-library links
On Tue, 2011-04-05 at 21:18 -0400, Adam C Powell IV wrote: > Pierre & Johannes, > > On Tue, 2011-04-05 at 20:13 -0400, Adam C Powell IV wrote: > > Package: src:scotch > > Version: 5.1.11.dfsg-5 > > Severity: serious > > Justification: causes other packages to FTBFS > > X-DebBugs-CC: gladky.an...@gmail.com > > > > Greetings, > > > > In the last upload or two, the scotch package has lost its inter-library > > linkages. libscotchmetis should be linked -lscotch, and libscotch > > should be linked -lscotcherr and a couple of others, but they're not. > > I'm afraid this sends us back to the drawing board. We can't simply use > "AR = gcc ..." to build shared libraries because they need to link to > each other. > > What were the reasons for building this way again? I can see that it's > helpful to build the static libraries without -fPIC, but one can do this > by building .lo objects with -fPIC and making the shared libs with > those, like libtool does. > > I'm afraid I'm going to have to revert much of the recent work to -4 and > try to fix its problems a different way... Just put a fix in alioth, let me know if it gives you trouble. I plan to upload within 4-5 hours. -Adam -- GPG fingerprint: D54D 1AEE B11C CE9B A02B C5DD 526F 01E8 564E E4B6 Engineering consulting with open source tools http://www.opennovation.com/ signature.asc Description: This is a digitally signed message part
Bug#621037: scotch: missing inter-library links
Pierre & Johannes, On Tue, 2011-04-05 at 20:13 -0400, Adam C Powell IV wrote: > Package: src:scotch > Version: 5.1.11.dfsg-5 > Severity: serious > Justification: causes other packages to FTBFS > X-DebBugs-CC: gladky.an...@gmail.com > > Greetings, > > In the last upload or two, the scotch package has lost its inter-library > linkages. libscotchmetis should be linked -lscotch, and libscotch > should be linked -lscotcherr and a couple of others, but they're not. I'm afraid this sends us back to the drawing board. We can't simply use "AR = gcc ..." to build shared libraries because they need to link to each other. What were the reasons for building this way again? I can see that it's helpful to build the static libraries without -fPIC, but one can do this by building .lo objects with -fPIC and making the shared libs with those, like libtool does. I'm afraid I'm going to have to revert much of the recent work to -4 and try to fix its problems a different way... -Adam -- GPG fingerprint: D54D 1AEE B11C CE9B A02B C5DD 526F 01E8 564E E4B6 Engineering consulting with open source tools http://www.opennovation.com/ signature.asc Description: This is a digitally signed message part
Bug#621037: scotch: missing inter-library links
Package: src:scotch Version: 5.1.11.dfsg-5 Severity: serious Justification: causes other packages to FTBFS X-DebBugs-CC: gladky.an...@gmail.com Greetings, In the last upload or two, the scotch package has lost its inter-library linkages. libscotchmetis should be linked -lscotch, and libscotch should be linked -lscotcherr and a couple of others, but they're not. -Adam -- GPG fingerprint: D54D 1AEE B11C CE9B A02B C5DD 526F 01E8 564E E4B6 Engineering consulting with open source tools http://www.opennovation.com/ signature.asc Description: This is a digitally signed message part
