Bug#621874: [Debichem-devel] VOTCA available on my PPA
Hi, On Mon, Dec 23, 2013 at 03:12:44PM -0700, Christoph Junghans wrote: 2013/12/23 Michael Banck mba...@debian.org: Another thing to consider if the package has not shipped in Ubuntu proper so far would be to maybe start over with the Debian changelog, but I leave that up to you. Whatever you debian guys like, I am happy to drop the current changelog. Ok. 2. votca-tools ships a convenience copy of boost. Either it needs to be stripped off the tarball (i.e. the tarball needs to be repackaged), or the boost license and copyright needs to be added to debian/copyright. VOTCA ships a pristine tarball already: https://votca.googlecode.com/files/votca-tools-1.2.3_pristine.tar.gz and on my PPA, I have used that one to create the debian package. Ah, ok. I think I saw that in passing a while back but by the time I looked at the package I had forgotten about it. Where would I note that in the debian files? The next release (1.3) will not bundle boost anymore. Implicitly we can add a debian/watch file which points at the right upstream URL (via a regex), Daniel is really good at it and usually adds them when he has time. Explicitly, the file debian/README.source could contain that information But if you drop it upstream anyway, then it is probably not worth the hassle having to change things back for the next release. It's not a bug anyway. Finally, I suggest adding an debian/upstream file with some metadata and the prime publications, I can do that. Once we have converged, I will add the debian folder to our admin repository. That is usually discouraged (if you mean the code repository on Google code), as it makes it more difficult to add Debian changes on top of a release, if they are required by a new Debian policy, e.g. Also, it makes it difficult to synchronize the Debian packaging with the regular release. The only exception are native packages, which are developped especially for Debian, but even in that case, a lot of packages ship an upstream source and the Debian diff. Sorry, I misread, wrong direction of thought! I added an upstream file with some fields in votca-{tools,csg}. Cool! I'll try to look over the package again when I find time, I am a bit busy right now, sorry. Michael -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#621874: [Debichem-devel] VOTCA available on my PPA
2013/12/22 Michael Banck mba...@debian.org: Hi, On Sun, Oct 27, 2013 at 02:55:04PM -0600, Christoph Junghans wrote: I finalize found the time to make the first steps to package VOTCA for Debian. The source/binary builds are available on https://launchpad.net/~ottxor/+archive/votca. Please have a look and help me to improve it, so that I can hand it over to debichem soon. I took a look at votca-tools now (as this is a Build-Depends for votca-csg and has to be uploaded first). I see the following issues: 1. The -dev package is named libvotca-tools2-dev, i.e. includes the soversion. This is discouraged (but unfortunately the library maintainer's guide advocated it at least last time I looked), unless a project is very widely used and switching all programs using it immediately is not feasable (like for GTK1-GTK2, oder Qt4-Qt5). I understand that Ubuntu ships it, but I would rather rename it to libvotca-tools-dev and either let Ubuntu deal with it, or add compatibility Replaces/Conflicts/Provides for it. Renaming is fine as it has only been released as PPA. So should we just rename the dev package or both? 2. votca-tools ships a convenience copy of boost. Either it needs to be stripped off the tarball (i.e. the tarball needs to be repackaged), or the boost license and copyright needs to be added to debian/copyright. VOTCA ships a pristine tarball already: https://votca.googlecode.com/files/votca-tools-1.2.3_pristine.tar.gz and on my PPA, I have used that one to create the debian package. Finally, I suggest adding an debian/upstream file with some metadata and the prime publications, I can do that. Once we have converged, I will add the debian folder to our admin repository. Christoph Michael -- Christoph Junghans Web: http://www.compphys.de -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#621874: [Debichem-devel] VOTCA available on my PPA
Hi, On Mon, Dec 23, 2013 at 08:38:27AM -0700, Christoph Junghans wrote: 2013/12/22 Michael Banck mba...@debian.org: Hi, On Sun, Oct 27, 2013 at 02:55:04PM -0600, Christoph Junghans wrote: I finalize found the time to make the first steps to package VOTCA for Debian. The source/binary builds are available on https://launchpad.net/~ottxor/+archive/votca. Please have a look and help me to improve it, so that I can hand it over to debichem soon. I took a look at votca-tools now (as this is a Build-Depends for votca-csg and has to be uploaded first). I see the following issues: 1. The -dev package is named libvotca-tools2-dev, i.e. includes the soversion. This is discouraged (but unfortunately the library maintainer's guide advocated it at least last time I looked), unless a project is very widely used and switching all programs using it immediately is not feasable (like for GTK1-GTK2, oder Qt4-Qt5). I understand that Ubuntu ships it, but I would rather rename it to libvotca-tools-dev and either let Ubuntu deal with it, or add compatibility Replaces/Conflicts/Provides for it. Renaming is fine as it has only been released as PPA. So should we just rename the dev package or both? Only the -dev package, the runtime library is required to carry the soversion in the package name. Another thing to consider if the package has not shipped in Ubuntu proper so far would be to maybe start over with the Debian changelog, but I leave that up to you. 2. votca-tools ships a convenience copy of boost. Either it needs to be stripped off the tarball (i.e. the tarball needs to be repackaged), or the boost license and copyright needs to be added to debian/copyright. VOTCA ships a pristine tarball already: https://votca.googlecode.com/files/votca-tools-1.2.3_pristine.tar.gz and on my PPA, I have used that one to create the debian package. Ah, ok. I think I saw that in passing a while back but by the time I looked at the package I had forgotten about it. Finally, I suggest adding an debian/upstream file with some metadata and the prime publications, I can do that. Once we have converged, I will add the debian folder to our admin repository. That is usually discouraged (if you mean the code repository on Google code), as it makes it more difficult to add Debian changes on top of a release, if they are required by a new Debian policy, e.g. Also, it makes it difficult to synchronize the Debian packaging with the regular release. The only exception are native packages, which are developped especially for Debian, but even in that case, a lot of packages ship an upstream source and the Debian diff. So in practise, if an upstream tarball already contains a debian/-directory, it is usually removed and replaced by the debian.tar.gz from the source package. Michael -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#621874: [Debichem-devel] VOTCA available on my PPA
2013/12/23 Michael Banck mba...@debian.org: Hi, On Mon, Dec 23, 2013 at 08:38:27AM -0700, Christoph Junghans wrote: 2013/12/22 Michael Banck mba...@debian.org: Hi, On Sun, Oct 27, 2013 at 02:55:04PM -0600, Christoph Junghans wrote: I finalize found the time to make the first steps to package VOTCA for Debian. The source/binary builds are available on https://launchpad.net/~ottxor/+archive/votca. Please have a look and help me to improve it, so that I can hand it over to debichem soon. I took a look at votca-tools now (as this is a Build-Depends for votca-csg and has to be uploaded first). I see the following issues: 1. The -dev package is named libvotca-tools2-dev, i.e. includes the soversion. This is discouraged (but unfortunately the library maintainer's guide advocated it at least last time I looked), unless a project is very widely used and switching all programs using it immediately is not feasable (like for GTK1-GTK2, oder Qt4-Qt5). I understand that Ubuntu ships it, but I would rather rename it to libvotca-tools-dev and either let Ubuntu deal with it, or add compatibility Replaces/Conflicts/Provides for it. Renaming is fine as it has only been released as PPA. So should we just rename the dev package or both? Only the -dev package, the runtime library is required to carry the soversion in the package name. Done. Another thing to consider if the package has not shipped in Ubuntu proper so far would be to maybe start over with the Debian changelog, but I leave that up to you. Whatever you debian guys like, I am happy to drop the current changelog. 2. votca-tools ships a convenience copy of boost. Either it needs to be stripped off the tarball (i.e. the tarball needs to be repackaged), or the boost license and copyright needs to be added to debian/copyright. VOTCA ships a pristine tarball already: https://votca.googlecode.com/files/votca-tools-1.2.3_pristine.tar.gz and on my PPA, I have used that one to create the debian package. Ah, ok. I think I saw that in passing a while back but by the time I looked at the package I had forgotten about it. Where would I note that in the debian files? The next release (1.3) will not bundle boost anymore. Finally, I suggest adding an debian/upstream file with some metadata and the prime publications, I can do that. Once we have converged, I will add the debian folder to our admin repository. That is usually discouraged (if you mean the code repository on Google code), as it makes it more difficult to add Debian changes on top of a release, if they are required by a new Debian policy, e.g. Also, it makes it difficult to synchronize the Debian packaging with the regular release. The only exception are native packages, which are developped especially for Debian, but even in that case, a lot of packages ship an upstream source and the Debian diff. Sorry, I misread, wrong direction of thought! I added an upstream file with some fields in votca-{tools,csg}. Cheers, Christoph So in practise, if an upstream tarball already contains a debian/-directory, it is usually removed and replaced by the debian.tar.gz from the source package. Michael -- Christoph Junghans Web: http://www.compphys.de -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#621874: [Debichem-devel] VOTCA available on my PPA
Hi, On Sun, Oct 27, 2013 at 02:55:04PM -0600, Christoph Junghans wrote: I finalize found the time to make the first steps to package VOTCA for Debian. The source/binary builds are available on https://launchpad.net/~ottxor/+archive/votca. Please have a look and help me to improve it, so that I can hand it over to debichem soon. I took a look at votca-tools now (as this is a Build-Depends for votca-csg and has to be uploaded first). I see the following issues: 1. The -dev package is named libvotca-tools2-dev, i.e. includes the soversion. This is discouraged (but unfortunately the library maintainer's guide advocated it at least last time I looked), unless a project is very widely used and switching all programs using it immediately is not feasable (like for GTK1-GTK2, oder Qt4-Qt5). I understand that Ubuntu ships it, but I would rather rename it to libvotca-tools-dev and either let Ubuntu deal with it, or add compatibility Replaces/Conflicts/Provides for it. 2. votca-tools ships a convenience copy of boost. Either it needs to be stripped off the tarball (i.e. the tarball needs to be repackaged), or the boost license and copyright needs to be added to debian/copyright. Finally, I suggest adding an debian/upstream file with some metadata and the prime publications, I can do that. Michael -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#621874: [Debichem-devel] VOTCA available on my PPA
2013/10/31 Nicholas Breen nbr...@debian.org: On Sun, Oct 27, 2013 at 02:55:04PM -0600, Christoph Junghans wrote: I finalize found the time to make the first steps to package VOTCA for Debian. The source/binary builds are available on https://launchpad.net/~ottxor/+archive/votca. Please have a look and help me to improve it, so that I can hand it over to debichem soon. Hi Christoph, Thanks for working on those. They look fairly sensible to me; the one change I'd strongly recommend is updating them to debhelper v9 compatibility, which should automatically handle both the multiarch paths and appending CPPFLAGS to CXXFLAGS. It might also be worth specifying what exactly the dh_python2 calls should operate on, since those throw a lot of errors during their run from trying (and failing) to operate on non-python files -- not a fatal error, it just makes that part of the build log hard to read. Don, done done. VOTCA uses the LIB variable to set the lib location, which is obliviously not what dh excepts, so I left this in rules. There's still a second typo in 11_csg_boltzmann_typo.patch: telp - help Done. Have you considered including the tutorials as additional documentation? I tried setting those up at first with the multiple-tarballs feature of the 3.0 source format [1], which does work although you'll need to write your own installation procedure in debian/rules for them. Done. Policy 3.9.5 was just released [2], so you can bump the Standards-Version lines in debian/control. I don't see any changes that would affect your packaging. Done. -- Nicholas Breen nbr...@debian.org [1] https://wiki.debian.org/Projects/DebSrc3.0#How_to_use_multiple_upstream_tarball_in_3.0_.28quilt.29_format.3F [2] https://lists.debian.org/debian-devel-announce/2013/10/msg6.html -- Christoph Junghans Web: http://www.compphys.de -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#621874: [Debichem-devel] VOTCA available on my PPA
On Sun, Oct 27, 2013 at 02:55:04PM -0600, Christoph Junghans wrote: I finalize found the time to make the first steps to package VOTCA for Debian. The source/binary builds are available on https://launchpad.net/~ottxor/+archive/votca. Please have a look and help me to improve it, so that I can hand it over to debichem soon. Hi Christoph, Thanks for working on those. They look fairly sensible to me; the one change I'd strongly recommend is updating them to debhelper v9 compatibility, which should automatically handle both the multiarch paths and appending CPPFLAGS to CXXFLAGS. It might also be worth specifying what exactly the dh_python2 calls should operate on, since those throw a lot of errors during their run from trying (and failing) to operate on non-python files -- not a fatal error, it just makes that part of the build log hard to read. There's still a second typo in 11_csg_boltzmann_typo.patch: telp - help Have you considered including the tutorials as additional documentation? I tried setting those up at first with the multiple-tarballs feature of the 3.0 source format [1], which does work although you'll need to write your own installation procedure in debian/rules for them. Policy 3.9.5 was just released [2], so you can bump the Standards-Version lines in debian/control. I don't see any changes that would affect your packaging. -- Nicholas Breen nbr...@debian.org [1] https://wiki.debian.org/Projects/DebSrc3.0#How_to_use_multiple_upstream_tarball_in_3.0_.28quilt.29_format.3F [2] https://lists.debian.org/debian-devel-announce/2013/10/msg6.html -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org