Bug#628507: [PATCH] subversion: FTBFS with perl 5.14: test failures

2011-07-11 Thread Stéphane Gaudreault 
Le 10 juillet 2011 08:37:36 Niko Tyni a écrit :
 tag 628507 patch
 thanks
 
 On Fri, Jul 01, 2011 at 06:10:21PM -0400, Stéphane Gaudreault wrote:
  Our collegue Marcela Mašláňová from the Red Hat team suggested that the
  problem might be in in Makefile.PL where ExtUtils::MakeMaker overwrite
  the CCFLAGS. The following patch fixed the problem for us.
 
 Thanks Stéphane!
 
  -CCFLAGS = $cflags,
  +CCFLAGS = $Config{ccflags},
 
 (Alternatively, appending $cflags to $Config{ccflags}) might be a bit
  cleaner.)
 
 Subversion maintainers: see #628522 for more information about this issue.

After further investigation, we found that the following CFLAGS are used 
internally by subversion and by perl in ArchLinux:

subversion: -march=i686 -mtune=generic -O2 -pipe  -pthread  -
D_LARGEFILE64_SOURCE -DNE_LFS

perl: -D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64

Subversion seems to get his largefile support from APR

# apr-1-config --cppflags
 -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE

where the -D_FILE_OFFSET_BITS=64 is missing (and probably not necessary 
there).

The perl binding on the other hand get CFLAGS from perl -MExtUtils::Embed -e 
ccopts  :

# perl -MExtUtils::Embed -e ccopts
 -D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -
I/usr/local/include -D_LARGEFILE_SOURCE -
D_FILE_OFFSET_BITS=64  -I/usr/lib/perl5/core_perl/CORE

A simpler/less intrusive workaround could be to

export CFLAGS+= -D_FILE_OFFSET_BITS=64

before running the configure script.

--
Stéphane Gaudreault
ArchLinux developer




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#628507: [PATCH] subversion: FTBFS with perl 5.14: test failures

2011-07-11 Thread Peter Samuelson 

[Niko Tyni]
 Thanks Stéphane!
 
  -CCFLAGS = $cflags,
  +CCFLAGS = $Config{ccflags},
 
 (Alternatively, appending $cflags to $Config{ccflags}) might be a bit
  cleaner.)

Indeed, I was trying to investigate this issue, to confirm for myself
that the function bit really is the LFS flags, and that it won't break
anything to specify both sets of CFLAGS ... but I ran out of time last
night.  And now Philip Martin upstream beat me to it.  So, yeah, I'll
just use his version:

http://svn.apache.org/viewvc?rev=1145203view=rev

Thanks,
-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#628507: [PATCH] subversion: FTBFS with perl 5.14: test failures

2011-07-09 Thread Niko Tyni 
tag 628507 patch
thanks

On Fri, Jul 01, 2011 at 06:10:21PM -0400, Stéphane Gaudreault wrote:
 
 Our collegue Marcela Mašláňová from the Red Hat team suggested that the 
 problem might be in in Makefile.PL where ExtUtils::MakeMaker overwrite the 
 CCFLAGS. The following patch fixed the problem for us.

Thanks Stéphane!

 -CCFLAGS = $cflags,
 +CCFLAGS = $Config{ccflags},

(Alternatively, appending $cflags to $Config{ccflags}) might be a bit
 cleaner.)

Subversion maintainers: see #628522 for more information about this issue.
-- 
Niko Tyni   nt...@debian.org



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#628507: [PATCH] subversion: FTBFS with perl 5.14: test failures

2011-07-01 Thread Stéphane Gaudreault 
Hi, 

Our collegue Marcela Mašláňová from the Red Hat team suggested that the 
problem might be in in Makefile.PL where ExtUtils::MakeMaker overwrite the 
CCFLAGS. The following patch fixed the problem for us.

Regards,

--
Stéphane Gaudreault
ArchLinux developer

===
diff -Naur 
subversion-1.6.17.ori/subversion/bindings/swig/perl/native/Makefile.PL.in 
subversion-1.6.17/subversion/bindings/swig/perl/native/Makefile.PL.in
--- subversion-1.6.17.ori/subversion/bindings/swig/perl/native/Makefile.PL.in   
2010-11-24 20:42:16.0 +
+++ subversion-1.6.17/subversion/bindings/swig/perl/native/Makefile.PL.in   
2011-07-01 20:16:16.520892074 +
@@ -43,7 +43,7 @@
 my %config = (
 ABSTRACT = 'Perl bindings for Subversion',
 DEFINE = $cppflags,
-CCFLAGS = $cflags,
+CCFLAGS = $Config{ccflags},
 INC  = join(' ',$apr_cflags, $apu_cflags, 
   -I$swig_srcdir/perl/libsvn_swig_perl,
   -I$svnlib_srcdir/include,



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org