Bug#631936: cvs: should launch editor if EDITOR environment variable is not set

2011-06-28 Thread YOSHINO Yoshihito 
Package: cvs
Version: 2:1.12.13+real-4
Severity: normal
Tags: patch

According to Debian Policy (11.4. Editors and pagers), if EDITOR environment
variable is not set, programs that launch an editor should use
`/usr/bin/editor'.

A simple patch to use /usr/bin/editor is attached.

BTW, /bin/ed is not always available on Debian systems, since package ed has
priority optional.

Thanks,
-- 
YOSHINO Yoshihito yy.y.ja...@gmail.com

-- System Information:
Debian Release: wheezy/sid
  APT prefers oldstable
  APT policy: (500, 'oldstable'), (500, 'unstable'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.39-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cvs depends on:
ii  adduser 3.113add and remove users and groups
ii  dpkg1.16.0.3 Debian package management system
ii  install-info4.13a.dfsg.1-6   Manage installed documentation in
ii  libbsd0 0.3.0-1  utility functions from BSD systems
ii  libc6   2.13-7   Embedded GNU C Library: Shared lib
ii  libcomerr2  1.41.12-4stable1 common error description library
ii  libgssapi-krb5-21.9.1+dfsg-1+b1  MIT Kerberos runtime libraries - k
ii  libk5crypto31.9.1+dfsg-1+b1  MIT Kerberos runtime libraries - C
ii  libkrb5-3   1.9.1+dfsg-1+b1  MIT Kerberos runtime libraries
ii  zlib1g  1:1.2.3.4.dfsg-3 compression library - runtime

Versions of packages cvs recommends:
pn  mksh  none (no description available)
ii  openssh-client1:5.8p1-4  secure shell (SSH) client, for sec

Versions of packages cvs suggests:
ii  rcs   5.7-25 The GNU Revision Control System

-- debconf information:
  cvs/pserver_repos_individual: true
  cvs/pserver_setspawnlimit: false
  cvs/rotatekeep: 7
  cvs/badrepositories: create
  cvs/rotatekeep_individual: 7
  cvs/pserver_repos: all
  cvs/pserver: false
  cvs/repositories: /srv/cvs
  cvs/rotatekeep_nondefault: no
  cvs/rotate_individual: true
  cvs/pserver_spawnlimit: 400
  cvs/rotatehistory: no
--- cvs-1.12.13+real/debian/rules.orig	2011-06-28 20:11:10.0 +0900
+++ cvs-1.12.13+real/debian/rules	2011-06-28 20:58:15.935715450 +0900
@@ -60,7 +60,7 @@
 			--with-gssapi \
 			--with-external-zlib \
 			--with-rsh=ssh \
-			--with-editor=/bin/ed \
+			--with-editor=/usr/bin/editor \
 			--with-tmpdir=/var/tmp \
 			--with-umask=002 \
 			--with-cvs-admin-group=_cvsadmin

Bug#631936: cvs: should launch editor if EDITOR environment variable is not set

2011-06-28 Thread Thorsten Glaser 
YOSHINO Yoshihito dixit:

A simple patch to use /usr/bin/editor is attached.

Thanks, will be applied.

BTW, /bin/ed is not always available on Debian systems, since package ed has
priority optional.

Hrm. It should be IMHO. (But then, I come back here from the Unix world…)

bye,
//mirabilos
-- 
08:05⎜XTaran:#grml mika: Does grml have an tool to read Apple
 ⎜System Log (asl) files? :)
08:08⎜ft:#grml yeah. /bin/rm. ;)   08:09⎜mrud:#grml hexdump -C
08:31⎜XTaran:#grml ft, mrud: *g*



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org