Bug#633850: lintian: check for dh-make boilerplate in README.source

2017-05-19 Thread Chris Lamb
tags 633850 + pending
thanks

Fixed in Git:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=9c090548252e7791b7c66a9ab06b26f688e245fb


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#633850: lintian: check for dh-make boilerplate in README.source

2014-12-30 Thread Riley
Package: lintian
Version: 2.5.30+deb8u3
Followup-For: Bug #633850

This feature is still not implemented in the current version of Lintian. I ran
into this today when inspecting the swapspace package
(http://mentors.debian.net/package/swapspace).

Any chance that this will be solved soon (either by the patch previously sent,
or some other means)?



-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 3.13-1-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils   2.24.90.20141209-1
ii  bzip2  1.0.6-7+b2
ii  diffstat   1.58-1
ii  file   1:5.20-2
ii  gettext0.19.3-2
ii  hardening-includes 2.7
ii  intltool-debian0.35.0+20060710.1
ii  libapt-pkg-perl0.1.29+b2
ii  libarchive-zip-perl1.39-1
ii  libclass-accessor-perl 0.34-1
ii  libclone-perl  0.37-1+b1
ii  libdpkg-perl   1.17.22
ii  libemail-valid-perl1.195-1
ii  libfile-basedir-perl   0.03-1
ii  libipc-run-perl0.92-1
ii  liblist-moreutils-perl 0.33-2+b1
ii  libparse-debianchangelog-perl  1.2.0-1.1
ii  libtext-levenshtein-perl   0.11-1
ii  libtimedate-perl   2.3000-2
ii  liburi-perl1.64-1
ii  man-db 2.7.0.2-4
ii  patchutils 0.3.3-1
ii  perl [libdigest-sha-perl]  5.20.1-3
ii  t1utils1.38-3

Versions of packages lintian recommends:
ii  libautodie-perl 2.25-1
ii  libperlio-gzip-perl 0.18-3+b1
ii  perl5.20.1-3
ii  perl-modules [libautodie-perl]  5.20.1-3

Versions of packages lintian suggests:
pn  binutils-multiarch none
ii  dpkg-dev   1.17.22
ii  libhtml-parser-perl3.71-1+b3
ii  libtext-template-perl  1.46-1
pn  libyaml-perl   none
ii  xz-utils   5.1.1alpha+20120614-2+b3

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#633850: lintian: check for dh-make boilerplate in README.source

2013-11-08 Thread Jakub Wilk

* Jakub Wilk jw...@debian.org, 2011-07-14, 14:20:

Please warn if debian/README.source contains the following string:

You WILL either need to modify or delete this file


I attach patch that I wrote back in 2011. IIRC Niels didn't like my approach, 
but at least the tests should be useful.


--
Jakub Wilk
diff --git a/checks/patch-systems.desc b/checks/patch-systems.desc
--- a/checks/patch-systems.desc
+++ b/checks/patch-systems.desc
@@ -185,3 +185,15 @@
  can refer to tt/usr/share/doc/dpatch/README.source.gz/tt for dpatch.
 Ref: policy 4.14
 
+Tag: source-readme-contains-dh-make-template
+Severity: normal
+Certainty: certain
+Info: The README.source file installed by this package contains the template
+ phrase from the README.source provided by dh-make:
+ .
+  You WILL either need to modify or delete this file
+ .
+ If there is real information in the file, please delete any generic
+ template phrases.  If there is nothing to say in the file, it is best
+ removed.
+
diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -246,6 +246,14 @@
 }
 }
 
+#- look for dh-make boilerplate in README.source
+if (-f $droot/README.source and not -l $droot/README.source) {
+$_ = slurp_entire_file($droot/README.source);
+if (m,You WILL either need to modify or delete this file,o) {
+tag 'source-readme-contains-dh-make-template';
+}
+}
+
 #- general cruft checking:
 if ($uses_patch_system  1) {
 tag 'more-than-one-patch-system';
diff --git a/t/tests/generic-dh-make-2011/debian/Makefile b/t/tests/generic-dh-make-2011/debian/Makefile
new file mode 100644
--- /dev/null
+++ b/t/tests/generic-dh-make-2011/debian/Makefile
@@ -0,0 +1,4 @@
+# Stub Makefile that's just enough so that the default rules file doesn't
+# error out.
+
+clean install:
diff --git a/t/tests/generic-dh-make-2011/debian/README b/t/tests/generic-dh-make-2011/debian/README
new file mode 100644
--- /dev/null
+++ b/t/tests/generic-dh-make-2011/debian/README
@@ -0,0 +1,13 @@
+dh_make 0.50 test
+=
+
+This is the results of running dh_make 0.50 on an upstream tarball
+containing only this file.  It's a useful test for the various dh_make
+template and boilerplate tags, as well as many tags for ways of doing
+things dh_make used to promote but are now deprecated or old debhelper
+commands that are now deprecated.
+
+Please don't modify anything about the files in this package; instead, add
+new tags as needed when Lintian adds new checks.  This test case is
+intended to continue to be a test of Lintian's handling of old and
+template packages.
diff --git a/t/tests/generic-dh-make-2011/debian/debian/README.Debian b/t/tests/generic-dh-make-2011/debian/debian/README.Debian
new file mode 100644
--- /dev/null
+++ b/t/tests/generic-dh-make-2011/debian/debian/README.Debian
@@ -0,0 +1,6 @@
+generic-dh-make-2011 for Debian
+---
+
+possible notes regarding this package - if none, delete this file
+
+ -- Jakub Wilk jw...@debian.org  Thu, 08 Sep 2011 18:15:43 +
diff --git a/t/tests/generic-dh-make-2011/debian/debian/README.source b/t/tests/generic-dh-make-2011/debian/debian/README.source
new file mode 100644
--- /dev/null
+++ b/t/tests/generic-dh-make-2011/debian/debian/README.source
@@ -0,0 +1,9 @@
+generic-dh-make-2011 for Debian
+---
+
+this file describes information about the source package, see Debian policy
+manual section 4.14. You WILL either need to modify or delete this file
+
+
+
+
diff --git a/t/tests/generic-dh-make-2011/debian/debian/changelog b/t/tests/generic-dh-make-2011/debian/debian/changelog
new file mode 100644
--- /dev/null
+++ b/t/tests/generic-dh-make-2011/debian/debian/changelog
@@ -0,0 +1,5 @@
+generic-dh-make-2011 (1.0-1) unstable; urgency=low
+
+  * Initial release (Closes: #)   is the bug number of your ITP
+
+ -- Jakub Wilk jw...@debian.org  Thu, 08 Sep 2011 18:15:43 +
diff --git a/t/tests/generic-dh-make-2011/debian/debian/compat b/t/tests/generic-dh-make-2011/debian/debian/compat
new file mode 100644
--- /dev/null
+++ b/t/tests/generic-dh-make-2011/debian/debian/compat
@@ -0,0 +1,1 @@
+8
diff --git a/t/tests/generic-dh-make-2011/debian/debian/control b/t/tests/generic-dh-make-2011/debian/debian/control
new file mode 100644
--- /dev/null
+++ b/t/tests/generic-dh-make-2011/debian/debian/control
@@ -0,0 +1,15 @@
+Source: generic-dh-make-2011
+Section: unknown
+Priority: extra
+Maintainer: Jakub Wilk jw...@debian.org
+Build-Depends: debhelper (= 8.0.0)
+Standards-Version: 3.9.2
+Homepage: insert the upstream URL, if relevant
+#Vcs-Git: git://git.debian.org/collab-maint/generic-dh-make-2011.git
+#Vcs-Browser: http://git.debian.org/?p=collab-maint/generic-dh-make-2011.git;a=summary
+
+Package: generic-dh-make-2011
+Architecture: any
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Description: insert up to 60 

Bug#633850: lintian: check for dh-make boilerplate in README.source

2011-07-14 Thread Jakub Wilk

Package: lintian
Version: 2.5.1
Severity: wishlist

Please warn if debian/README.source contains the following string:

You WILL either need to modify or delete this file

--
Jakub Wilk



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org