Bug#634172: /etc/spamassassin/sa-update-hooks.d output visible in /etc/cron.daily/spamassassin
Package: spamassassin
Followup-For: Bug #634172
With the rules update from the cron script, even more "spam" is sent to root
every day. Attached patch improves on Filippo Giunchedi's to quiet this
down.
-- System Information:
Debian Release: jessie/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.14-2-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages spamassassin depends on:
ii adduser 3.113+nmu3
ii init-system-helpers 1.21
pn libarchive-tar-perl
ii libhtml-parser-perl 3.71-1+b2
ii libnet-dns-perl 0.79-2
ii libnetaddr-ip-perl 4.075+dfsg-1+b1
ii libsocket6-perl 0.25-1+b1
ii libsys-hostname-long-perl 1.4-3
ii libwww-perl 6.08-1
ii perl5.20.0-4
ii perl-modules [libio-zlib-perl] 5.20.0-4
Versions of packages spamassassin recommends:
ii gnupg 1.4.18-2
ii libio-socket-inet6-perl2.72-1
ii libmail-spf-perl 2.9.0-3
ii perl [libsys-syslog-perl] 5.20.0-4
ii sa-compile 3.4.0-2
ii spamc 3.4.0-2
Versions of packages spamassassin suggests:
ii libdbi-perl 1.631-3+b1
ii libio-compress-perl [libcompress-zlib-perl] 2.064-1
ii libio-socket-ssl-perl1.997-2
ii libmail-dkim-perl0.40-1
ii perl [libcompress-zlib-perl] 5.20.0-4
ii pyzor1:0.5.0-2
ii razor1:2.85-4.1+b1
-- Configuration Files:
/etc/cron.daily/spamassassin changed:
CRON=0
test -f /etc/default/spamassassin && . /etc/default/spamassassin
test -x /usr/bin/sa-update || exit 0
test -x /etc/init.d/spamassassin || exit 0
if [ "$CRON" = "0" ] ; then
exit 0
fi
die_with_lint() {
env -i LANG="$LANG" PATH="$PATH" start-stop-daemon \
--chuid debian-spamd:debian-spamd --start \
--exec /usr/bin/spamassassin -- -D --lint 2>&1
exit 1
}
do_compile() {
if [ -x /usr/bin/re2c -a -x /usr/bin/sa-compile ]; then
env -i LANG="$LANG" PATH="$PATH" start-stop-daemon \
--chuid debian-spamd:debian-spamd --start \
--exec /usr/bin/sa-compile -- --quiet >/dev/null
# Fixup perms -- group and other should be able to
# read and execute, but never write. Works around
# sa-compile's failure to obey umask.
chmod -R go-w,go+rX /var/lib/spamassassin/compiled
fi
}
reload() {
# Reload
if which invoke-rc.d >/dev/null 2>&1; then
invoke-rc.d spamassassin reload > /dev/null
else
/etc/init.d/spamassassin reload > /dev/null
fi
if [ -d /etc/spamassassin/sa-update-hooks.d ]; then
# >/dev/null: bugs.debian.org/634172
run-parts --lsbsysinit /etc/spamassassin/sa-update-hooks.d > /dev/null
fi
}
if [ ! -t 0 ]; then
RANGE=3600
number=`od -vAn -N2 -tu4 < /dev/urandom`
number=`expr $number "%" $RANGE`
sleep $number
fi
umask 022
env -i LANG="$LANG" PATH="$PATH" start-stop-daemon \
--chuid debian-spamd:debian-spamd --start \
--exec /usr/bin/sa-update -- \
--gpghomedir /var/lib/spamassassin/sa-update-keys 2>&1
case $? in
0)
# got updates!
env -i LANG="$LANG" PATH="$PATH" start-stop-daemon \
--chuid debian-spamd:debian-spamd --start \
--exec /usr/bin/spamassassin -- --lint 2>&1 || die_with_lint
do_compile >/dev/null
reload
;;
1)
# no updates
exit 0
;;
2)
# lint failed!
die_with_lint
;;
*)
echo "sa-update failed for unknown reasons" 1>&2
;;
esac
/etc/default/spamassassin changed:
ENABLED=1
OPTIONS="--create-prefs --max-children 5 --helper-home-dir"
PIDFILE="/var/run/spamd.pid"
CRON=1
/etc/spamassassin/v310.pre changed:
loadplugin Mail::SpamAssassin::Plugin::Pyzor
loadplugin Mail::SpamAssassin::Plugin::Razor2
loadplugin Mail::SpamAssassin::Plugin::SpamCop
loadplugin Mail::SpamAssassin::Plugin::AWL
loadplugin Mail::SpamAssassin::Plugin::AutoLearnThreshold
loadplugin Mail::SpamAssassin::Plugin::WhiteListSubject
loadplugin Mail::SpamAssassin::Plugin::MIMEHeader
loadplugin Mail::SpamAssassin::Plugin::ReplaceTags
/etc/spamassassin/v320.pre changed:
loadplugin Mail::SpamAssassin::Plugin::Check
loadplugin Mail::SpamAssassin::Plugin::HTTPSMismatch
loadplugin Mail::SpamAssassin::Plugin::URIDetail
loadplugin Mail::SpamAssassin::Plugin::Bayes
loadplugin Mail::SpamAssassin::Plugin::BodyEval
loadplugin Mail::SpamAssassin::Plugin::DNSEval
loadplugin Mail::SpamAssassin::Plugin::HTMLEval
loadplugin Mail::SpamAssassin::Plugin::HeaderEval
loadplugin Mail::SpamAssassin::Plu
Bug#634172: /etc/spamassassin/sa-update-hooks.d output visible in /etc/cron.daily/spamassassin
Package: spamassassin Severity: minor Hi, it seems that when using run-parts for running /etc/spamassassin/sa-update-hooks.d the stdout is not redirected to /dev/null thus mailing root when e.g. spampd is restarted. trivial patch attached thanks, filippo -- System Information: Debian Release: 6.0.2 APT prefers stable APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'proposed-updates'), (200, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Index: debian/spamassassin.cron.daily === --- debian/spamassassin.cron.daily (revision 18876) +++ debian/spamassassin.cron.daily (working copy) @@ -48,7 +48,7 @@ /etc/init.d/spamassassin reload > /dev/null fi if [ -d /etc/spamassassin/sa-update-hooks.d ]; then -run-parts --lsbsysinit /etc/spamassassin/sa-update-hooks.d +run-parts --lsbsysinit /etc/spamassassin/sa-update-hooks.d > /dev/null fi }
