Bug#636158: maradns: Debian default config is not robust to user change + upgrade
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Dear Debian Release Team, Please could I have a stay of execution on maradns? I am somewhat overwhelmed with stuff at the moment but I am steadily working my way through it (including the Debian stuff). And the maradns RC bug came fairly late in the whole release cycle. I would also accept an NMU if one turns up. On 23/10/12 17:42, gregor herrmann wrote: On Wed, 26 Sep 2012 17:59:17 +0200, gregor herrmann wrote: Find attached a quick patch which seems to work (as in: create /etc/maradns/mararc on a new install and leave it alone for upgrades). Of course the template could be put somewhere else, and the nested conditions in the postinst written differently. Hi Nicholas, I noticed that maradns is on the Release Team's removal candidate list: https://lists.debian.org/debian-devel/2012/10/msg00373.html Are you going to upload a fix before Friday (or to contact them) or can I help in any way? Cheers, gregor -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJQia0+AAoJELbE2bY7/+c8SMsP/0J1L8VbJZcsJ6VXw7d14hp0 dSEyxzxlXU3LZcV7k1A7DATd8Ut9Fg2uDCs4l1X9qkz4oVkBy4OqLL5UIRl7Bb0x XfkcygoZwvYcDgHiA04mSeo1ILXq6DVVisy5aGM72Nhoaiasbok14LTW/El5qSy6 PdcE63yT/vJ3B5ZSBSEmoSTI1SA1hRijwTCZtq49qcWsUa+DqA3IKoMhKXA/VmaK 1xhpPDA7A//o12FQuenY4jDgK/qCRyj390OqT1cobJa1EU6PUyYAWlNudShhN04L IfW3XhdF8jiuSddGo4FVclmdc66a5A0w3Gr3PELDHACoDnxyd/ZCOEEF7jt+dQr7 Tzy4H6o+y1iy35p6uuTgz4zyQ/xMwxc0H6Y5SwFsw7lHnxm461bNJdbv9xnBsgHI Mr2wGVdvJ7PgLxugvKfLQU9ay77mjpMY1iKSYuY3pcm2bVydA6ajE39xg8seJSLz 6t6SDF71V796RWgs8C6RxUZ/iPprFvBQJsREA4d9otlL6lQ/p8Ex/EmHbcZCeAbC U6Kf7km7a5xt153O02MhorPC/AY/OIwViHcHU4Yz2JeeXtE2I5Js4flrg9l9yK0U M0SvdhByDcFoDnLhlMek1vwcfD1NdUujGy6uZi0oV5BpdpDvpC0eFQJS4c0UMb1H WecPVO6LsfN/6gCw98ZN =3re5 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#636158: maradns: Debian default config is not robust to user change + upgrade
On 2012-10-25 23:21, Nicholas Bamber wrote: Dear Debian Release Team, Please could I have a stay of execution on maradns? I am somewhat overwhelmed with stuff at the moment but I am steadily working my way through it (including the Debian stuff). And the maradns RC bug came fairly late in the whole release cycle. I would also accept an NMU if one turns up. [...] Certainly. I have taken maradns off the list for now. Would an extra week enough? ~Niels -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#636158: maradns: Debian default config is not robust to user change + upgrade
On 25/10/12 22:35, Niels Thykier wrote: On 2012-10-25 23:21, Nicholas Bamber wrote: Dear Debian Release Team, Please could I have a stay of execution on maradns? I am somewhat overwhelmed with stuff at the moment but I am steadily working my way through it (including the Debian stuff). And the maradns RC bug came fairly late in the whole release cycle. I would also accept an NMU if one turns up. [...] Certainly. I have taken maradns off the list for now. Would an extra week enough? ~Niels Thanks. I'll probably being looking at it from Monday. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#636158: maradns: Debian default config is not robust to user change + upgrade
On Thu, 25 Oct 2012 22:21:04 +0100, Nicholas Bamber wrote: Please could I have a stay of execution on maradns? I am somewhat overwhelmed with stuff at the moment but I am steadily working my way through it (including the Debian stuff). And the maradns RC bug came fairly late in the whole release cycle. I would also accept an NMU if one turns up. I can upload the package with the patch I sent earlier if you're ok with it; I just didn't want to go ahead with an NMU since we were talking the exact same day on IRC and I knew that you are aware of the bug :) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: R.E.M.: Everybody Hurts signature.asc Description: Digital signature
Bug#636158: maradns: Debian default config is not robust to user change + upgrade
On Wed, 26 Sep 2012 17:59:17 +0200, gregor herrmann wrote: Find attached a quick patch which seems to work (as in: create /etc/maradns/mararc on a new install and leave it alone for upgrades). Of course the template could be put somewhere else, and the nested conditions in the postinst written differently. Hi Nicholas, I noticed that maradns is on the Release Team's removal candidate list: https://lists.debian.org/debian-devel/2012/10/msg00373.html Are you going to upload a fix before Friday (or to contact them) or can I help in any way? Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Janis Joplin: Cry Baby signature.asc Description: Digital signature
Bug#636158: maradns: Debian default config is not robust to user change + upgrade
Control: tag -1 + patch On Sun, 31 Jul 2011 21:29:24 +0100, Nicholas Bamber wrote: The upstream maradns install notes describe a very minimal config file. I think what we need to do is capture that minimal config in debconf and otherwise respect whatever is in found the config file. Of course if there is no config file we need to install one. That sounds like a good way in the long run. But there _might_ be an easier short-term option: - If I understand the problem correctly, the packages currently ships /etc/maradns/mararc and modifies it in the postinst; but only on fresh installs; - in this case it might be enough to + ship the template under a different name than /etc/maradns/mararc + do the fixup in postinst only on new installs (like now) _and_ if the file in /etc doesn't exist (as an additional precaution) Find attached a quick patch which seems to work (as in: create /etc/maradns/mararc on a new install and leave it alone for upgrades). Of course the template could be put somewhere else, and the nested conditions in the postinst written differently. Hope that helps, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Leonard Cohen: Different Sides diff -Nru maradns-1.4.12/debian/changelog maradns-1.4.12/debian/changelog --- maradns-1.4.12/debian/changelog 2012-06-08 22:38:28.0 +0200 +++ maradns-1.4.12/debian/changelog 2012-09-26 17:56:10.0 +0200 @@ -1,3 +1,14 @@ +maradns (1.4.12-3.1) UNRELEASED; urgency=low + + * Non-maintainer upload. + * Fix Debian default config is not robust to user change + upgrade: +- install template configuration file outside /etc +- make sure that it's created in /etc only for new installs and if it + doesn't exist +(Closes: #636158) + + -- gregor herrmann gre...@debian.org Wed, 26 Sep 2012 17:26:01 +0200 + maradns (1.4.12-3) unstable; urgency=low * Improved changelog parsing to work with binNMUs (Closes: #675392) diff -Nru maradns-1.4.12/debian/maradns.install maradns-1.4.12/debian/maradns.install --- maradns-1.4.12/debian/maradns.install 2012-02-02 10:50:22.0 +0100 +++ maradns-1.4.12/debian/maradns.install 2012-09-26 17:38:00.0 +0200 @@ -3,5 +3,5 @@ tcp/fetchzone usr/sbin tcp/getzone usr/sbin server/maradns usr/sbin -debian/mararc etc/maradns +debian/mararc usr/share/maradns debian/maradns-insserv etc/insserv.conf.d diff -Nru maradns-1.4.12/debian/postinst maradns-1.4.12/debian/postinst --- maradns-1.4.12/debian/postinst 2012-02-02 10:50:22.0 +0100 +++ maradns-1.4.12/debian/postinst 2012-09-26 17:45:40.0 +0200 @@ -11,16 +11,17 @@ mkdir -p /etc/maradns/logger -if [ $1 = configure ] [ -f /etc/maradns/mararc ] +if [ $1 = configure ] then IDNUM=`id -u maradns` GIDNUM=`id -g maradns` - if [ $2 = ] # we are doing fresh install + if [ $2 = ] [ ! -f /etc/maradns/mararc ] # we are doing fresh install then sed -e s/^maradns_uid = .*$/maradns_uid = $IDNUM/ \ - -e s/^# maradns_gid = .*$/maradns_gid = $GIDNUM/ /etc/maradns/mararc /etc/maradns/mararc.tmp + -e s/^# maradns_gid = .*$/maradns_gid = $GIDNUM/ /usr/share/maradns/mararc /etc/maradns/mararc.tmp mv -f /etc/maradns/mararc.tmp /etc/maradns/mararc - else + elif [ -f /etc/maradns/mararc ] + then grep -q maradns_uid = $IDNUM /etc/maradns/mararc || echo WARNING: maradns_uid = $IDNUM is missing from /etc/maradns/mararc fi fi signature.asc Description: Digital signature
Bug#636158: maradns: Debian default config is not robust to user change + upgrade
Package: maradns Version: 1.4.06-3 Severity: important The upstream maradns install notes describe a very minimal config file. I think what we need to do is capture that minimal config in debconf and otherwise respect whatever is in found the config file. Of course if there is no config file we need to install one. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages maradns depends on: ii adduser 3.113 add and remove users and groups ii duende1.4.06-3 logging daemonizer ii libc6 2.13-10Embedded GNU C Library: Shared lib ii lsb-base 3.2-27 Linux Standard Base 3.2 init scrip Versions of packages maradns recommends: ii maradns-zoneserver1.4.06-3 complementary server process to TC ii python2.6.7-1interactive high-level object-orie maradns suggests no packages. -- Configuration Files: /etc/default/maradns changed [not included] /etc/maradns/mararc changed [not included] -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
