Bug#641814: gwaei: uses functions deprecated in GTK+ 3.2, causing build failure on amd64

2011-09-17 Thread Norbert Preining 
On Fr, 16 Sep 2011, Colin Watson wrote:
 ... gwaei uses the gtk_hbox_new and gtk_vbox_new functions, which are
 deprecated in GTK+ 3.2.  This causes a problem on 64-bit architectures

Thanks, I am trying to forward this to upstream, unfortunately the
gmail adress has disappeared, but another worked, AFAIS.

Either I make another Debian release soon, or wait for an update
from upstream, if I get reply.

Thanks a lot and all the best

Norbert


Norbert Preiningpreining@{jaist.ac.jp, logic.at, debian.org}
JAIST, Japan TeX Live  Debian Developer
DSA: 0x09C5B094   fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094

BROMSGROVE
Any urban environment containing a small amount of dogturd and about
forty-five tons of bent steel pylon or a lump of concrete with holes
claiming to be sculpture. 'Oh, come my dear, and come with me. And
wander 'neath the bromsgrove tree' - Betjeman.
--- Douglas Adams, The Meaning of Liff



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#641814: gwaei: uses functions deprecated in GTK+ 3.2, causing build failure on amd64

2011-09-16 Thread Colin Watson 
Package: gwaei
Version: 3.0.2-1
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch oneiric

As reported in this Ubuntu bug:

  https://bugs.launchpad.net/ubuntu/+source/gwaei/+bug/831227

... gwaei uses the gtk_hbox_new and gtk_vbox_new functions, which are
deprecated in GTK+ 3.2.  This causes a problem on 64-bit architectures
due to the implicit conversion to int:

  http://wiki.debian.org/ImplicitPointerConversions

Patch follows.

  * Avoid functions deprecated in GTK+ 3.2 (LP: #831227).

diff -Nru gwaei-3.0.2/debian/patches/gtk-3.2.patch 
gwaei-3.0.2/debian/patches/gtk-3.2.patch
--- gwaei-3.0.2/debian/patches/gtk-3.2.patch1970-01-01 01:00:00.0 
+0100
+++ gwaei-3.0.2/debian/patches/gtk-3.2.patch2011-09-16 13:04:25.0 
+0100
@@ -0,0 +1,175 @@
+Description: Avoid functions deprecated in GTK+ 3.2
+Author: Colin Watson cjwat...@ubuntu.com
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/831227
+Forwarded: no
+Last-Update: 2011-09-16
+
+Index: b/src/gwaei/dictionaryinstall.c
+===
+--- a/src/gwaei/dictionaryinstall.c
 b/src/gwaei/dictionaryinstall.c
+@@ -64,7 +64,7 @@
+ editable = !di-builtin;
+ 
+ //First row
+-hbox = GTK_WIDGET (gtk_hbox_new (FALSE, 0));
++hbox = GTK_WIDGET (gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0));
+ markup = g_strdup_printf(gettext(b%s Install Details/b), 
di-longname);
+ label = gtk_label_new (NULL);
+ gtk_label_set_markup (GTK_LABEL (label), markup);
+@@ -74,7 +74,7 @@
+ gtk_widget_show_all (GTK_WIDGET (hbox));
+ 
+ //Second row
+-hbox = GTK_WIDGET (gtk_hbox_new (FALSE, 0));
++hbox = GTK_WIDGET (gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0));
+ markup = g_strdup_printf(%s, di-description);
+ label = gtk_label_new (NULL);
+ gtk_widget_set_size_request (GTK_WIDGET (label), 300, -1);
+@@ -88,7 +88,7 @@
+ 
+ //Third row
+ label = gtk_label_new (gettext(Filename: ));
+-hbox = GTK_WIDGET (gtk_hbox_new (FALSE, 0));
++hbox = GTK_WIDGET (gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0));
+ gtk_box_pack_start (GTK_BOX (hbox), GTK_WIDGET (label), FALSE, FALSE, 0);
+ gtk_table_attach_defaults (GTK_TABLE (table), hbox, 0, 1, 0, 1);
+ entry = gtk_entry_new ();
+@@ -100,7 +100,7 @@
+ 
+ //Forth row
+ label = gtk_label_new (gettext(Engine: ));
+-hbox = GTK_WIDGET (gtk_hbox_new (FALSE, 0));
++hbox = GTK_WIDGET (gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0));
+ gtk_box_pack_start (GTK_BOX (hbox), GTK_WIDGET (label), FALSE, FALSE, 0);
+ gtk_table_attach_defaults (GTK_TABLE (table), hbox, 0, 1, 1, 2);
+ combobox = gtk_combo_box_new ();
+@@ -118,11 +118,11 @@
+ 
+ //Fifth row
+ label = gtk_label_new (gettext(Source: ));
+-hbox = GTK_WIDGET (gtk_hbox_new (FALSE, 0));
++hbox = GTK_WIDGET (gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0));
+ gtk_box_pack_start (GTK_BOX (hbox), GTK_WIDGET (label), FALSE, FALSE, 0);
+ gtk_table_attach_defaults (GTK_TABLE (table), hbox, 0, 1, 2, 3);
+ 
+-hbox = GTK_WIDGET (gtk_hbox_new (FALSE, 0));
++hbox = GTK_WIDGET (gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0));
+ entry = gtk_entry_new ();
+ gtk_entry_set_text (GTK_ENTRY (entry), 
di-uri[GW_DICTINST_NEEDS_DOWNLOADING]);
+ g_signal_connect (G_OBJECT (entry), changed, G_CALLBACK 
(gw_dictionaryinstall_source_entry_changed_cb), di);
+@@ -142,7 +142,7 @@
+ 
+ //Sixth row
+ label = gtk_label_new (gettext(Encoding: ));
+-hbox = GTK_WIDGET (gtk_hbox_new (FALSE, 0));
++hbox = GTK_WIDGET (gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0));
+ gtk_box_pack_start (GTK_BOX (hbox), GTK_WIDGET (label), FALSE, FALSE, 0);
+ gtk_table_attach_defaults (GTK_TABLE (table), hbox, 0, 1, 3, 4);
+ combobox = gtk_combo_box_new ();
+@@ -159,7 +159,7 @@
+ 
+ //Seventh row
+ label = gtk_label_new (gettext(Compression: ));
+-hbox = GTK_WIDGET (gtk_hbox_new (FALSE, 0));
++hbox = GTK_WIDGET (gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0));
+ gtk_box_pack_start (GTK_BOX (hbox), GTK_WIDGET (label), FALSE, FALSE, 0);
+ gtk_table_attach_defaults (GTK_TABLE (table), hbox, 0, 1, 4, 5);
+ combobox = gtk_combo_box_new ();
+@@ -178,7 +178,7 @@
+ checkbox = gtk_check_button_new_with_label (gettext(Split Places from 
Names Dictionary));
+ gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (checkbox), di-split);
+ g_signal_connect (G_OBJECT (checkbox), toggled, G_CALLBACK 
(gw_dictionaryinstall_split_checkbox_changed_cb), di);
+-hbox = GTK_WIDGET (gtk_hbox_new (FALSE, 0));
++hbox = GTK_WIDGET (gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0));
+ gtk_box_pack_start (GTK_BOX (hbox), GTK_WIDGET (checkbox), FALSE, FALSE, 
0);
+ gtk_table_attach_defaults (GTK_TABLE (table), hbox, 0, 2, 5, 6);
+ gtk_widget_set_sensitive (GTK_WIDGET (checkbox), editable);
+@@ -188,7 +188,7 @@
+ checkbox = gtk_check_button_new_with_label