Bug#646022: coreutils: tail -f doesn't work with GPFS filesystem
Package: coreutils Version: 8.5-1 Severity: normal The tail command doesn't know the GPFS filesystem type, so it uses inotify() instead of nanosleep() when used with -f. The following line should be added to the fs.h file : # define S_MAGIC_GPFS 0x47504653 and the following line should be added to the fremote() function of the tail.c file : case S_MAGIC_GPFS: -- System Information: Debian Release: 6.0.1 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages coreutils depends on: ii libacl1 2.2.49-4 Access control list shared library ii libattr1 1:2.4.44-2 Extended attribute shared library ii libc6 2.11.2-10 Embedded GNU C Library: Shared lib ii libselinux1 2.0.96-1 SELinux runtime shared libraries coreutils recommends no packages. coreutils suggests no packages. -- no debconf information Content-Type: text/plain; charset=us-ascii MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Martial mbornet@gmail.com To: Debian Bug Tracking System sub...@bugs.debian.org Subject: coreutils: tail -f doesn't work with GPFS filesystem Message-ID: 20111020162340.3278.80419.reportbug@dell01 X-Mailer: reportbug 4.12.6 Date: Thu, 20 Oct 2011 18:23:40 +0200 Package: coreutils Version: 8.5-1 Severity: normal The tail command doesn't know the GPFS filesystem type, so it uses inotify() instead of nanosleep(). The following line should be added to the fs.h file : # define S_MAGIC_GPFS 0x47504653 and the following line should be added to the fremote() function of the tail.c file : case S_MAGIC_GPFS: -- System Information: Debian Release: 6.0.1 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages coreutils depends on: ii libacl1 2.2.49-4 Access control list shared library ii libattr1 1:2.4.44-2 Extended attribute shared library ii libc6 2.11.2-10 Embedded GNU C Library: Shared lib ii libselinux1 2.0.96-1 SELinux runtime shared libraries coreutils recommends no packages. coreutils suggests no packages. -- no debconf information
Bug#646022: coreutils: tail -f doesn't work with GPFS filesystem
Martial Bornet (gmail) wrote: Package: coreutils Version: 8.5-1 Severity: normal The tail command doesn't know the GPFS filesystem type, so it uses inotify() instead of nanosleep() when used with -f. The following line should be added to the fs.h file : # define S_MAGIC_GPFS 0x47504653 and the following line should be added to the fremote() function of the tail.c file : case S_MAGIC_GPFS: Thanks for the report. Here's the upstream patch. We already have the definition of S_MAGIC_GPFS. From c07d7486432429eb9e5cadd083d15247b0f4ab0d Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Thu, 20 Oct 2011 19:18:09 +0200 Subject: [PATCH] tail: with -f, use nanosleep, not inotify on a GPFS file system * src/tail.c (fremote): List GPFS as a remote file system type. * THANKS.in: Update. * NEWS (Bug fixes): Mention it. Report and suggested change by Martial Bornet in http://bugs.debian.org/646022. --- NEWS |4 THANKS.in |1 + src/tail.c |1 + 3 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 3ed44b2..4d210b5 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,10 @@ GNU coreutils NEWS-*- outline -*- tac no longer fails to handle two or more non-seekable inputs [bug introduced in coreutils-5.3.0] + tail -f no longer tries to use inotify on GPFS file systems + [you might say this was introduced in coreutils-7.5, along with inotify + support, but the GPFS magic number wasn't in the usual places then.] + * Noteworthy changes in release 8.14 (2011-10-12) [stable] diff --git a/THANKS.in b/THANKS.in index 83a7864..b99363b 100644 --- a/THANKS.in +++ b/THANKS.in @@ -367,6 +367,7 @@ Mark Melahn mmel...@gmail.com Mark Nudelman mar...@flash.net Mark W. Eichin eic...@cygnus.com Markus Demleitner msdem...@auriga.ari.uni-heidelberg.de +Martial Bornet mbornet@gmail.com Martin mar...@dresden.nacamar.de Martin Buck martin.b...@ascom.ch Martin Gallant mar...@goodbit.net diff --git a/src/tail.c b/src/tail.c index f315776..1641a12 100644 --- a/src/tail.c +++ b/src/tail.c @@ -904,6 +904,7 @@ fremote (int fd, const char *name) case S_MAGIC_FUSEBLK: case S_MAGIC_FUSECTL: case S_MAGIC_GFS: +case S_MAGIC_GPFS: case S_MAGIC_KAFS: case S_MAGIC_LUSTRE: case S_MAGIC_NCP: -- 1.7.7.419.g87009 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#646022: coreutils: tail -f doesn't work with GPFS filesystem
Thank you very much for your quick answer. Best regards. Martial Bornet Le 20/10/2011 19:19, Jim Meyering a écrit : Martial Bornet (gmail) wrote: Package: coreutils Version: 8.5-1 Severity: normal The tail command doesn't know the GPFS filesystem type, so it uses inotify() instead of nanosleep() when used with -f. The following line should be added to the fs.h file : # define S_MAGIC_GPFS 0x47504653 and the following line should be added to the fremote() function of the tail.c file : case S_MAGIC_GPFS: Thanks for the report. Here's the upstream patch. We already have the definition of S_MAGIC_GPFS. From c07d7486432429eb9e5cadd083d15247b0f4ab0d Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Thu, 20 Oct 2011 19:18:09 +0200 Subject: [PATCH] tail: with -f, use nanosleep, not inotify on a GPFS file system * src/tail.c (fremote): List GPFS as a remote file system type. * THANKS.in: Update. * NEWS (Bug fixes): Mention it. Report and suggested change by Martial Bornet in http://bugs.debian.org/646022. --- NEWS |4 THANKS.in |1 + src/tail.c |1 + 3 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 3ed44b2..4d210b5 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,10 @@ GNU coreutils NEWS-*- outline -*- tac no longer fails to handle two or more non-seekable inputs [bug introduced in coreutils-5.3.0] + tail -f no longer tries to use inotify on GPFS file systems + [you might say this was introduced in coreutils-7.5, along with inotify + support, but the GPFS magic number wasn't in the usual places then.] + * Noteworthy changes in release 8.14 (2011-10-12) [stable] diff --git a/THANKS.in b/THANKS.in index 83a7864..b99363b 100644 --- a/THANKS.in +++ b/THANKS.in @@ -367,6 +367,7 @@ Mark Melahn mmel...@gmail.com Mark Nudelman mar...@flash.net Mark W. Eichin eic...@cygnus.com Markus Demleitner msdem...@auriga.ari.uni-heidelberg.de +Martial Bornet mbornet@gmail.com Martin mar...@dresden.nacamar.de Martin Buck martin.b...@ascom.ch Martin Gallant mar...@goodbit.net diff --git a/src/tail.c b/src/tail.c index f315776..1641a12 100644 --- a/src/tail.c +++ b/src/tail.c @@ -904,6 +904,7 @@ fremote (int fd, const char *name) case S_MAGIC_FUSEBLK: case S_MAGIC_FUSECTL: case S_MAGIC_GFS: +case S_MAGIC_GPFS: case S_MAGIC_KAFS: case S_MAGIC_LUSTRE: case S_MAGIC_NCP: -- 1.7.7.419.g87009 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
