Bug#646957: mount -o remount,rw has no effect with kFreeBSD 9.0

2011-10-30 Thread Benjamin Kaduk

On Sun, 30 Oct 2011, Aurelien Jarno wrote:


On Sat, Oct 29, 2011 at 02:27:53PM -0400, Benjamin Kaduk wrote:

On Sat, 29 Oct 2011, Robert Millan wrote:


2011/10/29 Aurelien Jarno aurel...@aurel32.net:

Which seems to be kfreebsd-9 related, not busybox related.

This is very likely to be the same bug than the one fixed in kfreebsd-8
by 107_mount_update.diff. This patch has been disabled in kfreebsd-9
(probably because this part has been changed upstream), so this is where
to look first.


Uhm... ISTR it's me who removed that patch during the upgrade.  In any
case, I re-checked, and it seems to me that the code that made iovec
arguments a requirement is no longer present.


Err, I don't see any iovec arguments in the 107_mount_update.diff
that google finds for me as [Glibc-bsd-commits] r3165.



I don't have time to look deeper right now though :-(


Until we are sure it's not a kfreebsd-9 bug, it's better to keep the bug
assigned to kfreebsd-9.


Since stock freebsd is documented as requiring -u (update) when
changing the mount options of an already-mounted filesystem, it
seems very likely to be a kfreebsd bug.



Requiring -u is a requirement from the userland mount utility. Here we
are talking about the kernel interface. In this case the MNT_UPDATE flag
passed to the nmount() function is ignored if the filesystem was mounted
ro and the update is to mount it rw.


Well, shame on me for not reading the kernel code before posting.
Though, a quick glance at vfs_donmount and vfs_domount{,_update} do not 
make things terribly clear how this works.  I'm not up for grubbing 
through vfs_getopt today, though, so I'll leave it be.


-Ben



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#646957: mount -o remount,rw has no effect with kFreeBSD 9.0

2011-10-29 Thread Aurelien Jarno
reassign 646957 kfreebsd-9
thanks

On Fri, Oct 28, 2011 at 07:56:24PM +0200, Robert Millan wrote:
 Package: busybox
 Version: 1:1.17.1-8
 Severity: normal
 Tags: d-i
 User: debian-...@lists.debian.org
 Usertags: kfreebsd
 
 When running on kFreeBSD 9.0, mount -o remount,rw no longer remounts the
 target file system in writable mode.
 

Which seems to be kfreebsd-9 related, not busybox related.

This is very likely to be the same bug than the one fixed in kfreebsd-8
by 107_mount_update.diff. This patch has been disabled in kfreebsd-9
(probably because this part has been changed upstream), so this is where
to look first.

Until we are sure it's not a kfreebsd-9 bug, it's better to keep the bug
assigned to kfreebsd-9.

-- 
Aurelien Jarno  GPG: 1024D/F1BCDB73
aurel...@aurel32.net http://www.aurel32.net



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#646957: mount -o remount,rw has no effect with kFreeBSD 9.0

2011-10-29 Thread Robert Millan
2011/10/29 Aurelien Jarno aurel...@aurel32.net:
 Which seems to be kfreebsd-9 related, not busybox related.

 This is very likely to be the same bug than the one fixed in kfreebsd-8
 by 107_mount_update.diff. This patch has been disabled in kfreebsd-9
 (probably because this part has been changed upstream), so this is where
 to look first.

Uhm... ISTR it's me who removed that patch during the upgrade.  In any
case, I re-checked, and it seems to me that the code that made iovec
arguments a requirement is no longer present.

I don't have time to look deeper right now though :-(

 Until we are sure it's not a kfreebsd-9 bug, it's better to keep the bug
 assigned to kfreebsd-9.

Ok.

-- 
Robert Millan



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#646957: mount -o remount,rw has no effect with kFreeBSD 9.0

2011-10-29 Thread Benjamin Kaduk

On Sat, 29 Oct 2011, Robert Millan wrote:


2011/10/29 Aurelien Jarno aurel...@aurel32.net:

Which seems to be kfreebsd-9 related, not busybox related.

This is very likely to be the same bug than the one fixed in kfreebsd-8
by 107_mount_update.diff. This patch has been disabled in kfreebsd-9
(probably because this part has been changed upstream), so this is where
to look first.


Uhm... ISTR it's me who removed that patch during the upgrade.  In any
case, I re-checked, and it seems to me that the code that made iovec
arguments a requirement is no longer present.


Err, I don't see any iovec arguments in the 107_mount_update.diff
that google finds for me as [Glibc-bsd-commits] r3165.



I don't have time to look deeper right now though :-(


Until we are sure it's not a kfreebsd-9 bug, it's better to keep the bug
assigned to kfreebsd-9.


Since stock freebsd is documented as requiring -u (update) when changing 
the mount options of an already-mounted filesystem, it seems very likely 
to be a kfreebsd bug.


-Ben Kaduk



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#646957: mount -o remount,rw has no effect with kFreeBSD 9.0

2011-10-29 Thread Aurelien Jarno
On Sat, Oct 29, 2011 at 02:27:53PM -0400, Benjamin Kaduk wrote:
 On Sat, 29 Oct 2011, Robert Millan wrote:
 
 2011/10/29 Aurelien Jarno aurel...@aurel32.net:
 Which seems to be kfreebsd-9 related, not busybox related.
 
 This is very likely to be the same bug than the one fixed in kfreebsd-8
 by 107_mount_update.diff. This patch has been disabled in kfreebsd-9
 (probably because this part has been changed upstream), so this is where
 to look first.
 
 Uhm... ISTR it's me who removed that patch during the upgrade.  In any
 case, I re-checked, and it seems to me that the code that made iovec
 arguments a requirement is no longer present.
 
 Err, I don't see any iovec arguments in the 107_mount_update.diff
 that google finds for me as [Glibc-bsd-commits] r3165.

 
 I don't have time to look deeper right now though :-(
 
 Until we are sure it's not a kfreebsd-9 bug, it's better to keep the bug
 assigned to kfreebsd-9.
 
 Since stock freebsd is documented as requiring -u (update) when
 changing the mount options of an already-mounted filesystem, it
 seems very likely to be a kfreebsd bug.
 

Requiring -u is a requirement from the userland mount utility. Here we
are talking about the kernel interface. In this case the MNT_UPDATE flag
passed to the nmount() function is ignored if the filesystem was mounted
ro and the update is to mount it rw.

-- 
Aurelien Jarno  GPG: 1024D/F1BCDB73
aurel...@aurel32.net http://www.aurel32.net



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#646957: mount -o remount,rw has no effect with kFreeBSD 9.0

2011-10-28 Thread Robert Millan
Package: busybox
Version: 1:1.17.1-8
Severity: normal
Tags: d-i
User: debian-...@lists.debian.org
Usertags: kfreebsd

When running on kFreeBSD 9.0, mount -o remount,rw no longer remounts the
target file system in writable mode.

This will break D-I in the future when kfreebsd-kernel-di-* is upgraded to 9.x.

To reproduce:

$ sudo mdconfig -a -t malloc -s 32m
md0

$ sudo mkfs.ufs /dev/md0
/dev/md0: 32.0MB (65536 sectors) block size 16384, fragment size 2048
[...]

$ sudo busybox mount -o ro -t ufs /dev/md0 /mnt

$ mount | grep /mnt
/dev/md0 on /mnt (ufs, local, read-only)

$ sudo busybox mount -o remount,rw -t ufs /dev/md0 /mnt

$ mount | grep /mnt
/dev/md0 on /mnt (ufs, local, read-only)

-- System Information:
Debian Release: 6.0.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: kfreebsd-amd64 (x86_64)

Kernel: kFreeBSD 8.1-1-amd64
Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages busybox depends on:
ii  libc0.1   2.11.2-10  Embedded GNU C Library: Shared lib

busybox recommends no packages.

busybox suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#646957: mount -o remount,rw has no effect with kFreeBSD 9.0

2011-10-28 Thread Michael Tokarev
On 28.10.2011 21:56, Robert Millan wrote:
 Package: busybox
 Version: 1:1.17.1-8
 Severity: normal
 Tags: d-i
 User: debian-...@lists.debian.org
 Usertags: kfreebsd
 
 When running on kFreeBSD 9.0, mount -o remount,rw no longer remounts the
 target file system in writable mode.
 
 This will break D-I in the future when kfreebsd-kernel-di-* is upgraded to 
 9.x.

Can you please check with 1.19 busybox package?

Also, where one can get 9.0 kFreeBSD to reproduce?

Thanks,

/mjt



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#646957: mount -o remount,rw has no effect with kFreeBSD 9.0

2011-10-28 Thread Robert Millan
Hi Michael,

2011/10/28 Michael Tokarev m...@tls.msk.ru:
 Can you please check with 1.19 busybox package?

Unfortunately 1.19 is FTBFS [1].  I haven't got around to fixing that
yet, sorry! :-(

[1] 
https://buildd.debian.org/status/fetch.php?pkg=busyboxarch=kfreebsd-amd64ver=1%3A1.19.2-3stamp=1319822296

 Also, where one can get 9.0 kFreeBSD to reproduce?

It's available in experimental:

http://packages.debian.org/search?keywords=kfreebsd-image-9.0

-- 
Robert Millan



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#646957: mount -o remount,rw has no effect with kFreeBSD 9.0

2011-10-28 Thread Michael Tokarev
On 29.10.2011 00:05, Robert Millan wrote:
 Hi Michael,
 
 2011/10/28 Michael Tokarev m...@tls.msk.ru:
 Can you please check with 1.19 busybox package?
 
 Unfortunately 1.19 is FTBFS [1].  I haven't got around to fixing that
 yet, sorry! :-(
 
 [1] 
 https://buildd.debian.org/status/fetch.php?pkg=busyboxarch=kfreebsd-amd64ver=1%3A1.19.2-3stamp=1319822296

Sigh.  I especially uploaded a new version today in order to fix
FTBFS bug.  And I verified it builds on kfreebsd, -- I installed
it for this very case in a KVM virtual machine.

This one is simple, I'll take care of it, but I've no idea for
now how it built here.

 Also, where one can get 9.0 kFreeBSD to reproduce?
 
 It's available in experimental:
 
 http://packages.debian.org/search?keywords=kfreebsd-image-9.0

Ah ok, I'll take a look.

Thanks,

/mjt



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org