Bug#648492: apt-watch: Please add support for build-arch and build-indep targets plus enable hardening flags

2011-11-12 Thread Niels Thykier
Source: apt-watch
Severity: wishlist
Tags: patch
User: debian...@lists.debian.org
Usertags: build-arch-target

Hi,

Please see attached patch as an example of how to do this.

Please note that the buildds are still using build followed by
binary-arch.

For more information, please see [1].

~Niels

[1] https://wiki.debian.org/ReleaseGoals/BuildArchTarget
diff -Nru apt-watch-0.4.0/debian/changelog apt-watch-0.4.0/debian/changelog
--- apt-watch-0.4.0/debian/changelog	2011-10-18 04:40:59.0 +0200
+++ apt-watch-0.4.0/debian/changelog	2011-11-12 09:57:38.0 +0100
@@ -1,3 +1,13 @@
+apt-watch (0.4.0-2.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Added build-arch and build-indep targets to debian/rules.
+  * Use buildflags.mk from dpkg-dev to set default buildflags.
+- Enables hardening flags.
+  * Removed unused INSTALL_PROGRAM variable from debian/rules.
+
+ -- Niels Thykier ni...@thykier.net  Sat, 12 Nov 2011 09:54:01 +0100
+
 apt-watch (0.4.0-2) unstable; urgency=low
 
   * Bump debian release for unstable
diff -Nru apt-watch-0.4.0/debian/control apt-watch-0.4.0/debian/control
--- apt-watch-0.4.0/debian/control	2011-10-18 04:40:59.0 +0200
+++ apt-watch-0.4.0/debian/control	2011-11-12 09:55:45.0 +0100
@@ -2,7 +2,7 @@
 Section: admin
 Priority: optional
 Maintainer: John Lightsey light...@debian.org
-Build-Depends: debhelper (= 7.0.8), quilt (= 0.46-7~), libpam0g-dev | libpam-dev, libfam-dev, libpanel-applet-4-dev, libapt-pkg-dev
+Build-Depends: debhelper (= 7.0.8), quilt (= 0.46-7~), libpam0g-dev | libpam-dev, libfam-dev, libpanel-applet-4-dev, libapt-pkg-dev, dpkg-dev (= 1.16.1~)
 Standards-Version: 3.9.2.0
 Vcs-Git: http://nixnuts.net/git/apt-watch.git
 Homepage: http://nixnuts.net/apt-watch/
diff -Nru apt-watch-0.4.0/debian/rules apt-watch-0.4.0/debian/rules
--- apt-watch-0.4.0/debian/rules	2011-10-18 04:40:59.0 +0200
+++ apt-watch-0.4.0/debian/rules	2011-11-12 09:57:14.0 +0100
@@ -13,25 +13,19 @@
 DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
 
 
-CFLAGS = -Wall -g
-
-ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
-	CFLAGS += -O0
-else
-	CFLAGS += -O2
-endif
-ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
-	INSTALL_PROGRAM += -s
-endif
+DEB_CFLAGS_MAINT_APPEND = -Wall
+DPKG_EXPORT_BUILDFLAGS=1
+include /usr/share/dpkg/buildflags.mk
 
 config.status: configure
 	dh_quilt_patch
 	dh_testdir
-	CFLAGS=$(CFLAGS) ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --sysconfdir=/etc --libexecdir=\$${prefix}/lib/apt-watch --datadir=\$${prefix}/share
-
+	./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --sysconfdir=/etc --libexecdir=\$${prefix}/lib/apt-watch --datadir=\$${prefix}/share
 
-build: build-stamp
 
+build: build-arch build-indep
+build-arch: build-stamp
+build-indep: build-stamp
 build-stamp:  config.status
 	dh_testdir
 
@@ -102,4 +96,4 @@
 	dh_builddeb
 
 binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary install 
+.PHONY: build build-arch build-indep clean binary-indep binary-arch binary install 


Bug#648492: apt-watch: Please add support for build-arch and build-indep targets plus enable hardening flags

2011-11-12 Thread John Lightsey
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 11/12/2011 03:03 AM, Niels Thykier wrote:
 Please see attached patch as an example of how to do this.
 
 Please note that the buildds are still using build followed by
 binary-arch.
 
 For more information, please see [1].
 
 ~Niels
 
 [1] https://wiki.debian.org/ReleaseGoals/BuildArchTarget

Thanks for the patch.  I'll roll this into the next update to apt-watch.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOvq4pAAoJEORPgBbTYw+JP+MQAL5Qkz4J13BGTKVI65+aAuG4
FW4EbjAA1Ek23+46pLfER6ENBNuc2ks2j5s18aqTHR6Fmod4Iv5fEbBfA39Dw6ch
8mX0WQ55bWWRc1rdTTNBAQSjnhHUrQhIE+vhxOdLPhaOzLsGf9PSudmCGPZcELpi
kOUlVWRpFJfPnxYMGDFCchOQ203UgFhItp/5MY8Drp1judfbRrryRnj+OT3XmJkV
EHl41kGbfkpaHWMtrUv4uUI2LpiK7jVn/8Jk3VAHC75cEYQxvHEw3sowR79QWe/+
m5VpTl0TaQZK2TMSWF3bSeBOI7nLzkjDhhk/8G2+G+2aYuHtsNqbBtpMcMYKHyd1
Rpc/ghRfMrkxFSWabyBs9kWBBt1jCRmO5st4p64oLz94B2AQCSVhIYfsziaAmxIx
pQMl11Lai69+A0w77quGNktwc0o0Zoi52zPGCth45GXZn4rfkt0nvj4l0MMjIw8a
6Zz9unknWZoopJ9PeocPUQ4NQCmjqEIV7cXTB7GllyRwM9H8NI8UIZmxa0z/PJdA
lyL+bZpJsxfL6Koy8pajSHQle9Th333j7+ksMrRRFpQ3oP1Z6dVjTzsIUyyBfS2a
MAeTpPSWUg6gLwxmnounwd5jjAWWdVMtUeyx8qtoKuCRONNlBdTziNOlb+oOoh/j
/MhJRu46ya3ofU1JM/zP
=it16
-END PGP SIGNATURE-



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org