Bug#648891: munin-node: upgrade to perl 5.14 breaks munin-node
severity 648891 important merge 626346 648891 thanks Hi Gregor, On Samstag, 19. November 2011, gregor herrmann wrote: Yup, munin-node needs a restart, and indeed after a restart everything is fine again [0][1]. Now it would be nice if munin-node would do this itself. IIRC the perl package has some triggered for that purpose, which so far is at least used by spamassassin (which had the same problem in the past). right. And we already had a bug about this, with a pointer how to do it, so all the info is there (in #626346), it justs needs to be put together uploaded. thanks, Holger -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#648891: munin-node: upgrade to perl 5.14 breaks munin-node
On Sat, Nov 19, 2011 at 12:09:13AM +0100, gregor herrmann wrote: Hm, there's another glitch: 2011/11/18-23:55:07 [2076] Error output from iostat_ios: 2011/11/18-23:55:07 [2076] Byte order is not compatible at /usr/lib/perl/5.14/Storable.pm line 379, at /etc/munin/plugins/iostat_ios line 218 2011/11/18-23:55:07 [2076] Service 'iostat_ios' exited with status 25/0. ATM I don't remember how to fix his :/ I wasn't expecting these sorts of issues to be introduced going from 5.12 to 5.14. Can you confirm that this isn't left over from moving from 5.10 to 5.12? Our general recommendation is to use Storable::nstore rather than Storable::store; but I suspect this'll want a separate bug if so. Cheers, Dominic. -- Dominic Hargreaves | http://www.larted.org.uk/~dom/ PGP key 5178E2A5 from the.earth.li (keyserver,web,email) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#648891: munin-node: upgrade to perl 5.14 breaks munin-node
On Sat, 19 Nov 2011 12:58:07 +, Dominic Hargreaves wrote: 2011/11/18-23:55:07 [2076] Error output from iostat_ios: 2011/11/18-23:55:07 [2076] Byte order is not compatible at /usr/lib/perl/5.14/Storable.pm line 379, at /etc/munin/plugins/iostat_ios line 218 2011/11/18-23:55:07 [2076] Service 'iostat_ios' exited with status 25/0. I wasn't expecting these sorts of issues to be introduced going from 5.12 to 5.14. Can you confirm that this isn't left over from moving from 5.10 to 5.12? Oh, good catch, I have these messages all over the logs, just the path changed after the 5.12 → 5.14 upgrade: munin-node.log.1.gz:2011/11/18-15:30:09 [31257] Byte order is not compatible at ../../lib/Storable.pm (autosplit into ../../lib/auto/Storable/_retrieve.al) line 380, at /etc/munin/plugins/iostat_ios line 218 munin-node.log.1.gz:2011/11/18-23:25:07 [25891] Byte order is not compatible at /usr/lib/perl/5.14/Storable.pm line 379, at /etc/munin/plugins/iostat_ios line 218 Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key ID: 0x8649AA06 : :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe `-NP: Tom Waits: Circus signature.asc Description: Digital signature
Bug#648891: munin-node: upgrade to perl 5.14 breaks munin-node
clone 648891 -1 retitle -1 munin-node: leftovers from 5.10 to 5.12 thanks On Samstag, 19. November 2011, gregor herrmann wrote: I wasn't expecting these sorts of issues to be introduced going from 5.12 to 5.14. Can you confirm that this isn't left over from moving from 5.10 to 5.12? Oh, good catch, I have these messages all over the logs, just the path changed after the 5.12 → 5.14 upgrade: munin-node.log.1.gz:2011/11/18-15:30:09 [31257] Byte order is not compatible at ../../lib/Storable.pm (autosplit into ../../lib/auto/Storable/_retrieve.al) line 380, at /etc/munin/plugins/iostat_ios line 218 munin-node.log.1.gz:2011/11/18-23:25:07 [25891] Byte order is not compatible at /usr/lib/perl/5.14/Storable.pm line 379, at /etc/munin/plugins/iostat_ios line 218 thanks for this amalysis! cheers, Holger -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#648891: munin-node: upgrade to perl 5.14 breaks munin-node
clone 648891 -1
retitle -1 munin-node: perl 5.14 deprecation warnings
severity -1 minor
tag -1 + patch
thanks
On Sat, 19 Nov 2011 00:09:13 +0100, gregor herrmann wrote:
Well, almost, there are some deprecation warnings:
2011/11/18-23:50:04 [1039] Error output from apache_processes:
2011/11/18-23:50:04 [1039] Use of qw(...) as parentheses is deprecated
at /etc/munin/plugins/apache_processes line 164.
and the same from several other modules.
--
http://search.cpan.org/~jesse/perl-5.14.0/pod/perldelta.pod#Use_of_qw%28...%29_as_parentheses
for $x qw(a b c) { ... }
--
for $x (qw(a b c)) { ... }
I took a quick look at the source package and added the missing
parentheses where I found them -- attachment.
(apache_processes and memory are even tested :))
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key ID: 0x8649AA06
: :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/
`. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe
`-NP: Van Morrison
diff --git a/plugins/node.d.linux/memory.in b/plugins/node.d.linux/memory.in
index ec3ea23..d4ec907 100755
--- a/plugins/node.d.linux/memory.in
+++ b/plugins/node.d.linux/memory.in
@@ -186,7 +186,7 @@ if ($ARGV[0] and $ARGV[0] eq config) {
print inact_clean.draw LINE1\n;
print inact_clean.info Memory not currently used.\n;
}
-for my $field qw(apps buffers swap cached free slab swap_cache page_tables vmalloc_used committed mapped active active_anon active_cache inactive inact_dirty inact_laundry inact_clean) {
+for my $field (qw(apps buffers swap cached free slab swap_cache page_tables vmalloc_used committed mapped active active_anon active_cache inactive inact_dirty inact_laundry inact_clean)) {
my ($warning, $critical) = get_thresholds($field);
my $total = $mems{MemTotal};
$total = $mems{SwapTotal} if($field eq swap);
diff --git a/plugins/node.d/apache_processes.in b/plugins/node.d/apache_processes.in
index abe393a..939d875 100755
--- a/plugins/node.d/apache_processes.in
+++ b/plugins/node.d/apache_processes.in
@@ -161,7 +161,7 @@ if ( defined $ARGV[0] and $ARGV[0] eq config )
print free$port.colour ccff00\n;
}
foreach my $port (@PORTS) {
- foreach my $type qw busy idle {
+ foreach my $type (qw(busy idle)) {
print_thresholds($type$port);
}
}
diff --git a/plugins/node.d/users.in b/plugins/node.d/users.in
index 076f80f..f6b5fdd 100644
--- a/plugins/node.d/users.in
+++ b/plugins/node.d/users.in
@@ -79,7 +79,7 @@ if ( defined($ARGV[0])) {
print other.label Other users\n;
print other.info Users loged in by indeterminate method\n;
print other.colour FF\n;
- foreach my $field qw(tty pty pts X other) {
+ foreach my $field (qw(tty pty pts X other)) {
print_thresholds($field);
}
exit 0;
signature.asc
Description: Digital signature
Bug#648891: munin-node: upgrade to perl 5.14 breaks munin-node
On Wed, 16 Nov 2011 09:12:13 +1100, Philipp Huebner wrote:
I just upgraded my unstable system which brought perl 5.14 with it, when munin
stopped working, saying there are n nodes with any plugins.
Checking the log of munin-node revealed this:
2011/11/16-09:05:02 [5995] 2011/11/16-09:05:02 [6069] Can't locate
auto/POSIX/getpwuid.al in @INC (@INC contains: /etc/perl
/usr/local/lib/perl/5.12.4 /usr/local/share/perl/5.12.4 /usr/lib/perl5
/usr/share/perl5 /usr/lib/perl/5.12 /usr/share/perl/5.12
/usr/local/lib/site_perl) at /usr/share/perl5/Munin/Node/OS.pm line 32\n
...propagated at /usr/share/perl5/Munin/Common/Timeout.pm line 66, STDIN
line 76.
It is clearly visible that munin-node tries to use perl 5.12 which is not
installed anymore.
Yup, munin-node needs a restart, and indeed after a restart
everything is fine again [0][1].
Now it would be nice if munin-node would do this itself.
IIRC the perl package has some triggered for that purpose, which so
far is at least used by spamassassin (which had the same problem in
the past).
Ah, here we are (perl changelog):
5.12.3-2:
* Activate the 'perl-major-upgrade' trigger on major version upgrades
to notify other packages that might need to be restarted, or take some
other action (Closes: #230308)
(The bug report also contains an example.)
HTH,
gregor, CC'ing the perl maintainers who might be able to help with the
trigger and the Storable issue from [1]
[0]
Well, almost, there are some deprecation warnings:
2011/11/18-23:50:04 [1039] Error output from apache_processes:
2011/11/18-23:50:04 [1039] Use of qw(...) as parentheses is deprecated at
/etc/munin/plugins/apache_processes line 164.
and the same from several other modules.
--
http://search.cpan.org/~jesse/perl-5.14.0/pod/perldelta.pod#Use_of_qw%28...%29_as_parentheses
for $x qw(a b c) { ... }
--
for $x (qw(a b c)) { ... }
[1]
Hm, there's another glitch:
2011/11/18-23:55:07 [2076] Error output from iostat_ios:
2011/11/18-23:55:07 [2076] Byte order is not compatible at
/usr/lib/perl/5.14/Storable.pm line 379, at /etc/munin/plugins/iostat_ios line
218
2011/11/18-23:55:07 [2076] Service 'iostat_ios' exited with status 25/0.
ATM I don't remember how to fix his :/
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key ID: 0x8649AA06
: :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/
`. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe
`-NP: Bettina Wegner: Erew Schel Schoschanim
signature.asc
Description: Digital signature
Bug#648891: munin-node: upgrade to perl 5.14 breaks munin-node
Package: munin-node Version: 1.4.6-1 Severity: grave Justification: renders package unusable I just upgraded my unstable system which brought perl 5.14 with it, when munin stopped working, saying there are n nodes with any plugins. Checking the log of munin-node revealed this: 2011/11/16-09:05:02 [5995] 2011/11/16-09:05:02 [6069] Can't locate auto/POSIX/getpwuid.al in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.12.4 /usr/local/share/perl/5.12.4 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.12 /usr/share/perl/5.12 /usr/local/lib/site_perl) at /usr/share/perl5/Munin/Node/OS.pm line 32\n ...propagated at /usr/share/perl5/Munin/Common/Timeout.pm line 66, STDIN line 76. It is clearly visible that munin-node tries to use perl 5.12 which is not installed anymore. Regards, Philipp -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.0.0-2-amd64 (SMP w/2 CPU cores) Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages munin-node depends on: ii adduser 3.113 ii gawk1:3.1.8+dfsg-0.1 ii libnet-server-perl 0.99-3 ii lsb-base3.2-28 ii munin-common1.4.6-1 ii perl5.14.2-3 ii procps 1:3.2.8-11 Versions of packages munin-node recommends: ii libnet-snmp-perl 6.0.1-2 Versions of packages munin-node suggests: ii acpi 1.5-3 ii ethtool 1:3.0-1 ii hdparmnone ii libcache-cache-perl none ii libcrypt-ssleay-perl none ii libdbd-mysql-perl none ii libdbd-pg-perlnone ii liblwp-useragent-determined-perl none ii libnet-irc-perl none ii libnet-ssleay-perl1.42-1+b1 ii libtext-csv-xs-perl none ii libwww-perl 6.03-1 ii libxml-simple-perlnone ii lm-sensors1:3.3.1-1 ii logtail none ii munin 1.4.6-1 ii munin-java-plugins1.4.6-1 ii munin-plugins-extra 1.4.6-1 ii mysql-client none ii net-tools 1.60-24.1 ii python2.7.2-9 ii ruby 4.8 ii ruby1.8 [ruby]1.8.7.352-2 ii smartmontools 5.41+svn3365-1 -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
