Bug#654909: Please enabled hardened build flags

2012-01-08 Thread Moritz Mühlenhoff
On Sat, Jan 07, 2012 at 06:18:03PM +0100, Tollef Fog Heen wrote:
 
 severity 654909 wishlist
 thanks
 
 (This looks like a wishlist bug, not an important one.)

Hardened build flags are a release goal, but I don't care about
the severity.
 
  Please enabled hardened build flags through dpkg-buildflags.
 
 Have you tested that this works correctly with all the included
 utilities on at least the mainstream architectures?

Only on amd64. OTOH several hundred packages have been converted
in unstable, i.e. if there were structural toolchain problems
on the fringe archs, we would most likely have heard about it
by now.

Cheers,
Moritz



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#654909: Please enabled hardened build flags

2012-01-07 Thread Tollef Fog Heen

severity 654909 wishlist
thanks

(This looks like a wishlist bug, not an important one.)

]] Moritz Muehlenhoff 

 Please enabled hardened build flags through dpkg-buildflags.

Have you tested that this works correctly with all the included
utilities on at least the mainstream architectures?

Thanks,
-- 
Tollef Fog Heen
UNIX is user friendly, it's just picky about who its friends are



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#654909: Please enabled hardened build flags

2012-01-06 Thread Moritz Muehlenhoff
Package: sash
Version: 3.7-10
Severity: important
Tags: patch

Please enabled hardened build flags through dpkg-buildflags.

Patch attached.

Cheers,
Moritz
diff -aur sash-3.7.orig/Makefile sash-3.7/Makefile
--- sash-3.7.orig/Makefile	2012-01-02 04:34:43.0 +0100
+++ sash-3.7/Makefile	2012-01-06 19:59:40.0 +0100
@@ -25,9 +25,13 @@
 	-DHAVE_LINUX_MOUNT=$(HAVE_LINUX_MOUNT) \
 	-DHAVE_BSD_MOUNT=$(HAVE_BSD_MOUNT) \
 	-DMOUNT_TYPE=$(MOUNT_TYPE)
-CFLAGS = -O3 -Wall -Wmissing-prototypes -g $(DEFS)
 
-LDFLAGS = -static -s
+CFLAGS = `dpkg-buildflags --get CFLAGS`
+CFLAGS += -O3 -Wall -Wmissing-prototypes -g $(DEFS)
+LDFLAGS = `dpkg-buildflags --get LDFLAGS`
+LDFLAGS += -static -s
+CFLAGS += `dpkg-buildflags --get CPPFLAGS`
+
 LIBS = -lz
 
 
Nur in sash-3.7: Makefile~.