Bug#658915: upgrade-db prematurely deletes $CONFIG_DIR/db

2012-02-06 Thread Andres Freund
Package: cyrus-common
Version: 2.4.13-1

While upgrading a cyrus environment from 2.2 (manually upgraded package built 
ages ago) I found upgrade-db failing in the midst of the upgrade. Looking at 
the script the issue seems to be that it removes $CONFIG_DIR/db when finding 
any non-bdb backed database which then will cause it failing for further bdb 
databases. Removing the deletion of that dir fixes the issue for me.

The solution seems to be to move the removal of the directory outside the loop 
in upgradealldb which iterates over the individual databases. Am I missing 
something?

Andres

PS: I hit this issue in a backported (to squeeze) version but I doubt that 
actually changes anything...



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#658915: upgrade-db prematurely deletes $CONFIG_DIR/db

2012-02-06 Thread Ondřej Surý
Hi Andres,

thanks for the bug report.  Can you please send a patch, so I can see
what you are
actually talking about?

Ondrej.

On Mon, Feb 6, 2012 at 20:06, Andres Freund and...@anarazel.de wrote:
 Package: cyrus-common
 Version: 2.4.13-1

 While upgrading a cyrus environment from 2.2 (manually upgraded package built
 ages ago) I found upgrade-db failing in the midst of the upgrade. Looking at
 the script the issue seems to be that it removes $CONFIG_DIR/db when finding
 any non-bdb backed database which then will cause it failing for further bdb
 databases. Removing the deletion of that dir fixes the issue for me.

 The solution seems to be to move the removal of the directory outside the loop
 in upgradealldb which iterates over the individual databases. Am I missing
 something?

 Andres

 PS: I hit this issue in a backported (to squeeze) version but I doubt that
 actually changes anything...



 ___
 Pkg-Cyrus-imapd-Debian-devel mailing list
 pkg-cyrus-imapd-debian-de...@lists.alioth.debian.org
 http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-cyrus-imapd-debian-devel



-- 
Ondřej Surý ond...@sury.org



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#658915: upgrade-db prematurely deletes $CONFIG_DIR/db

2012-02-06 Thread Andres Freund
Hi Ondrey,

On Monday, February 06, 2012 08:24:13 PM Ondřej Surý wrote:
 thanks for the bug report.  Can you please send a patch, so I can see
 what you are
 actually talking about?
My patch currently is total crap, thats why I didn't send it so far ;)

Its attached now.

Andres
--- /tmp/cyrus-upgrade-db	2012-02-06 20:48:30.334634974 +0100
+++ /tmp/upgrade-db	2012-02-06 20:50:28.809453691 +0100
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 # Cyrus database backends upgrade script
 # (C) 2001 Ondřej Surý ond...@sury.org
 # distributed under the same licence as Cyrus IMAPd
@@ -187,7 +187,7 @@
 		checkpointbdb $NEW_DBVERSION
 	else
 		# Remove empty environment
-		rm -rf $CONFIG_DIR/db
+		echo not doing rm -rf $CONFIG_DIR/db because we need it for a later db
 	fi
 	fi
 done


Bug#658915: upgrade-db prematurely deletes $CONFIG_DIR/db

2012-02-06 Thread Ondřej Surý
Thanks, you're right, the whole block should be outside while cycle.

Will upload it right away.

O.

On Mon, Feb 6, 2012 at 20:51, Andres Freund and...@anarazel.de wrote:
 Hi Ondrey,

 On Monday, February 06, 2012 08:24:13 PM Ondřej Surý wrote:
 thanks for the bug report.  Can you please send a patch, so I can see
 what you are
 actually talking about?
 My patch currently is total crap, thats why I didn't send it so far ;)

 Its attached now.

 Andres

 ___
 Pkg-Cyrus-imapd-Debian-devel mailing list
 pkg-cyrus-imapd-debian-de...@lists.alioth.debian.org
 http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-cyrus-imapd-debian-devel



-- 
Ondřej Surý ond...@sury.org



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org