Package: ttf-goudybookletter
Version: 2010.07.03-1
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise
Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before
ttf-goudybookletter. This seems generally undesirable; it would be
better to enforce a single code path. (This is academic for Debian
because the version of dpkg in squeeze supported
dpkg-maintscript-helper, hence Severity: wishlist; Ubuntu's last LTS
release didn't have a sufficient version of dpkg for that which is why I
care.)
It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0. This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all. Here's a patch:
* Use maintscript support in dh_installdeb rather than writing out
dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a
new enough version of dpkg rather than using 'dpkg-maintscript-helper
supports' guards, leading to more predictable behaviour on upgrades.
diff -Nru ttf-goudybookletter-2010.07.03/debian/control
ttf-goudybookletter-2010.07.03/debian/control
--- ttf-goudybookletter-2010.07.03/debian/control 2011-07-20
16:32:21.000000000 +0100
+++ ttf-goudybookletter-2010.07.03/debian/control 2012-02-13
12:38:40.000000000 +0000
@@ -3,7 +3,7 @@
Priority: optional
Maintainer: Gürkan Sengün <gur...@phys.ethz.ch>
Uploaders: Debian Fonts Task Force <pkg-fonts-de...@lists.alioth.debian.org>
-Build-Depends: debhelper (>= 7.0.50~),
+Build-Depends: debhelper (>= 8.1.0~),
dh-autoreconf,
fontforge-nox | fontforge,
python (>= 2.6),
@@ -13,6 +14,7 @@
Package: ttf-goudybookletter
Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}
Description: Old style roman font
Based on the roman of Frederic Goudy's Kennerley Old Style (designed and cut
diff -Nru ttf-goudybookletter-2010.07.03/debian/maintscript
ttf-goudybookletter-2010.07.03/debian/maintscript
--- ttf-goudybookletter-2010.07.03/debian/maintscript 1970-01-01
01:00:00.000000000 +0100
+++ ttf-goudybookletter-2010.07.03/debian/maintscript 2012-02-13
12:38:08.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-goudybookletter.hints 0.1-3
diff -Nru ttf-goudybookletter-2010.07.03/debian/postinst
ttf-goudybookletter-2010.07.03/debian/postinst
--- ttf-goudybookletter-2010.07.03/debian/postinst 2011-07-20
14:02:29.000000000 +0100
+++ ttf-goudybookletter-2010.07.03/debian/postinst 1970-01-01
01:00:00.000000000 +0100
@@ -1,8 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
- dpkg-maintscript-helper rm_conffile
/etc/defoma/hints/ttf-goudybookletter.hints 0.1-3 -- "$@"
-fi
-
-#DEBHELPER#
diff -Nru ttf-goudybookletter-2010.07.03/debian/postrm
ttf-goudybookletter-2010.07.03/debian/postrm
--- ttf-goudybookletter-2010.07.03/debian/postrm 2011-07-20
14:02:32.000000000 +0100
+++ ttf-goudybookletter-2010.07.03/debian/postrm 1970-01-01
01:00:00.000000000 +0100
@@ -1,8 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
- dpkg-maintscript-helper rm_conffile
/etc/defoma/hints/ttf-goudybookletter.hints 0.1-3 -- "$@"
-fi
-
-#DEBHELPER#
diff -Nru ttf-goudybookletter-2010.07.03/debian/preinst
ttf-goudybookletter-2010.07.03/debian/preinst
--- ttf-goudybookletter-2010.07.03/debian/preinst 2011-07-20
14:02:37.000000000 +0100
+++ ttf-goudybookletter-2010.07.03/debian/preinst 1970-01-01
01:00:00.000000000 +0100
@@ -1,8 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
- dpkg-maintscript-helper rm_conffile
/etc/defoma/hints/ttf-goudybookletter.hints 0.1-3 -- "$@"
-fi
-
-#DEBHELPER#
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
