Package: ttf-isabella
Version: 1.2-2
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise
Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before
ttf-isabella. This seems generally undesirable; it would be better to
enforce a single code path. (This is academic for Debian because the
version of dpkg in squeeze supported dpkg-maintscript-helper, hence
Severity: wishlist; Ubuntu's last LTS release didn't have a sufficient
version of dpkg for that which is why I care.)
It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0. This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all. Here's a patch:
* Use maintscript support in dh_installdeb rather than writing out
dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a
new enough version of dpkg rather than using 'dpkg-maintscript-helper
supports' guards, leading to more predictable behaviour on upgrades.
diff -Nru ttf-isabella-1.2/debian/control ttf-isabella-1.2/debian/control
--- ttf-isabella-1.2/debian/control 2011-07-24 02:04:21.000000000 +0100
+++ ttf-isabella-1.2/debian/control 2012-02-13 12:42:32.000000000 +0000
@@ -2,12 +2,13 @@
Section: fonts
Priority: optional
Maintainer: Edgar Antonio Palma de la Cruz <xbyt...@gmail.com>
-Build-Depends: debhelper (>= 8.0.0), fontforge, fontconfig
+Build-Depends: debhelper (>= 8.1.0~), fontforge, fontconfig
Standards-Version: 3.9.2
Homepage: http://www.thibault.org/fonts/isabella/
Package: ttf-isabella
Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}, fontconfig
Description: Isabella free TrueType font
This font is called Isabella because it is based on the calligraphic
diff -Nru ttf-isabella-1.2/debian/maintscript
ttf-isabella-1.2/debian/maintscript
--- ttf-isabella-1.2/debian/maintscript 1970-01-01 01:00:00.000000000 +0100
+++ ttf-isabella-1.2/debian/maintscript 2012-02-13 12:41:52.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-isabella.hints 1.2-2
diff -Nru ttf-isabella-1.2/debian/postinst ttf-isabella-1.2/debian/postinst
--- ttf-isabella-1.2/debian/postinst 2011-07-24 01:39:07.000000000 +0100
+++ ttf-isabella-1.2/debian/postinst 1970-01-01 01:00:00.000000000 +0100
@@ -1,7 +0,0 @@
-#!/bin/sh
-set -e
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
- dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-isabella.hints
1.2-2 -- "$@"
-fi
-
-#DEBHELPER#
diff -Nru ttf-isabella-1.2/debian/postrm ttf-isabella-1.2/debian/postrm
--- ttf-isabella-1.2/debian/postrm 2011-07-24 01:39:42.000000000 +0100
+++ ttf-isabella-1.2/debian/postrm 1970-01-01 01:00:00.000000000 +0100
@@ -1,7 +0,0 @@
-#!/bin/sh
-set -e
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
- dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-isabella.hints
1.2-2 -- "$@"
-fi
-
-#DEBHELPER#
diff -Nru ttf-isabella-1.2/debian/preinst ttf-isabella-1.2/debian/preinst
--- ttf-isabella-1.2/debian/preinst 2011-07-24 01:39:51.000000000 +0100
+++ ttf-isabella-1.2/debian/preinst 1970-01-01 01:00:00.000000000 +0100
@@ -1,7 +0,0 @@
-#!/bin/sh
-set -e
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
- dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-isabella.hints
1.2-2 -- "$@"
-fi
-
-#DEBHELPER#
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
