Package: ttf-sjfonts Version: 2.0.2-1.1 Severity: wishlist Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu ubuntu-patch precise
Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces unreliability into upgrades; it means that the conffile is removed or not depending on whether dpkg happens to be unpacked before ttf-sjfonts. This seems generally undesirable; it would be better to enforce a single code path. (This is academic for Debian because the version of dpkg in squeeze supported dpkg-maintscript-helper, hence Severity: wishlist; Ubuntu's last LTS release didn't have a sufficient version of dpkg for that which is why I care.) It would be nice to just use dh_installdeb's support for generating dpkg-maintscript-helper commands, which was introduced in debhelper 8.1.0. This would remove duplicate code from your maintainer scripts - in fact, you could remove two of your handwritten maintainer scripts entirely. Here's a patch: * Use maintscript support in dh_installdeb rather than writing out dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a new enough version of dpkg rather than using 'dpkg-maintscript-helper supports' guards, leading to more predictable behaviour on upgrades. diff -Nru sjfonts-2.0.2/debian/control sjfonts-2.0.2/debian/control --- sjfonts-2.0.2/debian/control 2011-12-10 13:08:11.000000000 +0000 +++ sjfonts-2.0.2/debian/control 2012-02-13 13:21:59.000000000 +0000 @@ -2,11 +2,12 @@ Section: fonts Priority: optional Maintainer: Daniel Schepler <schep...@debian.org> -Build-Depends-Indep: debhelper (>= 8), fontforge-nox|fontforge +Build-Depends-Indep: debhelper (>= 8.1.0~), fontforge-nox|fontforge Standards-Version: 3.9.2 Package: ttf-sjfonts Architecture: all +Pre-Depends: ${misc:Pre-Depends} Depends: ${misc:Depends} Description: Some Juicy Fonts handwriting fonts This package contains two handwriting fonts created by Steve Jordi, diff -Nru sjfonts-2.0.2/debian/maintscript sjfonts-2.0.2/debian/maintscript --- sjfonts-2.0.2/debian/maintscript 1970-01-01 01:00:00.000000000 +0100 +++ sjfonts-2.0.2/debian/maintscript 2012-02-13 13:21:00.000000000 +0000 @@ -0,0 +1 @@ +rm_conffile /etc/defoma/hints/ttf-sjfonts.hints 2.0.2-2 diff -Nru sjfonts-2.0.2/debian/postinst sjfonts-2.0.2/debian/postinst --- sjfonts-2.0.2/debian/postinst 2011-12-10 12:59:25.000000000 +0000 +++ sjfonts-2.0.2/debian/postinst 1970-01-01 01:00:00.000000000 +0100 @@ -1,9 +0,0 @@ -#!/bin/sh - -set -e - -if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then - dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-sjfonts.hints 2.0.2-2 -- "$@" -fi - -#DEBHELPER# diff -Nru sjfonts-2.0.2/debian/postrm sjfonts-2.0.2/debian/postrm --- sjfonts-2.0.2/debian/postrm 2011-12-10 12:59:25.000000000 +0000 +++ sjfonts-2.0.2/debian/postrm 1970-01-01 01:00:00.000000000 +0100 @@ -1,9 +0,0 @@ -#!/bin/sh - -set -e - -if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then - dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-sjfonts.hints 2.0.2-2 -- "$@" -fi - -#DEBHELPER# diff -Nru sjfonts-2.0.2/debian/preinst sjfonts-2.0.2/debian/preinst --- sjfonts-2.0.2/debian/preinst 2011-12-10 12:59:24.000000000 +0000 +++ sjfonts-2.0.2/debian/preinst 2012-02-13 13:21:11.000000000 +0000 @@ -9,8 +9,4 @@ fi -if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then - dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-sjfonts.hints 2.0.2-2 -- "$@" -fi - #DEBHELPER# Thanks, -- Colin Watson [cjwat...@ubuntu.com] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org