Bug#662225: libconfig: dpkg-buildflags (including hardening) flags not used

2012-03-25 Thread Jonathan McCrohan 
Hi Simon,

On 24/03/12 14:20, Simon Ruderich wrote:
 I'm sorry but I overlooked that the package contains C++ files,
 thus CXXFLAGS must be exported as well to enable (hardening)
 flags for them.

Thanks for the patch. I have incorporated this into my repo, and I hope
to upload a new package soon.

Jon



signature.asc
Description: OpenPGP digital signature

Bug#662225: libconfig: dpkg-buildflags (including hardening) flags not used

2012-03-24 Thread Simon Ruderich 
reopen 662225
thanks

Dear Maintainer,

I'm sorry but I overlooked that the package contains C++ files,
thus CXXFLAGS must be exported as well to enable (hardening)
flags for them.

The following patch fixes that.

diff -Nru libconfig-1.4.8/debian/rules libconfig-1.4.8/debian/rules
--- libconfig-1.4.8/debian/rules2012-03-05 22:57:43.0 +0100
+++ libconfig-1.4.8/debian/rules2012-03-24 15:09:59.0 +0100
@@ -7,10 +7,12 @@
 
 CFLAGS = $(shell dpkg-buildflags --get CFLAGS)
 CFLAGS += -Wall -g
+CXXFLAGS = $(shell dpkg-buildflags --get CXXFLAGS)
+CXXFLAGS += -Wall -g
 LDFLAGS = $(shell dpkg-buildflags --get LDFLAGS)
 LDFLAGS += -Wl,-z,defs
 CPPFLAGS = $(shell dpkg-buildflags --get CPPFLAGS)
-export CFLAGS CPPFLAGS LDFLAGS
+export CFLAGS CXXFLAGS CPPFLAGS LDFLAGS
 
 # shared library versions, option 1
 version=9

Regards,
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9


signature.asc
Description: Digital signature

Bug#662225: libconfig: dpkg-buildflags (including hardening) flags not used

2012-03-04 Thread Simon Ruderich 
Package: libconfig
Severity: important
Tags: patch

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Dear Maintainer,

dpkg-buildflags is not correctly used in the current
debian/rules.

To call dpkg-buildflags $(shell ...) or `...` must be used, and
the *FLAGS must be exported. The following patch fixes that, it
also fixes LDFLAGS (defs alone doesn't work).

diff -Nru libconfig-1.4.8/debian/rules libconfig-1.4.8/debian/rules
--- libconfig-1.4.8/debian/rules2012-02-26 21:46:56.0 +0100
+++ libconfig-1.4.8/debian/rules2012-03-04 20:34:22.0 +0100
@@ -5,11 +5,12 @@
 DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
 
-CFLAGS = $(dpkg-buildflags --get CFLAGS)
-CFLAGS += -Wall -g
-LDFLAGS = $(dpkg-buildflags --get LDFLAGS)
-LDFLAGS += defs
-CPPFLAGS = $(dpkg-buildflags --get CPPFLAGS)
+CFLAGS = $(shell dpkg-buildflags --get CFLAGS)
+CFLAGS += -Wall -g
+LDFLAGS = $(shell dpkg-buildflags --get LDFLAGS)
+LDFLAGS += -Wl,-z,defs
+CPPFLAGS = $(shell dpkg-buildflags --get CPPFLAGS)
+export CFLAGS CPPFLAGS LDFLAGS
 
 # shared library versions, option 1
 version=9

Due to this change hardening flags get automatically enabled.

Regards,
Simon

- -- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPU8YMAAoJEJL+/bfkTDL56NMQAIx0a0mPARClhQFi3Ubce8Dt
DEMzP3nyfBHl4oo6OckhofNCxFQtA1m3RXvxolSLQBmM388uL4pQqCRsrZxcR5a5
9VCJRt+ZiZKoZ9YDScFPBFyBnU3uZxoc8HdpJi4qlIOkm3LFx6q8cNosqyH7ntgy
JKCRrEYtcq2xlQAa5C1Edj+CZkPoJwsgBtxiOo/KW/v1+Hfc6oWeL+gQKAlb36xB
ps+SEdnJSl3Mrr7BVVf22R2qOrT/UtNCBer7V+pwsdhnjr1+LwFAxGA5OVhIHNBM
DeNBDADCUHVKLN0KVgWGx+NvfTZ7bRKb1eBQlN2vjfeLtkGmMa3ba8nPsMlz2Wxf
CiVY4avOVT+9YMhZdWCnIHOEwaog/QEOIcHvbkrAmJEJvYRqb1571qtsgiCukvEO
MZRV9trkkaVCDkchCFtrNPDO0Pt0MmjEsGJkIY1mDYhtpVaZ/NYCBIlY8roBH/OM
isK0piL0dArASk6jS8ATeCZw40wYG8WP3Htdd828m3rRhS9O0DJU7/DPJhOLaK+9
UKciKLMPpPMQjdc5D0YZ4L2faaWUlGFqzGAyIBq2Ry5YfPoOU8C3xoV2JuqjX4Rk
2MQ3TNyIsa5XnvWo/nbFmZ+Pz6WhBAvoVTge13Guw7Gai7V4n7ZA+trfbgJoIR7C
YnzTHxMdlnGEEByu80/T
=Mmm4
-END PGP SIGNATURE-



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org