Bug#670152: Uptime display wrong if more than 99 days
Rodolfo García Peñas wrote, On 2013-12-06 22:40: Hi Pedro, about this bug, I think is related to wmcpu, not wmmon. wmmon doesn't handle this time space, only some minutes. If you agree, I will close this bug. Hi Rodolfo, You're right in that it should be forwarded to wmcpu, as I explained in bug #670151. My apologies. As a side note, wmmon handles 4 digits of days for uptime actually, which is long enough to never see an overflow (because in 1 days you're likely to have needed to upgrade your system anyway). Thanks for looking into this, and sorry for my absent-mindedness. Pedro Gimeno -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#670152: Uptime display wrong if more than 99 days
Hi Pedro, about this bug, I think is related to wmcpu, not wmmon. wmmon doesn't handle this time space, only some minutes. If you agree, I will close this bug. Cheers, kix -- .''`. Rodolfo García Peñas (kix) k...@debian.org : :' : Proud Debian Developer `. `'` 4096R / 3F48 0B8C C385 AD41 9E28 006A 7B1F 5490 72B7 4923 `- Debian - when you have better things to do than fixing systems -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#670152: Uptime display wrong if more than 99 days
I sent this bug+patch to upstream today. A new wmmon version (upstream) will be released soon. Then I will upload the new package. Thanks a lot for your bug report and for your patch. kix -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#670152: Uptime display wrong if more than 99 days
Package: wmmon Version: 1.4-4 Severity: minor Tags: patch When the uptime is greater than 99 days, the uptime display is shown wrong (it shows blank digits instead of actual digits). The attached patch fixes it and may help clarify the issue if it's not clear enough from the description. It also copes with the case of uptime greater than 999 days, by displaying only the last three digits (as there's no more room). diff -ru wmcpu-1.4-orig/wmcpu.c wmcpu-1.4/wmcpu.c --- wmcpu-1.4-orig/wmcpu.c 2005-12-24 00:41:14.0 +0100 +++ wmcpu-1.4/wmcpu.c 2012-04-23 14:30:32.0 +0200 @@ -313,9 +313,9 @@ copy_xpm_area(63, 66, 3, 9, 25, 48); tempy = days % 10; copy_xpm_area(3 + (tempy * 6), 66, 6, 9, 18, 48); - tempy = days / 10; + tempy = (days / 10) % 10; copy_xpm_area(3 + (tempy * 6), 66, 6, 9, 12, 48); - tempy = days / 100; + tempy = (days / 100) % 10; copy_xpm_area(3 + (tempy * 6), 66, 6, 9, 6, 48); } }
