Bug#671847: #3879: mutt: encoded-words are not decoded in mailto:

2016-10-01 Thread Mutt
#3879: mutt: encoded-words are not decoded in mailto:
+--
  Reporter:  antonio@…  |  Owner:  mutt-dev
  Type:  defect | Status:  closed
  Priority:  major  |  Milestone:
 Component:  charset|Version:  1.7.0
Resolution:  fixed  |   Keywords:
+--
Changes (by Kevin McCarthy ):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e0c0a2820b8b50c1e622181d4a6bbe7c1850a8ed"
 6803:e0c0a2820b8b]:
 {{{
 #!CommitTicketReference repository=""
 revision="e0c0a2820b8b50c1e622181d4a6bbe7c1850a8ed"
 RFC2047-decode mailto url headers after RFC2822 parsing. (closes #3879)

 Commit 55819a7e6169 performed the RFC2047 decode before the parsing.
 This works okay for headers such as subject, but for others such as
 address fields could lead to parsing errors.

 Change to perform a decode on envelope headers after all the calls to
 mutt_parse_rfc822_line(), using the same list of fields as
 mutt_read_rfc822_header().

 Change the do_2047 parameter of mutt_read_rfc822_line() to true, so
 that user headers are decoded if needed.
 }}}

--
Ticket URL: 
Mutt 
The Mutt mail user agent



Bug#671847: #3879: mutt: encoded-words are not decoded in mailto:

2016-09-28 Thread Mutt
#3879: mutt: encoded-words are not decoded in mailto:
+--
  Reporter:  antonio@…  |  Owner:  mutt-dev
  Type:  defect | Status:  reopened
  Priority:  major  |  Milestone:
 Component:  charset|Version:  1.7.0
Resolution: |   Keywords:
+--
Changes (by kevin8t8):

 * Attachment "ticket-3879-v2.patch" added.


--
Ticket URL: 
Mutt 
The Mutt mail user agent



Bug#671847: #3879: mutt: encoded-words are not decoded in mailto:

2016-09-28 Thread Mutt
#3879: mutt: encoded-words are not decoded in mailto:
+--
  Reporter:  antonio@…  |  Owner:  mutt-dev
  Type:  defect | Status:  reopened
  Priority:  major  |  Milestone:
 Component:  charset|Version:  1.7.0
Resolution: |   Keywords:
+--

Comment (by kevin8t8):

 I'm attaching a patch that takes the same approach as
 mutt_read_rfc822_header().

 It changes the do_2047 parameter of mutt_parse_rfc822_line() to true (for
 user headers).  Then it
 calls rfc2047_decode on all the other standard encoded header fields below
 (after the tokenizing and rfc822 parsing).

 I considered trying to keep track of which headers are in the mailto url,
 but given that the rfc2047_decode functions abort quickly if the header
 NULL, it seemed more likely to cause bugs than benefit.  The copy/paste of
 fields from mutt_parse_rfc822_header() is also in somewhat poor taste, but
 I didn't think it was important enough to create a shared function for
 this.

 Feedback is most welcome!

--
Ticket URL: 
Mutt 
The Mutt mail user agent



Bug#671847: #3879: mutt: encoded-words are not decoded in mailto:

2016-09-28 Thread Mutt
#3879: mutt: encoded-words are not decoded in mailto:
+--
  Reporter:  antonio@…  |  Owner:  mutt-dev
  Type:  defect | Status:  reopened
  Priority:  major  |  Milestone:
 Component:  charset|Version:  1.7.0
Resolution: |   Keywords:
+--

Comment (by kevin8t8):

 Thanks Thomas.  I figured there was a good reason
 mutt_read_rfc822_header() was doing it in that order, but couldn't figure
 out what it was!  :-)

 I'll redo this today.

--
Ticket URL: 
Mutt 
The Mutt mail user agent



Bug#671847: #3879: mutt: encoded-words are not decoded in mailto:

2016-09-27 Thread Mutt
#3879: mutt: encoded-words are not decoded in mailto:
+--
  Reporter:  antonio@…  |  Owner:  mutt-dev
  Type:  defect | Status:  reopened
  Priority:  major  |  Milestone:
 Component:  charset|Version:  1.7.0
Resolution: |   Keywords:
+--
Changes (by roessler@…):

 * cc: kevin@…, antonio@… (added)
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 {{{
 You should do the RFC 2822 parse first, then the decode -- 2047 is
 specifically written so it parses as one token.

 Thomas Roessler  (@roessler)

 On Tue, Sep 27, 2016 at 6:17 PM, Mutt  wrote:

 }}}

--
Ticket URL: 
Mutt 
The Mutt mail user agent



Bug#671847: #3879: mutt: encoded-words are not decoded in mailto:

2016-09-27 Thread Mutt
#3879: mutt: encoded-words are not decoded in mailto:
+--
  Reporter:  antonio@…  |  Owner:  mutt-dev
  Type:  defect | Status:  closed
  Priority:  major  |  Milestone:
 Component:  charset|Version:  1.7.0
Resolution:  fixed  |   Keywords:
+--
Changes (by Kevin McCarthy ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55819a7e61695bffea31646464183fcb2d54899d"
 6802:55819a7e6169]:
 {{{
 #!CommitTicketReference repository=""
 revision="55819a7e61695bffea31646464183fcb2d54899d"
 RFC2047-decode mailto header values. (closes #3879)

 RFC 6068 specifies that the header values (with the exception of body)
 may contain RFC 2047-encoded values.
 }}}

--
Ticket URL: 
Mutt 
The Mutt mail user agent



Bug#671847: #3879: mutt: encoded-words are not decoded in mailto:

2016-09-26 Thread Mutt
#3879: mutt: encoded-words are not decoded in mailto:
+--
  Reporter:  antonio@…  |  Owner:  mutt-dev
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:
 Component:  charset|Version:  1.7.0
Resolution: |   Keywords:
+--
Changes (by kevin8t8):

 * Attachment "ticket-3879.patch" added.


--
Ticket URL: 
Mutt 
The Mutt mail user agent



Bug#671847: #3879: mutt: encoded-words are not decoded in mailto:

2016-09-26 Thread Mutt
#3879: mutt: encoded-words are not decoded in mailto:
+--
  Reporter:  antonio@…  |  Owner:  mutt-dev
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:
 Component:  charset|Version:  1.7.0
Resolution: |   Keywords:
+--

Comment (by kevin8t8):

 I'm attaching a proposed patch.  This just adds a rfc2047 decode call for
 the header values (with the exception of body).  I think this should solve
 the problem for the basic "subject" case.

 One concern I have is for other address fields, e.g. Cc, whether doing the
 decode before the mutt_parse_rfc822_line() call is acceptable.  I'll have
 to think about that a bit more before I commit it.

--
Ticket URL: 
Mutt 
The Mutt mail user agent



Bug#671847: #3879: mutt: encoded-words are not decoded in mailto:

2016-09-25 Thread Mutt
#3879: mutt: encoded-words are not decoded in mailto:
---+--
 Reporter:  antonio@…  |  Owner:  mutt-dev
 Type:  defect | Status:  new
 Priority:  major  |  Milestone:
Component:  charset|Version:  1.7.0
 Keywords: |
---+--
 From http://bugs.debian.org/671847

 (Confirmed in 1.7.0)

 When fed the following example from RFC 6068:

  $ mutt
 'mailto:u...@example.org?subject=%3D%3Fiso-8859-1%3FQ%3Fcaf%3DE9%3F%3D'

 The subject line is not properly decoded to "café" as per RFC 2047, and
 remains "=?iso-8859-1?Q?caf=E9?=".

--
Ticket URL: 
Mutt 
The Mutt mail user agent