Bug#672044: add patch, uploaded to delayed/5

2012-05-23 Thread Pino Toscano
Hi,

Alle martedì 22 maggio 2012, Matthias Klose ha scritto:
 +  * Fix build failure with GCC 4.7. Closes: #672044.
 +  * Build with -fpermissive.

What?

 +CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) -fpermissive
 +
 +override_dh_auto_configure:
 +   CXXFLAGS=$(CXXFLAGS) dh_auto_configure
 +
  override_dh_install:

Building with -fpermissive is totally *not* acceptable, so please cancel 
your kdenetwork NMU bringing this patch.
A better patch (backported from upstream) has been committed to our git 
repository, so it will be part of the next upload.

On a general note, please note all of KDE 4.8 compiles fine already with 
GCC 4.7; since that version is what we're trying to push to wheezy, the 
more time you make us waste with such bugs which will be go away 
automatically with the new version, the less time we have to work on KDE 
4.8 for wheezy.

-- 
Pino Toscano


signature.asc
Description: This is a digitally signed message part.


Bug#672044: add patch, uploaded to delayed/5

2012-05-23 Thread Matthias Klose
On 23.05.2012 15:41, Pino Toscano wrote:
 Hi,
 
 Alle martedì 22 maggio 2012, Matthias Klose ha scritto:
 +  * Fix build failure with GCC 4.7. Closes: #672044.
 +  * Build with -fpermissive.
 
 What?
 
 +CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) -fpermissive
 +
 +override_dh_auto_configure:
 +   CXXFLAGS=$(CXXFLAGS) dh_auto_configure
 +
  override_dh_install:
 
 Building with -fpermissive is totally *not* acceptable, so please cancel 
 your kdenetwork NMU bringing this patch.
 A better patch (backported from upstream) has been committed to our git 
 repository, so it will be part of the next upload.
 
 On a general note, please note all of KDE 4.8 compiles fine already with 
 GCC 4.7; since that version is what we're trying to push to wheezy, the 
 more time you make us waste with such bugs which will be go away 
 automatically with the new version, the less time we have to work on KDE 
 4.8 for wheezy.

where can this be seen? the report was open without any comment or tag without a
while.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#672044: add patch, uploaded to delayed/5

2012-05-23 Thread Pino Toscano
Alle mercoledì 23 maggio 2012, Matthias Klose ha scritto:
 On 23.05.2012 15:41, Pino Toscano wrote:
  Hi,
  
  Alle martedì 22 maggio 2012, Matthias Klose ha scritto:
  +  * Fix build failure with GCC 4.7. Closes: #672044.
  +  * Build with -fpermissive.
  
  What?
  
  +CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) -fpermissive
  +
  +override_dh_auto_configure:
  +   CXXFLAGS=$(CXXFLAGS) dh_auto_configure
  +
  
   override_dh_install:
  Building with -fpermissive is totally *not* acceptable, so please
  cancel your kdenetwork NMU bringing this patch.
  A better patch (backported from upstream) has been committed to our
  git repository, so it will be part of the next upload.
  
  On a general note, please note all of KDE 4.8 compiles fine already
  with GCC 4.7; since that version is what we're trying to push to
  wheezy, the more time you make us waste with such bugs which will
  be go away automatically with the new version, the less time we
  have to work on KDE 4.8 for wheezy.
 
 where can this be seen? the report was open without any comment or
 tag without a while.

Your a while is quite short, just two weeks. Considering the problem 
popped up due to an unannounced change of yours, can you give us the 
time to handle them and work on KDE 4.8, which is what matters for us?
I lost a day yesterday to dig upstream for commits fixing these GCC 4.7 
FTBFSes and test them, and we're not done yet. Keeping into account that 
I'm spent time also in review your broken patch and reply to you, this 
effectively means that soon I've been wasted more than a day just for 
your impatience. Thanks a lot.

In the meanwhile, you're *highly* suggested to withdrawn this and the 
other kde* NMUs, thank you.

-- 
Pino Toscano


signature.asc
Description: This is a digitally signed message part.


Bug#672044: add patch, uploaded to delayed/5

2012-05-22 Thread Matthias Klose
tags 672044 + patch pending
thanks

add patch, uploaded to delayed/5
diff -Nru kdenetwork-4.7.4/debian/changelog kdenetwork-4.7.4/debian/changelog
--- kdenetwork-4.7.4/debian/changelog   2012-03-07 10:02:05.0 +0100
+++ kdenetwork-4.7.4/debian/changelog   2012-05-22 10:45:29.0 +0200
@@ -1,3 +1,11 @@
+kdenetwork (4:4.7.4-2.1) unstable; urgency=low
+
+  * Non maintainer upload.
+  * Fix build failure with GCC 4.7. Closes: #672044.
+  * Build with -fpermissive.
+
+ -- Matthias Klose d...@debian.org  Tue, 22 May 2012 00:26:33 +
+
 kdenetwork (4:4.7.4-2) unstable; urgency=low
 
   * Team upload. Upload to unstable.
diff -Nru kdenetwork-4.7.4/debian/patches/ftbfs-gcc-4.7.diff 
kdenetwork-4.7.4/debian/patches/ftbfs-gcc-4.7.diff
--- kdenetwork-4.7.4/debian/patches/ftbfs-gcc-4.7.diff  1970-01-01 
01:00:00.0 +0100
+++ kdenetwork-4.7.4/debian/patches/ftbfs-gcc-4.7.diff  2012-05-22 
12:03:59.0 +0200
@@ -0,0 +1,24 @@
+Index: 
kdenetwork-4.7.4/kopete/protocols/jabber/googletalk/libjingle/talk/base/socketaddress.cc
+===
+--- 
kdenetwork-4.7.4.orig/kopete/protocols/jabber/googletalk/libjingle/talk/base/socketaddress.cc
  2011-06-24 13:03:56.0 +0200
 
kdenetwork-4.7.4/kopete/protocols/jabber/googletalk/libjingle/talk/base/socketaddress.cc
   2012-05-22 02:29:18.956065866 +0200
+@@ -35,6 +35,7 @@
+ 
+ #include cstring
+ #include sstream
++#include unistd.h
+ 
+ #include talk/base/byteorder.h
+ #include talk/base/common.h
+Index: 
kdenetwork-4.7.4/kopete/protocols/jabber/googletalk/libjingle/talk/base/ssladapter.cc
+===
+--- 
kdenetwork-4.7.4.orig/kopete/protocols/jabber/googletalk/libjingle/talk/base/ssladapter.cc
 2011-06-24 13:03:56.0 +0200
 
kdenetwork-4.7.4/kopete/protocols/jabber/googletalk/libjingle/talk/base/ssladapter.cc
  2012-05-22 12:03:49.552844812 +0200
+@@ -26,6 +26,7 @@
+  */
+ 
+ #include talk/base/ssladapter.h
++#include unistd.h
+ 
+ #if !defined(SSL_USE_SCHANNEL)  !defined(SSL_USE_OPENSSL)
+ #ifdef WIN32
diff -Nru kdenetwork-4.7.4/debian/patches/series 
kdenetwork-4.7.4/debian/patches/series
--- kdenetwork-4.7.4/debian/patches/series  2012-03-07 09:44:17.0 
+0100
+++ kdenetwork-4.7.4/debian/patches/series  2012-05-22 02:27:52.0 
+0200
@@ -1,3 +1,4 @@
 no_home_set.diff
 protocols_namespaces.diff
 libgadu_pthread_check.diff
+ftbfs-gcc-4.7.diff
diff -Nru kdenetwork-4.7.4/debian/rules kdenetwork-4.7.4/debian/rules
--- kdenetwork-4.7.4/debian/rules   2012-03-07 09:44:17.0 +0100
+++ kdenetwork-4.7.4/debian/rules   2012-05-22 11:01:29.0 +0200
@@ -4,6 +4,11 @@
 
 .PHONY: override_dh_auto_test
 
+CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) -fpermissive
+
+override_dh_auto_configure:
+   CXXFLAGS=$(CXXFLAGS) dh_auto_configure
+
 override_dh_install:
$(overridden_command)
if [ -d debian/kppp ]; then \