Bug#672985: [Pkg-e-devel] Bug#672985: FTBFS: test suite makes assumptions of signed char

2012-05-15 Thread Albin Tonnerre
On Tue, May 15, 2012 at 10:57 AM, Albin Tonnerre  wrote:
>
> Thanks for the patch, by the way.

I didn't take a look with the patch before I replied, but I don't think I agree
with your fix. The conversion is done for TYPE_CHAR, which for eina means
signed char (there's TYPE_UCHAR for unsigned). The eina code should rather be
fixed to use signed chars in TYPE_CHAR handling routines.

Cheers,
-- 
Albin



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#672985: [Pkg-e-devel] Bug#672985: FTBFS: test suite makes assumptions of signed char

2012-05-15 Thread Albin Tonnerre
On Tue, May 15, 2012 at 10:47 AM, shawn  wrote:
> Source: eina
> Version: 1.2.0
> Severity: serious
> Tags: upstream patch
> Justification: fails to build from source (but built successfully in the past)
>
> This package makes a few assumptions which prevent it from being built on 
> architectures
> which have an unsigned char.

Thanks! I spotted the first issue yesterday too, but I'm not sure either about
what happens in the second case. I'll try to have a closer look in the next few
days. Thanks for the patch, by the way.

Cheers,
-- 
Albin



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org