Bug#675350: closed by "Matteo F. Vescovi" (Re: Bug#675350: babl: Please ship additional header files)

2012-06-01 Thread Mathieu Trudel-Lapierre 
> From: "Matteo F. Vescovi" 
> To: Mathieu Trudel-Lapierre 
> Cc: 675350-d...@bugs.debian.org
> Date: Fri, 1 Jun 2012 12:15:59 +0200
> Subject: Re: Bug#675350: babl: Please ship additional header files
> Hi!
[...]
> I've consulted upstream to see if it has some kind of sense to apply
> these changes directly on their code.
> Well, they told me that, instead of changing babl source, it would be
> better to fix gnome-scan code ;-) And I agree with them.

Thanks. I was able to investigate into this again and figured out a
way to fix gnome-scan without involving such changes to Babl.
However...

>
> I'm not comfortable with exposing what upstream considers private API
> just because a package is trying to misuse it. If you really need this
> API to become public, please treat the issue upstream.

None of this is specifically mentioned anywhere as being private API;
nor a misuse of the API. The Babl object is explicitly defined as a
union of the other object types to allow using internal members
without casting. It's also done the same way on the website main page.

However, I do agree that it's an issue to be brought upstream:
documentation needs to be very much clarified.

Regards, and thanks for the prompt responses;

Mathieu Trudel-Lapierre 
Freenode: cyphermox, Jabber: mathieu...@gmail.com
4096R/EE018C93 1967 8F7D 03A1 8F38 732E  FF82 C126 33E1 EE01 8C93



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#675350: babl: Please ship additional header files

2012-05-31 Thread Mathieu Trudel-Lapierre 
Package: babl
Version: 0.1.10-1
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu quantal ubuntu-patch

Dear Maintainer,

gnome-scan makes use of the Babl objects directly; expecting to be working on a 
BablFormat object. This is required to port gnome-scan to the new 
libgegl/libbabl versions; and appears to require additional header files.

To successfully port gnome-scan to the new gegl and babl libraries I've needed 
as a minimum the additional babl-classes.h file which is required to properly 
define a Babl object as a union of the other Babl types (esp. BablFormat) and 
babl-format.h (defining BablFormat itself).

*** /tmp/tmpSu1h0T/bug_body
In Ubuntu, the attached patch was applied to achieve the following:

  * debian/babl-includes.patch: add all headers files as files to ship;
otherwise some packages (gnome-scan) fail to build.

Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers quantal-updates
  APT policy: (500, 'quantal-updates'), (500, 'quantal-security'), (500, 
'quantal'), (100, 'quantal-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.4.0-3-generic (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
=== added directory 'debian/patches'
=== added file 'debian/patches/babl-includes.patch'
--- debian/patches/babl-includes.patch	1970-01-01 00:00:00 +
+++ debian/patches/babl-includes.patch	2012-05-31 12:14:34 +
@@ -0,0 +1,40 @@
+From: Mathieu Trudel-Lapierre 
+Subject: Add more headers to files to install to /usr/include/
+
+---
+ babl/Makefile.am |5 +
+ babl/Makefile.in |5 +
+ 2 files changed, 2 insertions(+), 8 deletions(-)
+
+Index: b/babl/Makefile.am
+===
+--- a/babl/Makefile.am
 b/babl/Makefile.am
+@@ -62,10 +62,7 @@ h_sources  =\
+ 	babl-util.h
+ 
+ library_includedir=$(includedir)/babl-$(BABL_API_VERSION)/babl
+-libinc_hdrs = \
+-	babl-macros.h   \
+-	babl-types.h\
+-	babl.h
++libinc_hdrs = $(h_sources)
+ libinc_generated_hdrs = \
+ 	babl-version.h
+ library_include_HEADERS = \
+Index: b/babl/Makefile.in
+===
+--- a/babl/Makefile.in
 b/babl/Makefile.in
+@@ -385,10 +385,7 @@ h_sources = \
+ 	babl-util.h
+ 
+ library_includedir = $(includedir)/babl-$(BABL_API_VERSION)/babl
+-libinc_hdrs = \
+-	babl-macros.h   \
+-	babl-types.h\
+-	babl.h
++libinc_hdrs = $(h_sources)
+ 
+ libinc_generated_hdrs = \
+ 	babl-version.h

=== added file 'debian/patches/series'
--- debian/patches/series	1970-01-01 00:00:00 +
+++ debian/patches/series	2012-05-24 20:09:44 +
@@ -0,0 +1 @@
+babl-includes.patch