Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-18 Thread Rémi Vanicat 
Julien Cristau jcris...@debian.org writes:

 On Mon, Jun 18, 2012 at 00:23:38 +0200, Benjamin Drung wrote:

 Am Sonntag, den 17.06.2012, 21:11 +0200 schrieb Rémi Vanicat:
  The attached patch solve the FTBS.
 
 Can you please read [1] and check if we follow their rules? We need to
 rename the ruby package. Can make this package support all supported
 ruby versions?
 
 A rename means NEW, which means it's not appropriate to fix this RC bug.
 You can rename afterwards if you like.

So I've uploaded a version that just add what is needed for the ruby1.8
to be build correctly (and I've added myself as an uploader). 

-- 
Rémi Vanicat



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-18 Thread Julien Cristau 
On Mon, Jun 18, 2012 at 11:30:06 +0200, Rémi Vanicat wrote:

 So I've uploaded a version that just add what is needed for the ruby1.8
 to be build correctly (and I've added myself as an uploader). 
 
Seems to FTBFS on the kbsd buildds.

Cheers,
Julien



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-18 Thread Daniel Svensson 
On Mon, Jun 18, 2012 at 7:08 PM, Julien Cristau jcris...@debian.org wrote:
 On Mon, Jun 18, 2012 at 11:30:06 +0200, Rémi Vanicat wrote:

 So I've uploaded a version that just add what is needed for the ruby1.8
 to be build correctly (and I've added myself as an uploader).

 Seems to FTBFS on the kbsd buildds.

I would probably try -j 1 on kfreebsd as waf defaults to the number of
cores available. Both amd64 and i386 failed, but amd64 passed the
second time. We've seen some weird python threading problems before on
odd platforms, worth a shot. Perhaps a bug for the python package
should be opened, could be worth checking out success rate of other
build systems using python (I know there are more projects using SCons
and waf at least).

-- 
Daniel Svensson



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Julien Cristau 
tags 676100 + patch
tags 676100 + pending
thanks

Dear maintainer,

I've prepared an NMU for xmms2 (versioned as 0.8+dfsg-2.1) and
uploaded it to DELAYED/2. Please feel free to tell me if I
should delay it longer.

Cheers,
Julien
diff -Nru xmms2-0.8+dfsg/debian/changelog xmms2-0.8+dfsg/debian/changelog
--- xmms2-0.8+dfsg/debian/changelog	2012-02-07 17:18:39.0 +0100
+++ xmms2-0.8+dfsg/debian/changelog	2012-06-17 12:28:11.0 +0200
@@ -1,3 +1,10 @@
+xmms2 (0.8+dfsg-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Don't build ruby packages (closes: #676100)
+
+ -- Julien Cristau jcris...@debian.org  Sun, 17 Jun 2012 12:28:09 +0200
+
 xmms2 (0.8+dfsg-2) unstable; urgency=low
 
   * Unpack waf binary (following http://wiki.debian.org/UnpackWaf)
diff -Nru xmms2-0.8+dfsg/debian/control xmms2-0.8+dfsg/debian/control
--- xmms2-0.8+dfsg/debian/control	2012-02-07 17:16:51.0 +0100
+++ xmms2-0.8+dfsg/debian/control	2012-06-17 11:40:42.0 +0200
@@ -169,37 +169,6 @@
  .
  This package contains a glib based client library written in c.
 
-Package: libxmmsclient-ruby
-Architecture: all
-Section: ruby
-Depends: libxmmsclient-ruby1.8, ruby, ${misc:Depends}
-Description: XMMS2 - Ruby client library
- XMMS2 is a redesign of the XMMS music player. It features a client-server
- model, allowing multiple (even simultaneous!) user interfaces, both textual
- and graphical. All common audio formats are supported using plug-ins. On top of
- this, there is a flexible media library to organize your music.
- .
- This package contains a Ruby library that allows you to write XMMS2 clients.
- It's a language binding of libxmmsclient0.
- .
- This package is an empty dummy package that always depends on a package
- built for Debian's default Ruby version.
-
-Package: libxmmsclient-ruby1.8
-Architecture: any
-Section: ruby
-Depends: ruby1.8, ${misc:Depends}, ${shlibs:Depends}
-Description: XMMS2 - Ruby bindings
- XMMS2 is a redesign of the XMMS music player. It features a client-server
- model, allowing multiple (even simultaneous!) user interfaces, both textual
- and graphical. All common audio formats are supported using plug-ins. On top of
- this, there is a flexible media library to organize your music.
- .
- This package contains a Ruby library that allows you to write XMMS2 clients.
- It's a language binding of libxmmsclient0.
- .
- This package is compiled for Ruby 1.8.
-
 Package: libxmmsclient6
 Architecture: any
 Section: libs


signature.asc
Description: Digital signature

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Benjamin Drung 
Am Sonntag, den 17.06.2012, 13:08 +0200 schrieb Julien Cristau:
 I've prepared an NMU for xmms2 (versioned as 0.8+dfsg-2.1) and
 uploaded it to DELAYED/2. Please feel free to tell me if I
 should delay it longer.

Dropping the ruby package seems to be the wrong fix. xmms2 fails to
build due to the ruby switch to version 1.9 as default. The correct
solution is probably to contact the ruby team and get the ruby part of
the package updated to follow the latest ruby specs.

-- 
Benjamin Drung
Debian  Ubuntu Developer


signature.asc
Description: This is a digitally signed message part

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Julien Cristau 
On Sun, Jun 17, 2012 at 15:23:16 +0200, Benjamin Drung wrote:

 Am Sonntag, den 17.06.2012, 13:08 +0200 schrieb Julien Cristau:
  I've prepared an NMU for xmms2 (versioned as 0.8+dfsg-2.1) and
  uploaded it to DELAYED/2. Please feel free to tell me if I
  should delay it longer.
 
 Dropping the ruby package seems to be the wrong fix. xmms2 fails to
 build due to the ruby switch to version 1.9 as default. The correct
 solution is probably to contact the ruby team and get the ruby part of
 the package updated to follow the latest ruby specs.
 
The xmms2 ruby package has no reverse dep in the archive, and this bug
has had no answer in almost two weeks.  If you want to go for a
different fix go right ahead, but I won't, seeing how I have no interest
in either ruby or xmms2...

Cheers,
Julien



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Daniel Svensson 
On Sun, Jun 17, 2012 at 4:11 PM, Julien Cristau jcris...@debian.org wrote:
 On Sun, Jun 17, 2012 at 15:23:16 +0200, Benjamin Drung wrote:

 Am Sonntag, den 17.06.2012, 13:08 +0200 schrieb Julien Cristau:
  I've prepared an NMU for xmms2 (versioned as 0.8+dfsg-2.1) and
  uploaded it to DELAYED/2. Please feel free to tell me if I
  should delay it longer.

 Dropping the ruby package seems to be the wrong fix. xmms2 fails to
 build due to the ruby switch to version 1.9 as default. The correct
 solution is probably to contact the ruby team and get the ruby part of
 the package updated to follow the latest ruby specs.

 The xmms2 ruby package has no reverse dep in the archive, and this bug
 has had no answer in almost two weeks.  If you want to go for a
 different fix go right ahead, but I won't, seeing how I have no interest
 in either ruby or xmms2...

The XMMS2 build system uses the system default ruby to get its
compiler flags for the ruby bindings. This can be overridden by
setting the RUBY environment to point to another executable. Just
verified this and Ruby 1.9.1 builds just fine. Support for 1.9.x has
been available in XMMS2 since january 2008.

-- 
Daniel Svensson



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Rémi Vanicat 
Benjamin Drung bdr...@debian.org writes:

 Am Sonntag, den 17.06.2012, 13:08 +0200 schrieb Julien Cristau:
 I've prepared an NMU for xmms2 (versioned as 0.8+dfsg-2.1) and
 uploaded it to DELAYED/2. Please feel free to tell me if I
 should delay it longer.

 Dropping the ruby package seems to be the wrong fix. xmms2 fails to
 build due to the ruby switch to version 1.9 as default. The correct
 solution is probably to contact the ruby team and get the ruby part of
 the package updated to follow the latest ruby specs.

The attached patch solve the FTBS, but I don't know if I don't miss
something as my ruby  xmms apps are only half working with this
(https://github.com/vanicat/xmms-gtk-rater).

By the way Benjamin, do you need help for maintaining xmms2 ? If yes, I
could help, being a Debian developer interested by xmms2. That said I'm
not a very active developer.

Julien, could you delay the nmu more for a less intrusive patch to be
found?

Thanks.

diff -Nru xmms2-0.8+dfsg/debian/changelog xmms2-0.8+dfsg/debian/changelog
--- xmms2-0.8+dfsg/debian/changelog	2012-02-07 17:18:39.0 +0100
+++ xmms2-0.8+dfsg/debian/changelog	2012-06-17 14:44:27.0 +0200
@@ -1,3 +1,9 @@
+xmms2 (0.8+dfsg-2.1) UNRELEASED; urgency=low
+
+  * depend on ruby1.8
+
+ -- Rémi Vanicat vani...@debian.org  Sun, 17 Jun 2012 14:34:57 +0200
+
 xmms2 (0.8+dfsg-2) unstable; urgency=low
 
   * Unpack waf binary (following http://wiki.debian.org/UnpackWaf)
diff -Nru xmms2-0.8+dfsg/debian/control xmms2-0.8+dfsg/debian/control
--- xmms2-0.8+dfsg/debian/control	2012-02-07 17:16:51.0 +0100
+++ xmms2-0.8+dfsg/debian/control	2012-06-17 20:30:59.0 +0200
@@ -46,7 +46,8 @@
python-all-dev (= 2.6.6-3~),
python-pyrex,
ruby,
-   ruby1.8-dev
+   ruby1.9.1,
+   ruby1.9.1-dev
 Vcs-Git: git://git.debian.org/git/pkg-xmms2/xmms2
 Vcs-Browser: http://git.debian.org/?p=pkg-xmms2/xmms2.git
 Homepage: http://xmms2.org/
@@ -172,7 +173,7 @@
 Package: libxmmsclient-ruby
 Architecture: all
 Section: ruby
-Depends: libxmmsclient-ruby1.8, ruby, ${misc:Depends}
+Depends: libxmmsclient-ruby1.9.1, ruby, ${misc:Depends}
 Description: XMMS2 - Ruby client library
  XMMS2 is a redesign of the XMMS music player. It features a client-server
  model, allowing multiple (even simultaneous!) user interfaces, both textual
@@ -185,10 +186,10 @@
  This package is an empty dummy package that always depends on a package
  built for Debian's default Ruby version.
 
-Package: libxmmsclient-ruby1.8
+Package: libxmmsclient-ruby1.9.1
 Architecture: any
 Section: ruby
-Depends: ruby1.8, ${misc:Depends}, ${shlibs:Depends}
+Depends: ruby1.9.1, ${misc:Depends}, ${shlibs:Depends}
 Description: XMMS2 - Ruby bindings
  XMMS2 is a redesign of the XMMS music player. It features a client-server
  model, allowing multiple (even simultaneous!) user interfaces, both textual
@@ -198,7 +199,7 @@
  This package contains a Ruby library that allows you to write XMMS2 clients.
  It's a language binding of libxmmsclient0.
  .
- This package is compiled for Ruby 1.8.
+ This package is compiled for Ruby 1.9.1.
 
 Package: libxmmsclient6
 Architecture: any
diff -Nru xmms2-0.8+dfsg/debian/libxmmsclient-ruby1.8.install xmms2-0.8+dfsg/debian/libxmmsclient-ruby1.8.install
--- xmms2-0.8+dfsg/debian/libxmmsclient-ruby1.8.install	2012-02-07 17:11:28.0 +0100
+++ xmms2-0.8+dfsg/debian/libxmmsclient-ruby1.8.install	1970-01-01 01:00:00.0 +0100
@@ -1 +0,0 @@
-usr/lib/ruby/1.8/*
diff -Nru xmms2-0.8+dfsg/debian/libxmmsclient-ruby1.9.1.install xmms2-0.8+dfsg/debian/libxmmsclient-ruby1.9.1.install
--- xmms2-0.8+dfsg/debian/libxmmsclient-ruby1.9.1.install	1970-01-01 01:00:00.0 +0100
+++ xmms2-0.8+dfsg/debian/libxmmsclient-ruby1.9.1.install	2012-06-17 20:38:17.0 +0200
@@ -0,0 +1 @@
+usr/lib/ruby/1.9.1/*
diff -Nru xmms2-0.8+dfsg/debian/rules xmms2-0.8+dfsg/debian/rules
--- xmms2-0.8+dfsg/debian/rules	2012-02-07 17:22:13.0 +0100
+++ xmms2-0.8+dfsg/debian/rules	2012-06-17 20:31:44.0 +0200
@@ -4,6 +4,7 @@
 
 PYVERSIONS := $(shell pyversions -s)
 VENDOR ?= $(shell if dpkg-vendor --is Ubuntu || dpkg-vendor --derives-from Ubuntu; then echo Ubuntu; else echo Debian; fi)
+RUBY = /usr/bin/ruby1.9.1
 
 ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 	NUMJOBS := $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
@@ -34,8 +35,8 @@
 	./waf configure $(WAFFLAGS) \
 		--with-perl-archdir=$(shell /usr/bin/perl -MConfig -le'print $$Config{vendorarch}') \
 		--with-perl-binary=/usr/bin/perl \
-		--with-ruby-archdir=$(shell ruby1.8 -rrbconfig -e'print Config::CONFIG[archdir]') \
-		--with-ruby-libdir=$(shell ruby1.8 -rrbconfig -e'print Config::CONFIG[rubylibdir]') \
+		--with-ruby-archdir=$(shell ruby1.9.1 -rrbconfig -e'print Config::CONFIG[archdir]') \
+		--with-ruby-libdir=$(shell ruby1.9.1 -rrbconfig -e'print Config::CONFIG[rubylibdir]') \
 		--without-optionals=et,python

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Rémi Vanicat 
Rémi Vanicat vani...@debian.org writes:

[...]

 The attached patch solve the FTBS, but I don't know if I don't miss
 something as my ruby  xmms apps are only half working with this
 (https://github.com/vanicat/xmms-gtk-rater).

More test show that it was an incompatibility between my software and
ruby1.9, The patch is correct, and I will prepare an NMU tomorrow
morning if nothing happen until then.

[...]


-- 
Rémi Vanicat



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Julien Cristau 
On Sun, Jun 17, 2012 at 21:11:39 +0200, Rémi Vanicat wrote:

 Julien, could you delay the nmu more for a less intrusive patch to be
 found?
 
Rescheduled to 5 days.

Cheers,
Julien



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Benjamin Drung 
Am Sonntag, den 17.06.2012, 21:11 +0200 schrieb Rémi Vanicat:
 The attached patch solve the FTBS.

Can you please read [1] and check if we follow their rules? We need to
rename the ruby package. Can make this package support all supported
ruby versions?

[1] http://lists.debian.org/debian-devel-announce/2012/06/msg1.html

 By the way Benjamin, do you need help for maintaining xmms2? If yes, I
 could help, being a Debian developer interested by xmms2.  That said
I'm
 not a very active developer.

Yes, definitively! I forgot to RFA this package months ago. Do you want
to adopt it or do you prefer to team maintain it? If you prefer team
maintenance, it can be either the XMMS2 team (Fabrizio Regalli seems to
be the only active member besides me in this team) or we move the
package under the hood of the multimedia team. I am willing to still
touch this package from time to time as team member.

-- 
Benjamin Drung
Debian  Ubuntu Developer


signature.asc
Description: This is a digitally signed message part

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Julien Cristau 
On Mon, Jun 18, 2012 at 00:23:38 +0200, Benjamin Drung wrote:

 Am Sonntag, den 17.06.2012, 21:11 +0200 schrieb Rémi Vanicat:
  The attached patch solve the FTBS.
 
 Can you please read [1] and check if we follow their rules? We need to
 rename the ruby package. Can make this package support all supported
 ruby versions?
 
A rename means NEW, which means it's not appropriate to fix this RC bug.
You can rename afterwards if you like.

Cheers,
Julien



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#676100: xmms2: diff for NMU version 0.8+dfsg-2.1

2012-06-17 Thread Benjamin Drung 
Am Montag, den 18.06.2012, 00:38 +0200 schrieb Julien Cristau:
 On Mon, Jun 18, 2012 at 00:23:38 +0200, Benjamin Drung wrote:
 
  Am Sonntag, den 17.06.2012, 21:11 +0200 schrieb Rémi Vanicat:
   The attached patch solve the FTBS.
  
  Can you please read [1] and check if we follow their rules? We need to
  rename the ruby package. Can make this package support all supported
  ruby versions?
  
 A rename means NEW, which means it's not appropriate to fix this RC bug.
 You can rename afterwards if you like.

Why is going through NEW inappropriate?

-- 
Benjamin Drung
Debian  Ubuntu Developer


signature.asc
Description: This is a digitally signed message part