Bug#679390: debian-el: M-x debian-bug does not run bug script if it is a symlink
Sincere apologies... :-( Peter Sven Joachim wrote: > > Ping? I have been applying this patch locally for the last releases, > > would like not having to do this anymore. > > Ping again… :-( > > Cheers, >Sven -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#679390: debian-el: M-x debian-bug does not run bug script if it is a symlink
On 2013-10-19 18:54 +0200, Sven Joachim wrote: > On 2012-06-28 13:46 +0200, Sven Joachim wrote: > >> tags 679390 + patch >> thanks >> >> On 2012-06-28 13:03 +0200, Sven Joachim wrote: >> >>> Package: debian-el >>> Version: 35.2 >>> Severity: normal >>> >>> M-x debian-bug does not run the package's bug script if it is a >>> symlink. So far I have tracked this down to debian-bug-find-bug-script >>> which returns nil in such cases: >>> >>> (debian-bug-find-bug-script "xserver-xorg-video-nouveau") => nil >>> >>> (debian-bug-find-bug-script "xserver-xorg-core") => >>> "/usr/share/bug/xserver-xorg-core/script" >>> >>> However, these packages actually use the same script: >>> >>> , >>> | $ file /usr/share/bug/xserver-xorg-video-nouveau/script >>> | /usr/share/bug/xserver-xorg-video-nouveau/script: symbolic link to >>> `../xserver-xorg-core/script' >>> ` >>> >>> I'm 99% sure this had worked in the past. >> >> Looks like it broke more than two years ago, though. >> >>> Wonder what broke it. >> >> That part was easy, it's the rather bogus check for executability in >> debian-bug-file-is-executable. The following one-liner fixes it: >> >> diff -Nru emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el >> emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el >> --- emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el 2010-06-22 >> 23:55:44.0 +0200 >> +++ emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el 2012-06-28 >> 13:18:12.0 +0200 >> @@ -781,7 +781,7 @@ >>"Return non-nil if FILE is executable. Otherwise nil is returned." >>(and >> (file-regular-p file) >> - (string-match "-..x..x..x" (nth 8 (file-attributes file) >> + (file-executable-p file))) >> >> (defun debian-bug-find-bug-script (package) >>"Return the full path name of the bug script of PACKAGE. > > Ping? I have been applying this patch locally for the last releases, > would like not having to do this anymore. Ping again… :-( Cheers, Sven -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#679390: debian-el: M-x debian-bug does not run bug script if it is a symlink
On 2012-06-28 13:46 +0200, Sven Joachim wrote: > tags 679390 + patch > thanks > > On 2012-06-28 13:03 +0200, Sven Joachim wrote: > >> Package: debian-el >> Version: 35.2 >> Severity: normal >> >> M-x debian-bug does not run the package's bug script if it is a >> symlink. So far I have tracked this down to debian-bug-find-bug-script >> which returns nil in such cases: >> >> (debian-bug-find-bug-script "xserver-xorg-video-nouveau") => nil >> >> (debian-bug-find-bug-script "xserver-xorg-core") => >> "/usr/share/bug/xserver-xorg-core/script" >> >> However, these packages actually use the same script: >> >> , >> | $ file /usr/share/bug/xserver-xorg-video-nouveau/script >> | /usr/share/bug/xserver-xorg-video-nouveau/script: symbolic link to >> `../xserver-xorg-core/script' >> ` >> >> I'm 99% sure this had worked in the past. > > Looks like it broke more than two years ago, though. > >> Wonder what broke it. > > That part was easy, it's the rather bogus check for executability in > debian-bug-file-is-executable. The following one-liner fixes it: > > diff -Nru emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el > emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el > --- emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el 2010-06-22 > 23:55:44.0 +0200 > +++ emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el 2012-06-28 > 13:18:12.0 +0200 > @@ -781,7 +781,7 @@ >"Return non-nil if FILE is executable. Otherwise nil is returned." >(and > (file-regular-p file) > - (string-match "-..x..x..x" (nth 8 (file-attributes file) > + (file-executable-p file))) > > (defun debian-bug-find-bug-script (package) >"Return the full path name of the bug script of PACKAGE. Ping? I have been applying this patch locally for the last releases, would like not having to do this anymore. Cheers, Sven -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#679390: debian-el: M-x debian-bug does not run bug script if it is a symlink
tags 679390 + patch thanks On 2012-06-28 13:03 +0200, Sven Joachim wrote: > Package: debian-el > Version: 35.2 > Severity: normal > > M-x debian-bug does not run the package's bug script if it is a > symlink. So far I have tracked this down to debian-bug-find-bug-script > which returns nil in such cases: > > (debian-bug-find-bug-script "xserver-xorg-video-nouveau") => nil > > (debian-bug-find-bug-script "xserver-xorg-core") => > "/usr/share/bug/xserver-xorg-core/script" > > However, these packages actually use the same script: > > , > | $ file /usr/share/bug/xserver-xorg-video-nouveau/script > | /usr/share/bug/xserver-xorg-video-nouveau/script: symbolic link to > `../xserver-xorg-core/script' > ` > > I'm 99% sure this had worked in the past. Looks like it broke more than two years ago, though. > Wonder what broke it. That part was easy, it's the rather bogus check for executability in debian-bug-file-is-executable. The following one-liner fixes it: --8<---cut here---start->8--- diff -Nru emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el --- emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el 2010-06-22 23:55:44.0 +0200 +++ emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el 2012-06-28 13:18:12.0 +0200 @@ -781,7 +781,7 @@ "Return non-nil if FILE is executable. Otherwise nil is returned." (and (file-regular-p file) - (string-match "-..x..x..x" (nth 8 (file-attributes file) + (file-executable-p file))) (defun debian-bug-find-bug-script (package) "Return the full path name of the bug script of PACKAGE. --8<---cut here---end--->8--- Cheers, Sven -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#679390: debian-el: M-x debian-bug does not run bug script if it is a symlink
Package: debian-el Version: 35.2 Severity: normal M-x debian-bug does not run the package's bug script if it is a symlink. So far I have tracked this down to debian-bug-find-bug-script which returns nil in such cases: (debian-bug-find-bug-script "xserver-xorg-video-nouveau") => nil (debian-bug-find-bug-script "xserver-xorg-core") => "/usr/share/bug/xserver-xorg-core/script" However, these packages actually use the same script: , | $ file /usr/share/bug/xserver-xorg-video-nouveau/script | /usr/share/bug/xserver-xorg-video-nouveau/script: symbolic link to `../xserver-xorg-core/script' ` I'm 99% sure this had worked in the past. Wonder what broke it. :-( -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (101, 'experimental') Architecture: i386 (x86_64) Kernel: Linux 3.4.4-nouveau (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages debian-el depends on: ii bzip2 1.0.6-3 ii dpkg 1.16.4.3 ii emacs-snapshot [emacsen] 1:20120624-1 ii emacs23 [emacsen] 23.4+1-3 ii file 5.11-1 ii install-info 4.13a.dfsg.1-10 ii reportbug 6.4 Versions of packages debian-el recommends: pn dlocate ii groff-base 1.21-9 ii wget1.13.4-3 Versions of packages debian-el suggests: pn gnus -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
