Bug#681457: libaudit: does not actually support ARM, breaks linked binary like readahead
Hi, On Sat, Nov 24, 2012 at 11:58:08PM +0100, Ivo De Decker wrote: Based on the upstream changes for arm, I created a new version of audit for wheezy. The debdiff is attached. This new version builds fine (tested on amd64 and armel). It works fine on amd64. On armel, I don't get the old error anymore, but now I get: Error sending add rule request (Invalid argument) It seems this is because my kernel doesn't have AUDITSYSCALL. This is because AUDITSYSCALL depends on (ARM AEABI !OABI_COMPAT), and as far as I can see, debian only ships arm kernels with AEABI and OABI_COMPAT enabled. I tested the patch on a kernel with AUDITSYSCALL, and it works fine. I will file a bug to ask pre-approval from the release team. Cheers, Ivo -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681457: libaudit: does not actually support ARM, breaks linked binary like readahead
Le Sat, 1 Dec 2012 14:24:39 +0100,
Ivo De Decker ivo.dedec...@ugent.be a écrit :
Hi,
On Sat, Nov 24, 2012 at 11:58:08PM +0100, Ivo De Decker wrote:
Based on the upstream changes for arm, I created a new version of
audit for wheezy. The debdiff is attached.
This new version builds fine (tested on amd64 and armel). It works
fine on amd64. On armel, I don't get the old error anymore, but now
I get:
Error sending add rule request (Invalid argument)
It seems this is because my kernel doesn't have AUDITSYSCALL. This
is because AUDITSYSCALL depends on (ARM AEABI !OABI_COMPAT),
and as far as I can see, debian only ships arm kernels with AEABI
and OABI_COMPAT enabled.
I tested the patch on a kernel with AUDITSYSCALL, and it works fine.
I will file a bug to ask pre-approval from the release team.
I'm currently fixing this in experimental. I'm only adding the ARM
syscall table (--with-armeb) on arm{el,hf} as it increase the size of
the libaudit package of ~8k.
Enabling this on other architecture would only be needed if audit was
serving as a log collector.
What do you think?
Laurent Bigonville
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681457: libaudit: does not actually support ARM, breaks linked binary like readahead
Hi Laurent,
On Sat, Dec 01, 2012 at 02:48:44PM +0100, Laurent Bigonville wrote:
I'm currently fixing this in experimental. I'm only adding the ARM
syscall table (--with-armeb) on arm{el,hf} as it increase the size of
the libaudit package of ~8k.
Enabling this on other architecture would only be needed if audit was
serving as a log collector.
What do you think?
As discussed on irc:
The other architectures (s390, powerpc, ia64) are compiled in by default, and
some of them are much less likely to be used than arm*. The distinction from
upstream is probably based on RedHat choices which are not relevant for
debian. So it seems reasonable to include arm* support.
Cheers,
Ivo
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681457: libaudit: does not actually support ARM, breaks linked binary like readahead
Hello, I've fixed this in the git branch for the experimental version. But I think that it's actually breaking tests on alpha, I'm waiting for a fix from upstream. As soon as this is fixed I'll upload. Cheers Laurent Bigonville See: http://anonscm.debian.org/gitweb/?p=collab-maint/audit.git;a=summary -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681457: libaudit: does not actually support ARM, breaks linked binary like readahead
Control: tags -1 patch
On Mon, Nov 19, 2012 at 05:53:17PM +0100, Laurent Bigonville wrote:
Hi,
FTR, I've asked about this to upstream, see this thread:
https://www.redhat.com/archives/linux-audit/2012-November/msg00012.html
Based on the upstream changes for arm, I created a new version of audit for
wheezy. The debdiff is attached.
This new version builds fine (tested on amd64 and armel). It works fine on
amd64. On armel, I don't get the old error anymore, but now I get:
Error sending add rule request (Invalid argument)
It seems this is because my kernel doesn't have AUDITSYSCALL. This is because
AUDITSYSCALL depends on (ARM AEABI !OABI_COMPAT), and as far as I can
see, debian only ships arm kernels with AEABI and OABI_COMPAT enabled.
I don't know if it makes sense to upload the patched version of audit to
unstable (to get it into wheezy). It might be useful for users with their own
kernel (with AUDITSYSCALL).
The other option is to downgrade this bug.
BTW to enable arm support for the version in experimental, adding
'--with-armeb' to the configure options should be enough.
Cheers,
Ivo
diff -Nru audit-1.7.18/debian/autogen.sh audit-1.7.18/debian/autogen.sh
--- audit-1.7.18/debian/autogen.sh 1970-01-01 01:00:00.0 +0100
+++ audit-1.7.18/debian/autogen.sh 2012-11-24 21:51:52.0 +0100
@@ -0,0 +1,21 @@
+#! /bin/sh
+# based on autogen.sh in upstream 1.8 svn branch
+
+autoreconf -fv --install
+
+cd system-config-audit
+
+autopoint -f
+# intltool bug: it tries to use $aux_dir/po/Makefile.in.in in older versions
+ln -s ../po admin/po
+# ... and it puts dummy intltool-*.in to ., not to $aux_dir in newer versions
+rm admin/intltool-{extract,merge,update}.in
+touch admin/intltool-{extract,merge,update}.in
+intltoolize --force
+rm admin/po
+
+aclocal -I m4
+autoconf -Wall
+autoheader -Wall
+automake -Wall --add-missing
+
diff -Nru audit-1.7.18/debian/changelog audit-1.7.18/debian/changelog
--- audit-1.7.18/debian/changelog 2012-01-31 16:36:25.0 +0100
+++ audit-1.7.18/debian/changelog 2012-11-24 23:24:55.0 +0100
@@ -1,3 +1,15 @@
+audit (1:1.7.18-2) unstable; urgency=low
+
+ * QA upload.
+ * Set Maintainer to Debian QA Group packa...@qa.debian.org (cf. #692492).
+ * debian/control: Add Vcs-* fields
+ * Backport patches to enable arm support (Closes: #681457)
+ * Use autoreconf to update generated files with autogen.sh based on upstream
+svn. This is necessary to build with changes in Makefile.am for arm
+support.
+
+ -- Ivo De Decker ivo.dedec...@ugent.be Sat, 24 Nov 2012 23:24:08 +0100
+
audit (1:1.7.18-1.1) unstable; urgency=low
* Non-maintainer upload.
diff -Nru audit-1.7.18/debian/control audit-1.7.18/debian/control
--- audit-1.7.18/debian/control 2011-07-29 23:22:06.0 +0200
+++ audit-1.7.18/debian/control 2012-11-24 21:44:49.0 +0100
@@ -1,15 +1,17 @@
Source: audit
Priority: extra
-Maintainer: Philipp Matthias Hahn pmh...@debian.org
+Maintainer: Debian QA Group packa...@qa.debian.org
Build-Depends: debhelper (= 8),
python-all-dev (= 2.6.6-3~), swig,
automake1.10, autoconf (= 2.59), libtool, autotools-dev,
intltool, cvs, libprelude-dev, libldap2-dev, libev-dev, chrpath,
- libwrap0-dev, libkrb5-dev
+ libwrap0-dev, libkrb5-dev, dh-autoreconf, autopoint
Build-Conflicts: autoconf2.13, automake1.4
Standards-Version: 3.9.2
Section: libs
Homepage: http://people.redhat.com/sgrubb/audit/
+Vcs-Git: git://anonscm.debian.org/git/collab-maint/audit.git
+Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/audit.git
Package: auditd
Section: admin
diff -Nru audit-1.7.18/debian/patches/arm-support.diff audit-1.7.18/debian/patches/arm-support.diff
--- audit-1.7.18/debian/patches/arm-support.diff 1970-01-01 01:00:00.0 +0100
+++ audit-1.7.18/debian/patches/arm-support.diff 2012-11-24 23:22:50.0 +0100
@@ -0,0 +1,536 @@
+Description: arm support
+ Backport from trunk of support for arm architecture.
+
+ Please note that upstream calls this 'armeb', but it should work with the arm
+ ports in debian (armel and armhf).
+
+---
+Origin: upstream
+Bug-Debian: http://bugs.debian.org/681457
+Forwarded: not-needed
+Last-Update: 20121124
+
+--- audit-1.7.18.orig/lib/libaudit.h
audit-1.7.18/lib/libaudit.h
+@@ -386,7 +386,8 @@ typedef enum {
+ MACH_PPC,
+ MACH_S390X,
+ MACH_S390,
+-MACH_ALPHA
++ MACH_ALPHA,
++ MACH_ARMEB
+ } machine_t;
+
+ /* These are the valid audit failure tunable enum values */
+--- audit-1.7.18.orig/lib/lookup_table.c
audit-1.7.18/lib/lookup_table.c
+@@ -37,6 +37,7 @@
+ #ifdef WITH_ALPHA
+ #include alpha_tables.h
+ #endif
++#include armeb_tables.h
+ #include i386_tables.h
+ #include ia64_tables.h
+ #include ppc_tables.h
+@@ -52,6 +53,10 @@
+ #include msg_typetabs.h
+ #include optabs.h
+
++#ifndef EM_ARM
++#define EM_ARM 40
++#endif
++
+ struct int_transtab {
+ intkey;
+ unsigned int lvalue;
+@@ -68,6 +73,7 @@ static const struct int_transtab elftab[
+ #ifdef
Bug#681457: libaudit: does not actually support ARM, breaks linked binary like readahead
Package: libaudit0 Followup-For: Bug #681457 Hello, FTR, I've asked about this to upstream, see this thread: https://www.redhat.com/archives/linux-audit/2012-November/msg00012.html Cheers, Laurent Bigonville -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.6-trunk-amd64 (SMP w/8 CPU cores) Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages libaudit0 depends on: ii libc6 2.13-37 libaudit0 recommends no packages. libaudit0 suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681457: libaudit: does not actually support ARM, breaks linked binary like readahead
I believe this package need to upgrade to 1.8 to properly support ARM:
https://fedorahosted.org/audit/browser/branches/1.8/lib/lookup_table.c
78 #ifdef WITH_ARMEB
79 { MACH_ARMEB, AUDIT_ARCH_ARMEB }
80 #endif
not true, this is support or Big endian ARM, which Debian does not
support, nor has any sort of port to (anymore). There doesn't appear to
be any support of little endian ARM.
--
-Shawn Landden
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681457: libaudit: does not actually support ARM, breaks linked binary like readahead
Package: libaudit0
Version: 1:1.7.18-1.1
Severity: normal
File: libaudit
Dear Maintainer,
While trying to figure out why readahead collector fails with:
readahead-collector: cannot insert audit rules
I seem to have tracked down the problem to libaudit (and libaudit-dev)
auditctl (from auditd package) doesn't work on the ARM machine:
# auditctl -a exit,always -S open -S truncate -F success=0
Error detecting machine type
String it's failing on (our own machine):
Linux lophilo1 3.4.0-rc7+ #19 Fri Jul 13 17:24:39 CST 2012
armv5tejl GNU/Linux
More specifically, does not support this machine type:
# uname -m
armv5tejl
The chain of calls:
audit-1.7.18/lib/libaudit.c:audit_rule_syscallbyname_data
if (!audit_elf)
machine = audit_detect_machine();
else
machine = audit_elf_to_machine(audit_elf);
this is:
int audit_detect_machine(void)
{
struct utsname uts;
if (uname(uts) == 0)
// strcpy(uts.machine, x86_64);
return audit_name_to_machine(uts.machine);
return -1;
}
...and audit-1.7.18/lib/lookup_table.c:audit_name_to_machine
int audit_name_to_machine(const char *machine)
{
int res;
if (machine_s2i(machine, res) != 0)
return res;
return -1;
}
I believe this package need to upgrade to 1.8 to properly support ARM:
https://fedorahosted.org/audit/browser/branches/1.8/lib/lookup_table.c
78 #ifdef WITH_ARMEB
79 { MACH_ARMEB, AUDIT_ARCH_ARMEB }
80 #endif
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (900, 'testing')
Architecture: armel (armv5tejl)
Kernel: Linux 3.4.0-rc7+
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages libaudit0 depends on:
ii libc6 2.13-32
libaudit0 recommends no packages.
libaudit0 suggests no packages.
-- no debconf information
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
