Bug#687022: lintian: regex error in dev-pkg-without-shlib-symlink

2013-06-11 Thread Andreas Metzler
On 2013-06-10 Jakub Wilk jw...@debian.org wrote:
[...]
 Example: If the library is installed in
 /lib/i386-linux-gnu/libXYZ.so.V, the symlink is expected at
 /usr/lib/i386-linux-gnu/libXYZ.so.

 The static library and the .so symlink are certainly never needed
 before /usr is mounted, so they should live in /usr/lib, not in
 /lib.

Hello,
I am pretty sure there was a very good reason for keeping everything
in /lib. Let's check...

I see:  It was the fact that there is no correct way to specify
library in /x .so in /y in the libtool .la file.
https://bugs.launchpad.net/ubuntu/+source/libgcrypt11/+bug/751142

This should not be an issue anymore, since we do not ship th la file
anymore. I'll try changing it.

Thanks for the explanation, cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#687022: lintian: regex error in dev-pkg-without-shlib-symlink

2013-06-10 Thread Jakub Wilk

* Andreas Metzler ametz...@downhill.at.eu.org, 2013-06-09, 08:54:

(SID)ametzler@argenau:/tmp/GCR/libgcrypt-1.5.2$ find debian/ -path debian/tmp -p
rune -or \( -name libgcrypt.so -or -name libgcrypt.so.11.8.1 \) -print
debian/libgcrypt11-udeb/lib/libgcrypt.so.11.8.1
debian/libgcrypt11/lib/i386-linux-gnu/libgcrypt.so.11.8.1
debian/libgcrypt11-dev/lib/i386-linux-gnu/libgcrypt.so
debian/libgcrypt11-dbg/usr/lib/debug/lib/libgcrypt.so.11.8.1
debian/libgcrypt11-dbg/usr/lib/debug/lib/i386-linux-gnu/libgcrypt.so.11.8.1

lintian seems to expect the .so symlink in /usr/lib although the 
library lives in /lib.


Indeed, but that's the documentation behavior. From the tag description:

The symlink is generally expected in the same directory as the library 
itself. The major exception to this rule is if the library is installed 
in (or beneath) /lib, where the symlink must be installed in the same 
dir beneath /usr.


Example: If the library is installed in /lib/i386-linux-gnu/libXYZ.so.V, 
the symlink is expected at /usr/lib/i386-linux-gnu/libXYZ.so.


The static library and the .so symlink are certainly never needed before 
/usr is mounted, so they should live in /usr/lib, not in /lib.


--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#687022: lintian: regex error in dev-pkg-without-shlib-symlink

2013-06-09 Thread Andreas Metzler
Version: 2.5.13

Hello,

libgcrypt11 also suffers from a false positive of the
dev-pkg-without-shlib-symlink test:

W: libgcrypt11: dev-pkg-without-shlib-symlink 
lib/i386-linux-gnu/libgcrypt.so.11.8.1 usr/lib/i386-linux-gnu/libgcrypt.so

(SID)ametzler@argenau:/tmp/GCR/libgcrypt-1.5.2$ find debian/ -path debian/tmp -p
rune -or \( -name libgcrypt.so -or -name libgcrypt.so.11.8.1 \) -print
debian/libgcrypt11-udeb/lib/libgcrypt.so.11.8.1
debian/libgcrypt11/lib/i386-linux-gnu/libgcrypt.so.11.8.1
debian/libgcrypt11-dev/lib/i386-linux-gnu/libgcrypt.so
debian/libgcrypt11-dbg/usr/lib/debug/lib/libgcrypt.so.11.8.1
debian/libgcrypt11-dbg/usr/lib/debug/lib/i386-linux-gnu/libgcrypt.so.11.8.1

lintian seems to expect the .so symlink in /usr/lib although the
library lives in /lib.

cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#687022: lintian: regex error in dev-pkg-without-shlib-symlink

2012-09-14 Thread Niels Thykier
On 2012-09-08 16:42, Leo 'costela' Antunes wrote:
 Package: lintian
 Version: 2.5.10.1
 Severity: normal
 Tags: patch
 
 Hi,
 

Hi,

 The attached patch fixes two small issues affecting the
 dev-pkg-without-shlib-symlink check:
 1) a missing '+' in the regex for libtool-style filenames

This appears to be right.

 2) the order of regex substitutions: the first one would never match since it 
 assumed the second had already been performed.
 
 Cheers
 
 [...]

But I am not certain about this part.  I believe it is intentional to do
it in that order based on:


Tag: package-name-doesnt-match-sonames
Severity: normal
Certainty: possible
Info: [...]
 .
  $ [...] sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; [...]
  ^ ^^


I believe that only one of them are supposed to match.

~Niels


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#687022: lintian: regex error in dev-pkg-without-shlib-symlink

2012-09-08 Thread Leo 'costela' Antunes
Package: lintian
Version: 2.5.10.1
Severity: normal
Tags: patch

Hi,

The attached patch fixes two small issues affecting the
dev-pkg-without-shlib-symlink check:
1) a missing '+' in the regex for libtool-style filenames
2) the order of regex substitutions: the first one would never match since it 
assumed the second had already been performed.

Cheers

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (100, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.4-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.22-7.1
ii  bzip2  1.0.6-4
ii  diffstat   1.55-3
ii  file   5.11-2
ii  gettext0.18.1.1-9
ii  hardening-includes 2.2
ii  intltool-debian0.35.0+20060710.1
ii  libapt-pkg-perl0.1.26+b1
ii  libarchive-zip-perl1.30-6
ii  libc-bin   2.13-35
ii  libclass-accessor-perl 0.34-1
ii  libclone-perl  0.31-1+b2
ii  libdigest-sha-perl 5.71-1
ii  libdpkg-perl   1.16.8
ii  libemail-valid-perl0.190-1
ii  libipc-run-perl0.92-1
ii  libparse-debianchangelog-perl  1.2.0-1
ii  libtimedate-perl   1.2000-1
ii  liburi-perl1.60-1
ii  locales2.13-35
ii  man-db 2.6.2-1
ii  patchutils 0.3.2-1.1
ii  perl [libdigest-sha-perl]  5.14.2-13

lintian recommends no packages.

Versions of packages lintian suggests:
ii  binutils-multiarch 2.22-7.1
ii  dpkg-dev   1.16.8
ii  libhtml-parser-perl3.69-2
pn  libperlio-gzip-perlnone
ii  libtext-template-perl  1.45-2
ii  lzma   9.22-2
ii  man-db 2.6.2-1
ii  xz-utils [lzma]5.1.1alpha+20120614-1

-- no debconf information
--- orig/checks/shared-libs 2012-09-08 16:34:47.0 +0200
+++ new/checks/shared-libs  2012-09-08 16:33:31.0 +0200
@@ -231,10 +231,10 @@
 }
 }

-# libtool -release variant
-$link_file =~ s/-[\d\.]\.so$/.so/o;
 # determine shlib link name (w/o version)
 $link_file =~ s/\.so.+$/.so/o;
+# libtool -release variant
+$link_file =~ s/-[\d\.]+\.so$/.so/o;

 # shlib symlink may not exist.
 # if shlib doesn't _have_ a version, then $link_file and $shlib_file will