Bug#687403: libio-async-loop-epoll-perl: FTBFS: test failed
Control: reassign -1 libio-async-perl Control: found -1 0.51-1 # we could also merge it with #680790 but meh. On Thu, 18 Oct 2012 10:48:37 +0200, gregor herrmann wrote: > > > Should this be "_CAN_SUBSECOND_ACCURATELY => 0" to turn it off unless > > > some loop test explicitly sets it? > > > > Ok, some investigation: > > The tests can either be skipped by > > - either setting _CAN_SUBSECOND_ACCURATELY to 0 in libio-async-perl > > - or in libio-async-loop-epoll-perl > > > > Both patches attached. > > Paul, did you have a change to look into this issue? > > (FWIW: My intuition is that setting _CAN_SUBSECOND_ACCURATELY to 0 as > the default would make sense.) In a quick chat on IRC Paul confirmed this -- thanks. Cheers, gregor, preparing an upload -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Paul Mc Cartney: However Absurd signature.asc Description: Digital signature
Bug#687403: libio-async-loop-epoll-perl: FTBFS: test failed
On Thu, 20 Sep 2012 21:08:33 +0200, gregor herrmann wrote:
> [ http://bugs.debian.org/687403 ]
>
> > From staring at the patch:
> >
> > http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/libio-async-perl.git;a=commitdiff;h=c9312eb
> >
> > ++# Some Loop implementations do not accurately handle sub-second timers.
> > ++# This only matters for unit tests
> > ++use constant _CAN_SUBSECOND_ACCURATELY => 1;
> >
> > ++ SKIP: {
> > ++ skip "Unable to handle sub-second timers accurately", 3 unless
> > $loop->_CAN_SUBSECOND_ACCURATELY;
> >
> >
> > Should this be "_CAN_SUBSECOND_ACCURATELY => 0" to turn it off unless
> > some loop test explicitly sets it?
>
> Ok, some investigation:
> The tests can either be skipped by
> - either setting _CAN_SUBSECOND_ACCURATELY to 0 in libio-async-perl
> - or in libio-async-loop-epoll-perl
>
> Both patches attached.
Paul, did you have a change to look into this issue?
(FWIW: My intuition is that setting _CAN_SUBSECOND_ACCURATELY to 0 as
the default would make sense.)
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- BOFH excuse #32: techtonic stress
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#687403: libio-async-loop-epoll-perl: FTBFS: test failed
On Wed, 12 Sep 2012 16:52:34 +0200, gregor herrmann wrote:
[ http://bugs.debian.org/687403 ]
> From staring at the patch:
>
> http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/libio-async-perl.git;a=commitdiff;h=c9312eb
>
> ++# Some Loop implementations do not accurately handle sub-second timers.
> ++# This only matters for unit tests
> ++use constant _CAN_SUBSECOND_ACCURATELY => 1;
>
> ++ SKIP: {
> ++ skip "Unable to handle sub-second timers accurately", 3 unless
> $loop->_CAN_SUBSECOND_ACCURATELY;
>
>
> Should this be "_CAN_SUBSECOND_ACCURATELY => 0" to turn it off unless
> some loop test explicitly sets it?
Ok, some investigation:
The tests can either be skipped by
- either setting _CAN_SUBSECOND_ACCURATELY to 0 in libio-async-perl
- or in libio-async-loop-epoll-perl
Both patches attached.
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Bettina Wegner: Über den Berg
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 000..8b3120d
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+subseconds.patch
diff --git a/debian/patches/subseconds.patch b/debian/patches/subseconds.patch
new file mode 100644
index 000..cb4f94b
--- /dev/null
+++ b/debian/patches/subseconds.patch
@@ -0,0 +1,11 @@
+--- a/lib/IO/Async/Loop/Epoll.pm
b/lib/IO/Async/Loop/Epoll.pm
+@@ -17,6 +17,8 @@
+ # doesn't harm anything to test specially.
+ use constant _CAN_ON_HANGUP => ( $^O eq "linux" );
+
++use constant _CAN_SUBSECOND_ACCURATELY => 0;
++
+ use base qw( IO::Async::Loop );
+
+ use Carp;
diff --git a/debian/patches/subsecond.patch b/debian/patches/subsecond.patch
index a80d8ce..7307821 100644
--- a/debian/patches/subsecond.patch
+++ b/debian/patches/subsecond.patch
@@ -24,7 +24,7 @@ Subject: Allow Loops to declare for unit-test purposes that they can't
+# Some Loop implementations do not accurately handle sub-second timers.
+# This only matters for unit tests
-+use constant _CAN_SUBSECOND_ACCURATELY => 1;
++use constant _CAN_SUBSECOND_ACCURATELY => 0;
+
use Carp;
signature.asc
Description: Digital signature
Bug#687403: libio-async-loop-epoll-perl: FTBFS: test failed
On Wed, 12 Sep 2012 16:03:18 +0200, gregor herrmann wrote:
> [ http://bugs.debian.org/687403 ]
> [0] from CPAN RT#78892:
> "If you update libio-async-perl to 0.52, you should find that the
> Epoll loop now skips those tests, because it doesn't declare
> _CAN_SUBSECOND_ACCURATELY."
> (And the patch in 0.51-3 backports this 0.52 change.)
From staring at the patch:
http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/libio-async-perl.git;a=commitdiff;h=c9312eb
++# Some Loop implementations do not accurately handle sub-second timers.
++# This only matters for unit tests
++use constant _CAN_SUBSECOND_ACCURATELY => 1;
++ SKIP: {
++ skip "Unable to handle sub-second timers accurately", 3 unless
$loop->_CAN_SUBSECOND_ACCURATELY;
Should this be "_CAN_SUBSECOND_ACCURATELY => 0" to turn it off unless
some loop test explicitly sets it?
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Don McLean: Aftermath
signature.asc
Description: Digital signature
Bug#687403: libio-async-loop-epoll-perl: FTBFS: test failed
On Wed, 12 Sep 2012 16:03:18 +0200, gregor herrmann wrote: > "If you update libio-async-perl to 0.52, you should find that the > Epoll loop now skips those tests, because it doesn't declare > _CAN_SUBSECOND_ACCURATELY." > (And the patch in 0.51-3 backports this 0.52 change.) Which I just confirmed by grepping through the libio-async-loop-epoll-perl 0.12-1 source package in the archive ... Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Rolling Stones: Paint It Black signature.asc Description: Digital signature
Bug#687403: libio-async-loop-epoll-perl: FTBFS: test failed
On Wed, 12 Sep 2012 15:14:31 +0200, Lucas Nussbaum wrote: [ http://bugs.debian.org/687403 ] > [ It seems that the fix for #680790 was not applied to > libio-async-loop-epoll-perl ? Or is it only because the fixed > libio-async-perl did not reach testing? ] Hm. Mysterious. My understanding of #680790 and the referenced upstream bug http://rt.cpan.org/Public/Bug/Display.html?id=78892 is that this was a problem in libio-async-perl, and libio-async-perl 0.51-3 with the upstream patch is in testing (and is used by your build as seen in the log). And I just verified that the patch _is_ in the package in the archive. [0] *sigh* Cheers, gregor, cc'ing upstream ... [0] from CPAN RT#78892: "If you update libio-async-perl to 0.52, you should find that the Epoll loop now skips those tests, because it doesn't declare _CAN_SUBSECOND_ACCURATELY." (And the patch in 0.51-3 backports this 0.52 change.) -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- BOFH excuse #90: Budget cuts -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#687403: libio-async-loop-epoll-perl: FTBFS: test failed
Source: libio-async-loop-epoll-perl Version: 0.12-1 Severity: serious Tags: wheezy sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20120912 qa-ftbfs Justification: FTBFS in wheezy on amd64 Hi, [ It seems that the fix for #680790 was not applied to libio-async-loop-epoll-perl ? Or is it only because the fixed libio-async-perl did not reach testing? ] During a rebuild of all packages in *wheezy*, your package failed to build on amd64. Relevant part: > debian/rules build > dh build >dh_testdir >dh_auto_configure > Created MYMETA.yml and MYMETA.json > Creating new 'Build' script for 'IO-Async-Loop-Epoll' version '0.12' >dh_auto_build > Building IO-Async-Loop-Epoll >dh_auto_test > t/00use.t ... ok > t/01loop-io.t ... ok > > # Failed test 'One ->loop_once(1) sufficient for a single 0.1 second timer' > # at /usr/share/perl5/IO/Async/LoopTests.pm line 484. > # got: '2' > # expected: '1' > # Looks like you failed 1 test of 26. > t/02loop-timer.t > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/26 subtests > t/03loop-signal.t ... ok > t/04loop-idle.t . ok > t/05loop-child.t ok > t/06loop-control.t .. ok > t/99pod.t ... ok > > Test Summary Report > --- > t/02loop-timer.t (Wstat: 256 Tests: 26 Failed: 1) > Failed test: 20 > Non-zero exit status: 1 > Files=8, Tests=105, 16 wallclock secs ( 0.06 usr 0.04 sys + 0.51 cusr 0.15 > csys = 0.76 CPU) > Result: FAIL > Failed 1/8 test programs. 1/105 subtests failed. > dh_auto_test: perl Build test returned exit code 255 > make: *** [build] Error 255 The full build log is available from: http://people.debian.org/~lucas/logs/2012/09/12/libio-async-loop-epoll-perl_0.12-1_wheezy.log A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on EC2 VM instances from Amazon Web Services, using a clean, minimal and up-to-date chroot. Every failed build was retried once to eliminate random failures. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
