Bug#687406: jscribble: FTBFS: junit fails
On Fri, 21 Sep 2012 10:24:26 +0900, Hideki Yamane wrote: A nicer alternative would be to run the tests under xvfb. ! Yes, that's true. I didn't notice it... And your patch seems to be good. Great thanks to you, gregor. Thanks for the confirmation! I've now uploaded Andrew's version of the patch (which has a nicer changelog entry than mine) to DELAYED/2. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: The Beatles: A Day In The Life signature.asc Description: Digital signature
Bug#687406: jscribble: FTBFS: junit fails
On Thu, 20 Sep 2012 05:58:52 +0900, Hideki Yamane wrote: I've investigate this issue, and root cause is failure with access to X11 server as below. Agreed. 1) testAutomaticSaveOnPageFlipForward(tests.jscribble.notebook.NoteBookTest)java.lang.InternalError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable. So I just disabled its test by attached patch. Please consider if you apply the patch or not. A nicer alternative would be to run the tests under xvfb. Cf. the attached patch which works for me. Could you also try it please? Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Dido: Here With Me diff -Nru jscribble-1.7.7/debian/changelog jscribble-1.7.7/debian/changelog --- jscribble-1.7.7/debian/changelog 2012-04-21 21:17:06.0 +0200 +++ jscribble-1.7.7/debian/changelog 2012-09-20 21:29:41.0 +0200 @@ -1,3 +1,11 @@ +jscribble (1.7.7-1.1) UNRELEASED; urgency=low + + * Non-maintainer upload. + * Fix FTBFS: junit fails: run tests under xvfb. +(Closes: #687406) + + -- gregor herrmann gre...@debian.org Thu, 20 Sep 2012 21:26:03 +0200 + jscribble (1.7.7-1) unstable; urgency=high [ Martin Ueding ] diff -Nru jscribble-1.7.7/debian/control jscribble-1.7.7/debian/control --- jscribble-1.7.7/debian/control 2012-04-21 13:31:04.0 +0200 +++ jscribble-1.7.7/debian/control 2012-09-20 21:27:59.0 +0200 @@ -2,7 +2,7 @@ Section: utils Priority: extra Maintainer: Martin Ueding d...@martin-ueding.de -Build-Depends: debhelper (= 8), default-jdk (= 1:1.6), junit (= 3), php5-cli, python-docutils +Build-Depends: debhelper (= 8), default-jdk (= 1:1.6), junit (= 3), php5-cli, python-docutils, xvfb, xauth Standards-Version: 3.9.3 Homepage: http://martin-ueding.de/jscribble/ diff -Nru jscribble-1.7.7/debian/rules jscribble-1.7.7/debian/rules --- jscribble-1.7.7/debian/rules 2011-11-27 14:13:56.0 +0100 +++ jscribble-1.7.7/debian/rules 2012-09-20 21:28:24.0 +0200 @@ -3,3 +3,6 @@ %: dh $@ + +override_dh_auto_test: + xvfb-run -a dh_auto_test signature.asc Description: Digital signature
Bug#687406: jscribble: FTBFS: junit fails
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi all, Rather than disabling the tests completely, I think it would be better to instead to use xvfb-run. The attached patch does so. I can confirm that it allows the tests to complete successfully when building the package inside a clean sid pbuilder. Let me know if you have any objections. Unless you do, I'll be seeking sponsorship for a NMU as this is an RC bug. Thanks! - - Andrew Starr-Bochicchio -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJQW3JSAAoJEDtW4rvVP9yxgfEP/2+3y2rE4mjzYGCxmyrMyK4s qFvXsG6xydOjzc5S9BGpHPLN2j6k8RTAQ67VCQ+B5LHd3L/IQXnnrx/i5AxYUKqY dAZlMKL+vZ67lNHmxThrLKuMGOS2D+hh0DDtyYERgEyb1JzQt3EqvnIaGlzHEu8h 37WXigBBlisvCwouBJ6NVmY60Z4KO7ocsxSKO6N+8pkEFPcpDjYXvXNsTft+JmtN sd5zUjgpU9ZsIH31JgQDK2oeKWnxgpyNvsBcczBCW08CiEyPxi3v6WceUf2jp4yx yMP8vnh+e7HOZu/wJiSSRi1QYHT6eHsypi0+R30274psidJBe8L18VNXuQY3eSao lwb1BQtNH8opc+dptSxF3e63aAzCTByAPDraroCcUBhQTd8Gx+SdI+/hXgGGMQSA 9WU97XGpHC3eTIh0Nj3TimJRCzaVr6V5mJWBuRd0rnMrRISv2K8zLyF/Ji77qBOY sZzo7bOYjmXy098chC9RkZFl2/wJ2NfTFBm4MVR6bK6NBdK5koLvVVyeKPONgnVX ee7qnFKcKYtdJCfKrCNttLG1Q6V52XKu9z+xd6s5OBp6FnzxcrjD4x22bQ7EjNpJ ufQ4wI+Lju8HOH8UTa2nW/JazdgmTb8NUA4+Jhs3JGK8uKsiHUxKZtBCk/q7QJC/ oxAJdM4gvNtwn/GcSWGn =4ckR -END PGP SIGNATURE- diff -Nru jscribble-1.7.7/debian/changelog jscribble-1.7.7/debian/changelog --- jscribble-1.7.7/debian/changelog2012-04-21 15:17:06.0 -0400 +++ jscribble-1.7.7/debian/changelog2012-09-20 15:10:17.0 -0400 @@ -1,3 +1,12 @@ +jscribble (1.7.7-1.1) UNRELEASED; urgency=low + + * Non-maintainer upload. + * debian/rules: Tests require an X server so call them +with xvfb-run. (Closes: #687406) + * debian/control: Build depend on xauth and xvfb. + + -- Andrew Starr-Bochicchio a.star...@gmail.com Thu, 20 Sep 2012 15:08:02 -0400 + jscribble (1.7.7-1) unstable; urgency=high [ Martin Ueding ] diff -Nru jscribble-1.7.7/debian/control jscribble-1.7.7/debian/control --- jscribble-1.7.7/debian/control 2012-04-21 07:31:04.0 -0400 +++ jscribble-1.7.7/debian/control 2012-09-20 15:07:42.0 -0400 @@ -2,7 +2,7 @@ Section: utils Priority: extra Maintainer: Martin Ueding d...@martin-ueding.de -Build-Depends: debhelper (= 8), default-jdk (= 1:1.6), junit (= 3), php5-cli, python-docutils +Build-Depends: debhelper (= 8), default-jdk (= 1:1.6), junit (= 3), php5-cli, python-docutils, xauth, xvfb Standards-Version: 3.9.3 Homepage: http://martin-ueding.de/jscribble/ diff -Nru jscribble-1.7.7/debian/rules jscribble-1.7.7/debian/rules --- jscribble-1.7.7/debian/rules2011-11-27 08:13:56.0 -0500 +++ jscribble-1.7.7/debian/rules2012-09-20 15:28:06.0 -0400 @@ -3,3 +3,6 @@ %: dh $@ + +override_dh_auto_test: + xvfb-run -a dh_auto_test
Bug#687406: jscribble: FTBFS: junit fails
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 A nicer alternative would be to run the tests under xvfb. Cf. the attached patch which works for me. Could you also try it please? Hi gregor, Looks like we were working on this at the same time. Except for the changelog entry, our patches are identical. So I can confirm that your patch also resolves the issue. =) Thanks! - - Andrew Starr-Bochicchio -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJQW3RxAAoJEDtW4rvVP9yxhF8P/0lwuSjErq5rD7LYvpD0Wpiy 5aUcyT/D1DU1rUK3b+0O37z4KEpJSE9mnIdSetf6gn1h2rUfsomUE+2DGuzratKP 5NJryTc0Za63KWE9oYBHf0OxSU96Sgq+v5nc8S77oGWJZ3oSTrihGRC3dHOfmNcQ OrY8hcDPsJOY2towpxN8LQ9RezCHju7otOP/EtZ4P8mRWIR9sR7jwghk0pXQ/3RE yTs+6n7PiabIUCzXvu8A7F9vc5q/LwCCna12yfFeSL/OUksBxqiorFNfHWBdw5mY xZ3iv++Y/kM+ru0nPvlzvO5lPc1r0+NeKZn4ECqSyIXCNnco0NpAHSdqpMMMn2PW ElvFOv4BzQ9QlA4pA0PQiOmLUasmmLYOu3QwCZ71Oby0fZbyZbnLe5wBAa/yF9H2 4E3cglBezRve1OGYMgfoAujOQ/PEPpLo8GgXcSpsUMQWJ3FvY12jr6K6MvGMPEhb auP2LTnfrxdDFyHBVwNp1+Lu5XFh1vTNALo1uXIGI/uWqjMPwFHzfg6DbLpU4G8+ 6H/yKpCT+4AHzw1c8uusQuJVDbyPdRdAJzapK3SKuLqLKCLrgnBCEvmQNLGcArer aWYXXVXHhQqv4X1LBq3Qgrt/AChI1Yu/hxahtDEi7GSlBa9nCq98X+NE8S8vcT25 MXvIlkkYioP0v1P+CXr8 =f4q7 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687406: jscribble: FTBFS: junit fails
On Thu, 20 Sep 2012 15:54:27 -0400, Andrew Starr-Bochicchio wrote: A nicer alternative would be to run the tests under xvfb. Cf. the attached patch which works for me. Could you also try it please? Looks like we were working on this at the same time. Except for the changelog entry, our patches are identical. Right, your mail just made me smile because of the identical patch :) So I can confirm that your patch also resolves the issue. =) Thanks, good to know that we see the same results! Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Alannah Myles signature.asc Description: Digital signature
Bug#687406: jscribble: FTBFS: junit fails
On Thu, 20 Sep 2012 21:32:19 +0200 gregor herrmann gre...@debian.org wrote: A nicer alternative would be to run the tests under xvfb. ! Yes, that's true. I didn't notice it... And your patch seems to be good. Great thanks to you, gregor. -- Regards, Hideki Yamane henrich @ debian.or.jp/org http://wiki.debian.org/HidekiYamane -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687406: jscribble: FTBFS: junit fails
tags 687406 patch thanks Hi, I've investigate this issue, and root cause is failure with access to X11 server as below. 1) testAutomaticSaveOnPageFlipForward(tests.jscribble.notebook.NoteBookTest)java.lang.InternalError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable. So I just disabled its test by attached patch. Please consider if you apply the patch or not. Thanks. -- Regards, Hideki Yamane henrich @ debian.or.jp/org http://wiki.debian.org/HidekiYamane diff -Nru jscribble-1.7.7/debian/changelog jscribble-1.7.7/debian/changelog --- jscribble-1.7.7/debian/changelog 2012-04-22 04:17:06.0 +0900 +++ jscribble-1.7.7/debian/changelog 2012-09-20 05:48:24.0 +0900 @@ -1,3 +1,12 @@ +jscribble (1.7.7-1.1) UNRELEASED; urgency=low + + * Non-maintainer upload. + * debian/patches +- add disable-NoteBookTest.java, disabling test cases to avoid test + failure with X connection from chroot (Closes: #687406) + + -- Hideki Yamane henr...@debian.org Thu, 20 Sep 2012 05:41:08 +0900 + jscribble (1.7.7-1) unstable; urgency=high [ Martin Ueding ] diff -Nru jscribble-1.7.7/debian/patches/disable-NoteBookTest.java jscribble-1.7.7/debian/patches/disable-NoteBookTest.java --- jscribble-1.7.7/debian/patches/disable-NoteBookTest.java 1970-01-01 09:00:00.0 +0900 +++ jscribble-1.7.7/debian/patches/disable-NoteBookTest.java 2012-09-20 05:41:02.0 +0900 @@ -0,0 +1,23 @@ +Description: disable test since cannot connect to X from chroot + +Author: Hideki Yamane henr...@debian.org +Bug-Debian: 687406 + +--- +Origin: vendor +Bug-Debian: http://bugs.debian.org/687406 +Forwarded: not-needed +Last-Update: 20120920 + +--- jscribble-1.7.7.orig/tests/JscribbleTestSuite.java jscribble-1.7.7/tests/JscribbleTestSuite.java +@@ -25,7 +25,8 @@ import tests.jscribble.VersionNameTest; + import tests.jscribble.drawPanel.HelpItemTest; + import tests.jscribble.helpers.FileComparatorTest; + import tests.jscribble.notebook.NoteBookCompressorTest; +-import tests.jscribble.notebook.NoteBookTest; ++//TODO disable since cannot connect to X from chroot ++//import tests.jscribble.notebook.NoteBookTest; + import tests.jscribble.notebook.NoteSheetFileFilterTest; + import tests.jscribble.notebook.NoteSheetTest; + import tests.jscribble.notebook.WriteoutThreadTest; diff -Nru jscribble-1.7.7/debian/patches/series jscribble-1.7.7/debian/patches/series --- jscribble-1.7.7/debian/patches/series 1970-01-01 09:00:00.0 +0900 +++ jscribble-1.7.7/debian/patches/series 2012-09-20 05:39:06.0 +0900 @@ -0,0 +1 @@ +disable-NoteBookTest.java
Bug#687406: jscribble: FTBFS: junit fails
Source: jscribble Version: 1.7.7-1 Severity: serious Tags: wheezy sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20120912 qa-ftbfs Justification: FTBFS in wheezy on amd64 Hi, During a rebuild of all packages in *wheezy*, your package failed to build on amd64. Relevant part: make[1]: Entering directory `/«PKGBUILDDIR»' javac -encoding UTF-8 -classpath /usr/share/java/junit.jar -sourcepath .:jscribble tests/jscribble/notebook/WriteoutThreadTest.java javac -encoding UTF-8 -classpath /usr/share/java/junit.jar -sourcepath .:jscribble tests/jscribble/notebook/NoteSheetTest.java javac -encoding UTF-8 -classpath /usr/share/java/junit.jar -sourcepath .:jscribble tests/jscribble/notebook/NoteSheetFileFilterTest.java javac -encoding UTF-8 -classpath /usr/share/java/junit.jar -sourcepath .:jscribble tests/jscribble/notebook/NoteBookTest.java javac -encoding UTF-8 -classpath /usr/share/java/junit.jar -sourcepath .:jscribble tests/jscribble/notebook/NoteBookCompressorTest.java javac -encoding UTF-8 -classpath /usr/share/java/junit.jar -sourcepath .:jscribble tests/jscribble/helpers/FileComparatorTest.java javac -encoding UTF-8 -classpath /usr/share/java/junit.jar -sourcepath .:jscribble tests/jscribble/drawPanel/HelpItemTest.java javac -encoding UTF-8 -classpath /usr/share/java/junit.jar -sourcepath .:jscribble tests/jscribble/VersionNameTest.java javac -encoding UTF-8 -classpath /usr/share/java/junit.jar -sourcepath .:jscribble tests/JscribbleTestSuite.java junit -text tests.JscribbleTestSuite make[1]: *** [test] Error 1 The full build log is available from: http://people.debian.org/~lucas/logs/2012/09/12/jscribble_1.7.7-1_wheezy.log A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on EC2 VM instances from Amazon Web Services, using a clean, minimal and up-to-date chroot. Every failed build was retried once to eliminate random failures. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
