Bug#687848: Currently, only the symlink is removed

2012-12-07 Thread Ivo De Decker 
On Wed, Dec 05, 2012 at 07:23:51AM +0100, Daniel Baumann wrote:
 On 12/04/2012 07:57 PM, Ivo De Decker wrote:
 Daniel, will you fix this bug in sid and (via t-p-u) in wheezy, or do you 
 want
 someone else to do an NMU?

Daniel,

Thanks for the fix in sid. I filed a pre-approval request for wheezy (#695343)
and I will do the t-p-u NMU when I get the approval of the release team.

Cheers,

Ivo


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#687848: Currently, only the symlink is removed

2012-12-04 Thread Ivo De Decker 
Hi,

On Wed, Sep 26, 2012 at 11:51:55PM +0200, Mika Pflüger wrote:
 Steps to reproduce:
 1. Fresh wheezy install
 2. apt-get install extlinux
 3. extlinux-update  extlinux-install first-hd
 (4. try reboot: doesn't boot; redo 1.-3. to get working setup again)
 5. add unstable to sources.list and apt-get -t unstable install
 syslinux-themes-debian-wheezy or just download the most recent
 syslinux-themes-debian-wheezy_*.deb from an unstable mirror of your
 choice and dpkg -i it
 6. extlinux-update
 7. try reboot: doesn't boot.

This problem can be reproduced easily with these steps. The problem should go
away for fresh installs if syslinux-themes-debian-wheezy migrates to testing,
but it will still be there for older installs.

 I don't know if my proposed patch is a very elegant solution (I
 actually suspect it's not), but I tested that it solves the problem.

Removing the directories first isn't very elegant. The following patch shoud
fix the problem by forcing cp to use the right path (adding the -T option):

--- a/debian/local/extlinux-update
+++ b/debian/local/extlinux-update
@@ -403,10 +403,10 @@ then
 
if [ -n ${EXTLINUX_THEME_ORIG} ]
then
-   cp -aL 
/usr/share/syslinux/themes/${EXTLINUX_THEME_ORIG}/extlinux 
${_EXTLINUX_DIRECTORY}/themes/${EXTLINUX_THEME_ORIG}
+   cp -aLT 
/usr/share/syslinux/themes/${EXTLINUX_THEME_ORIG}/extlinux 
${_EXTLINUX_DIRECTORY}/themes/${EXTLINUX_THEME_ORIG}
ln -sf ${EXTLINUX_THEME_ORIG} 
${_EXTLINUX_DIRECTORY}/themes/${EXTLINUX_THEME}
else
-   cp -aL 
/usr/share/syslinux/themes/${EXTLINUX_THEME}/extlinux 
${_EXTLINUX_DIRECTORY}/themes/${EXTLINUX_THEME}
+   cp -aLT 
/usr/share/syslinux/themes/${EXTLINUX_THEME}/extlinux 
${_EXTLINUX_DIRECTORY}/themes/${EXTLINUX_THEME}
fi
 
echo  done.


Unfortunately, there is a newer version of syslinux in sid, which will
probably not be unblocked for wheezy, so a fix via testing-proposed-updates
might be necessary.

Daniel, will you fix this bug in sid and (via t-p-u) in wheezy, or do you want
someone else to do an NMU?


Cheers,

Ivo


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#687848: Currently, only the symlink is removed

2012-12-04 Thread Mika Pflüger 
Hi,

Am Tue, 4 Dec 2012 19:57:46 +0100
schrieb Ivo De Decker ivo.dedec...@ugent.be:
 On Wed, Sep 26, 2012 at 11:51:55PM +0200, Mika Pflüger wrote:
  Steps to reproduce:
  1. Fresh wheezy install
  2. apt-get install extlinux
  3. extlinux-update  extlinux-install first-hd
  (4. try reboot: doesn't boot; redo 1.-3. to get working setup again)
  5. add unstable to sources.list and apt-get -t unstable install
  syslinux-themes-debian-wheezy or just download the most recent
  syslinux-themes-debian-wheezy_*.deb from an unstable mirror of your
  choice and dpkg -i it
  6. extlinux-update
  7. try reboot: doesn't boot.
 
 This problem can be reproduced easily with these steps. The problem
 should go away for fresh installs if syslinux-themes-debian-wheezy
 migrates to testing, but it will still be there for older installs.

You are right, now it is not easily reproducible anymore - it probably
is only a problem right now for old installs. And of course it will
again be a problem if syslinux-themes-debian-wheezy has to be fixed for
another problem (if ever).
 
  I don't know if my proposed patch is a very elegant solution (I
  actually suspect it's not), but I tested that it solves the problem.
 
 Removing the directories first isn't very elegant. The following
 patch shoud fix the problem by forcing cp to use the right path
 (adding the -T option):

Yes, that is a much more elegant solution! Thanks a lot for finding the
needed cp option I did not find!

Cheers,

Mika


-- 



signature.asc
Description: PGP signature

Bug#687848: Currently, only the symlink is removed

2012-12-04 Thread Ivo De Decker 
Hi,

On Tue, Dec 04, 2012 at 09:44:01PM +0100, Mika Pflüger wrote:
  This problem can be reproduced easily with these steps. The problem
  should go away for fresh installs if syslinux-themes-debian-wheezy
  migrates to testing, but it will still be there for older installs.
 
 You are right, now it is not easily reproducible anymore - it probably
 is only a problem right now for old installs. And of course it will
 again be a problem if syslinux-themes-debian-wheezy has to be fixed for
 another problem (if ever).

Just to be clear:

The problem is not solved by the version of syslinux-themes-debian-wheezy
currently in wheezy. The fix from unstable didn't migrate (yet, see #688485).
So 'older installs' includes all installs that happen now and in the near
future (until the fix migrates).

Cheers,

Ivo


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#687848: Currently, only the symlink is removed

2012-12-04 Thread Daniel Baumann 

On 12/04/2012 07:57 PM, Ivo De Decker wrote:

Daniel, will you fix this bug in sid and (via t-p-u) in wheezy, or do you want
someone else to do an NMU?


i'll do the one in sid.

--
Address:Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern
Email:  daniel.baum...@progress-technologies.net
Internet:   http://people.progress-technologies.net/~daniel.baumann/


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#687848: Currently, only the symlink is removed

2012-09-26 Thread Mika Pflüger 
reopen 687848
thanks

Hi,

Looking at the code and especially the rm -rf you are referring to, I
see that only the symlink is removed:
Layout before:
/boot/extlinux/themes/debian - debian-wheezy
/boot/extlinux/themes/debian-wheezy: the old theme
the extlinux configuration has the standard values, namely:
/etc/default/extlinux: EXTLINUX_THEME=debian.

So the rm -rf ${_EXTLINUX_DIRECTORY}/themes/${EXTLINUX_THEME}
deletes /boot/extlinux/themes/debian, which is only the symlink. Then
EXTLINUX_THEME_ORIG is populated and the subsequent cp -al (and
regeneration of the symlink) leads to this layout:
/boot/extlinux/themes/debian - debian-wheezy
/boot/extlinux/themes/debian-wheezy: the old theme
/boot/extlinux/themes/debian-wheezy/extlinux: the new theme.

Of course, only the old theme is found when booting, leading to no boot
at all.

Steps to reproduce:
1. Fresh wheezy install
2. apt-get install extlinux
3. extlinux-update  extlinux-install first-hd
(4. try reboot: doesn't boot; redo 1.-3. to get working setup again)
5. add unstable to sources.list and apt-get -t unstable install
syslinux-themes-debian-wheezy or just download the most recent
syslinux-themes-debian-wheezy_*.deb from an unstable mirror of your
choice and dpkg -i it
6. extlinux-update
7. try reboot: doesn't boot.

Note this is completely standard behaviour for anyone actually
installing extlinux in a wheezy right now and following the
README.Debian, finding it doesn't work, switching back to grub, waiting
for the fixes in syslinux-themes-debian hitting testing or installing
it from unstable, and trying again.

I don't know if my proposed patch is a very elegant solution (I
actually suspect it's not), but I tested that it solves the problem.


Cheers,

Mika


-- 
Own your own computer. Don't use Windows 7. http://windows7sins.org


signature.asc
Description: PGP signature