Bug#688259: zangband: modifies shipped files during postinst
Hi, Currently zangband is considered an RC-buggy leaf package[0] and will eventually be removed from testing unless this RC bug is dealt with (fixed, downgraded etc.). Mind you, the deadline listed in [0] is in the past. If I hadn't by chance noticed Drew's mail claiming he would upload a patch, zangband would have been removed like 21 other packages. Drew, if you still intend to upload a fix for this bug, please do it sooner rather than later. Otherwise, consider asking someone to NMU/fix this package for you. ~Niels [0] https://lists.debian.org/debian-devel/2012/10/msg00373.html -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#688259: zangband: modifies shipped files during postinst
On Tue, 2012-11-06 at 19:54 +0100, Niels Thykier wrote: Drew, if you still intend to upload a fix for this bug, please do it sooner rather than later. Otherwise, consider asking someone to NMU/fix this package for you. Uploaded. Thanks for your patience. Markus, I left some hardening lintian warnings for you :) Rewriting a completely new debian/rules to use dh is possibly the simplest way to fix it. With the file permissions lintian warning, I understand the one zangband uses is desirable for sharing high scores among multiple players, but I haven't checked thoroughly. Drew -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#688259: zangband: modifies shipped files during postinst
tags 688259 patch
thanks
Hi Drew and Andreas,
i had a look at the issue and prepared a patch for it. As far as i can
see changing the path for $static_vardir to
/usr/share/games/zangband/lib is sufficient to avoid the deletion of raw
files in /var/games/zangband/data. Running piuparts afterwards was
successful. The wrong path in zangband.postinst
caused the for loop to touch only one file, *.raw.
I'm not sure whether the postinst script is still necessary nowadays. It
seems it's some kind of remnant from the past. It might be too late for
Wheezy but maybe we could drop it for Jessie completely. The make file in
/lib/data seems to take care of installing the raw files anyway.
Overwriting of the score file seems suspicious too, but i don't know
enough about zangband to assess the issue properly.
Drew, if you are still interested in having a co-maintainer, i can prepare a
new version for zangband and fix some lintian warnings.
Regards,
Markus
diff -u zangband-2.7.5pre1/debian/changelog zangband-2.7.5pre1/debian/changelog
--- zangband-2.7.5pre1/debian/changelog
+++ zangband-2.7.5pre1/debian/changelog
@@ -1,3 +1,11 @@
+zangband (1:2.7.5pre1-4.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Fix wrong $static_datadir path in zangband.postinst file to avoid
+deletion of *.raw files in /var/games/zangband/data. (Closes: #688259)
+
+ -- Markus Koschany a...@gambaru.de Tue, 23 Oct 2012 15:04:05 +0200
+
zangband (1:2.7.5pre1-4) unstable; urgency=low
* libgtk1 is no longer welcome in Debian. zangband's gtk shell was
diff -u zangband-2.7.5pre1/debian/zangband.postinst
zangband-2.7.5pre1/debian/zangband.postinst
--- zangband-2.7.5pre1/debian/zangband.postinst
+++ zangband-2.7.5pre1/debian/zangband.postinst
@@ -5,7 +5,7 @@
old_var_games=/var/lib/games
old_var_datadir=/var/lib/games/zangband
var_datadir=/var/games/zangband
-static_datadir=/usr/share/games/zangband
+static_datadir=/usr/share/games/zangband/lib
notmovingoldfiles=WARNING: $old_var_datadir is a symlink.
Not moving files to new location. Please fix manually.
@@ -13,7 +13,7 @@
regenerated automatically in their new location.)
movingoldfiles=WARNING: Old zangband data files exist.
-Moving save, bones, and score files to $new_var_datadir.
+Moving save, bones, and score files to $var_datadir.
Existing files will be backed up before overwriting.
fixperms () {
signature.asc
Description: Digital signature
Bug#688259: zangband: modifies shipped files during postinst
On Tue, 2012-10-23 at 17:13 +0200, Markus Koschany wrote: i had a look at the issue and prepared a patch for it. Thanks Markus, I'll try to check it and upload this week. Drew, if you are still interested in having a co-maintainer, i can prepare a new version for zangband and fix some lintian warnings. That'd be great Markus. Wait till I upload your patch, then you can work from the new version. Drew -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#688259: zangband: modifies shipped files during postinst, overwrites score file on upgrade
Package: zangband Version: 1:2.7.5pre1-4 Severity: serious User: debian...@lists.debian.org Usertags: piuparts Hi, during a test with piuparts I noticed your package modifies some of teh files it ships. debsums reports modification of the following files, from the attached log (scroll to the bottom...): debsums: missing file /var/games/zangband/data/misc.raw (from zangband package) debsums: missing file /var/games/zangband/data/k_info.raw (from zangband package) debsums: missing file /var/games/zangband/data/v_info.raw (from zangband package) debsums: missing file /var/games/zangband/data/f_info.raw (from zangband package) debsums: missing file /var/games/zangband/data/e_info.raw (from zangband package) debsums: missing file /var/games/zangband/data/r_info.raw (from zangband package) debsums: missing file /var/games/zangband/data/a_info.raw (from zangband package) There is no need to ship these files if they get reinitialized in the postinst script anyway. Looking at the postinst and the file list in more detail, I also noticed that the score file is overwritten with an empty file on every upgrade/reinstallation. Also static_datadir is set wrongly to /usr/share/games/zangband which makes the postinst not do its job properly (it just touches a file called '*.raw' - yes, an asterisk in the filename). Probably static_datadir=/usr/share/games/zangband/lib would be correct. cheers, Andreas zangband_1:2.7.5pre1-4.log.gz Description: GNU Zip compressed data
Bug#688259: zangband: modifies shipped files during postinst, overwrites score file on upgrade
On Thu, 2012-09-20 at 21:09 +0200, Andreas Beckmann wrote: during a test with piuparts I noticed your package modifies some of teh files it ships. ... There is no need to ship these files if they get reinitialized in the postinst script anyway. Looking at the postinst and the file list in more detail, I also noticed that the score file is overwritten with an empty file on every upgrade/reinstallation. Thanks for the report, Andreas. Hopefully won't be too tricky to sort out. Patches or comaintainers are welcome! Drew -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
