Bug#690847: poppler.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
hi pino,
thanks for your answer.
On 10/18/2012 04:36 PM, Pino Toscano wrote:
debuild -uc -us handled correctly my patches.
but dpkg-source also created a patch of the Makefile.in and
configure file.
importing this patch does help.
i've fixed and improved some issues related to rtl support. other on
the way.
maybe, but then they are being deleted in the debuild process.
right, although upstream like the patches, they will be applied to
their unstable tip.
untill that tip will be stable, i'll submit them on debian too.
for now, just for the test, you may take my patches, add them to
series etc theb debuild.
this will work only once.
- -- best regards, alex
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/
iJwEAQECAAYFAlC48DgACgkQ2nA3WyrfyePG7QP/egBl6Susri41qIQBHsPhPTJA
9txkKWUS5eVHgTpZGvxN1J1QIjDydxuYNJ5ooG5KX8+YHc6hJ9Gj0/xyM7oChFNp
O7K9pTbKan5nXh605R4LTry1kOwrJsLe5sjtxo3APj1Y+258tMTogO1xGRMmciYA
NSmYphgwWKG3A7M9Oo4=
=qJ4J
-END PGP SIGNATURE-
Index: poppler-0.20.5/CMakeLists.txt
===
--- poppler-0.20.5.orig/CMakeLists.txt 2012-10-18 01:53:13.0 +0200
+++ poppler-0.20.5/CMakeLists.txt 2012-10-18 01:53:53.0 +0200
@@ -30,6 +30,8 @@
option(ENABLE_LIBOPENJPEG Use libopenjpeg for JPX streams. ON)
option(ENABLE_LCMS Use liblcms for color management. ON)
option(ENABLE_LIBCURL Build libcurl based HTTP support. OFF)
+option(ENABLE_ICU Build with ICU. ON)
+option(ENABLE_FRIBIDI Build with FRIBIDI. ON)
option(ENABLE_ZLIB Build with zlib (not totally safe). OFF)
option(USE_FIXEDPOINT Use fixed point arithmetic in the Splash backend OFF)
option(USE_FLOAT Use single precision arithmetic in the Splash backend OFF)
@@ -124,6 +126,21 @@
set(ENABLE_CPP ${ICONV_FOUND})
set(HAVE_ICONV ${ICONV_FOUND})
endif(ENABLE_CPP)
+
+# well i don't know what to do here.
+# fribidi should be enabled if icu can't be.
+# the modules are there.
+if(ENABLE_ICU)
+ macro_optional_find_package(ICU)
+ set(ENABLE_ICU ${ICU_FOUND})
+ set(HAVE_ICU ${ICU_FOUND})
+endif(ENABLE_ICU)
+if(ENABLE_FRIBIDI)
+ macro_optional_find_package(FRIBIDI)
+ set(ENABLE_FRIBIDI ${FRIBIDI_FOUND})
+ set(HAVE_FRIBIDI ${FRIBIDI_FOUND})
+endif(ENABLE_FRIBIDI)
+
if(ENABLE_ZLIB)
find_package(ZLIB)
if(ZLIB_FOUND)
Index: poppler-0.20.5/Makefile.am
===
--- poppler-0.20.5.orig/Makefile.am 2012-10-18 01:53:13.0 +0200
+++ poppler-0.20.5/Makefile.am 2012-10-18 01:53:53.0 +0200
@@ -86,6 +86,8 @@
cmake/modules/PopplerDefaults.cmake \
cmake/modules/PopplerMacros.cmake \
cmake/modules/FindLIBOPENJPEG.cmake \
+ cmake/modules/FindICU.cmake\
+ cmake/modules/FindFriBiDi.cmake\
config.h.cmake \
poppler-cairo.pc.cmake \
poppler/poppler-config.h.cmake\
Index: poppler-0.20.5/configure.ac
===
--- poppler-0.20.5.orig/configure.ac 2012-10-18 01:53:13.0 +0200
+++ poppler-0.20.5/configure.ac 2012-10-18 01:53:53.0 +0200
@@ -265,6 +265,44 @@
AC_DEFINE(HAVE_FSEEK64)
fi
+dnl Test for icu
+AC_ARG_ENABLE(icu,
+ AC_HELP_STRING([--enable-icu],
+ [Build with icu based BIDI support. Enabled by default.]),
+ enable_icu=$enableval,
+ enable_icu=yes)
+if test x$enable_icu = xyes; then
+ PKG_CHECK_MODULES(ICU, icu-uc,
+[icu_pkgconfig=yes], [icu_pkgconfig=no])
+ if test x$icu_pkgconfig = xyes; then
+AC_DEFINE(HAVE_ICU, 1, [Have ICU include files])
+ else
+ICU_LIBS=
+ICU_CFLAGS=
+AC_PATH_PROG(ICU_CONFIG, icu-config, no)
+if test x$ICU_CONFIG != xno ; then
+ ICU_CFLAGS=
+ ICU_LIBS=`$ICU_CONFIG --ldflags-libsonly`
+ AC_DEFINE(HAVE_ICU, 1, [Have ICU include files])
+fi
+ fi
+fi
+
+dnl Test for fribidi
+if test x$ICU_LIBS = x; then
+AC_ARG_ENABLE(fribidi,
+ AC_HELP_STRING([--enable-fribidi],
+ [Build with fribidi based BIDI support. Enabled by default.]),
+ enable_fribidi=$enableval,
+ enable_fribidi=yes)
+if test x$enable_fribidi = xyes; then
+ PKG_CHECK_MODULES([FRIBIDI], [fribidi],
+[AC_DEFINE(HAVE_FRIBIDI, 1, [whether FriBidi is available])], [:])
+ AC_SUBST(FRIBIDI_CFLAGS)
+ AC_SUBST(FRIBIDI_LIBS)
+fi
+fi
+
dnl Test for zlib
AC_ARG_ENABLE([zlib],
[AS_HELP_STRING([--enable-zlib],[Build with zlib])],
@@ -816,6 +854,8 @@
echo use libjpeg:$enable_libjpeg
echo use libpng: $enable_libpng
echo use libtiff:$enable_libtiff
+echo use icu:$enable_icu
+echo use fribidi:
Bug#690847: poppler.
retitle 690847 patch for RTL issues thanks Hi Alex, Alle venerdì 30 novembre 2012, alex bodnaru ha scritto: i've fixed and improved some issues related to rtl support. other on the way. right, although upstream like the patches, they will be applied to their unstable tip. Which bugs does this patch fix? Can you please point me to upstream bugs? untill that tip will be stable, i'll submit them on debian too. It is way too late to introduce new dependencies now for Wheezy; after that, there will be plently of time for updating Poppler, so having them applied to Poppler 0.22 or 0.24 should have a good chance to have to be part of Jessie (the stable release after Wheezy). -- Pino Toscano signature.asc Description: This is a digitally signed message part.
Bug#690847: poppler.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 thanks pino, of course patches would debute on unstable. the moment the patch on upstream will maturize, i'll submit it here too. alex On 11/30/2012 08:07 PM, Pino Toscano wrote: retitle 690847 patch for RTL issues thanks Hi Alex, Alle venerd 30 novembre 2012, alex bodnaru ha scritto: i've fixed and improved some issues related to rtl support. other on the way. right, although upstream like the patches, they will be applied to their unstable tip. Which bugs does this patch fix? Can you please point me to upstream bugs? untill that tip will be stable, i'll submit them on debian too. It is way too late to introduce new dependencies now for Wheezy; after that, there will be plently of time for updating Poppler, so having them applied to Poppler 0.22 or 0.24 should have a good chance to have to be part of Jessie (the stable release after Wheezy). - -- best regards, alex -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iJwEAQECAAYFAlC5CykACgkQ2nA3WyrfyeMUIwQAqNKUb5VgcjHUy2at+9kfyxh/ H888x58KkGLEdNF4vKyE/YDTQXjDKJ105x7MqKq7ZhqZAejYZYFfN1p5l3eBImHS Jh+/5DBXQJfVA+tmmViqOZLXp4X4tcsdoZ7809ETWTuWtQ06kaUA8BMWuNRuIg+Q rmlL7s8AoSDqMhaY9uI= =UTDI -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#690847: poppler.
Hi, Alle venerdì 30 novembre 2012, alex bodnaru ha scritto: of course patches would debute on unstable. the moment the patch on upstream will maturize, i'll submit it here too. Sorry, but unstable is not a dump for random stuff. Unstable currently has Poppler 0.18.x, which won't see any more development. -- Pino Toscano signature.asc Description: This is a digitally signed message part.
Bug#690847: poppler.
Source: poppler Version: 0.20.5-1 Severity: normal hello friend, wishing to improve upstream a little, i found myself forced to apply patches i didn't create. that was because debian/rules clean leaves configure and Makefile.in files. maybe make distclean should be invoked? thanks a lot for your work, and i'd be delighted to post the patches on debian, before you'ld package the latest upstream. alex -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (990, 'testing'), (300, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 3.2.0-3-686-pae (SMP w/2 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#690847: poppler.
Hi, Alle giovedì 18 ottobre 2012, alex bodnaru ha scritto: wishing to improve upstream a little, i found myself forced to apply patches i didn't create. I am not sure I follow you, which patches are you forced to apply? Also, none of them is required is you want to compile and on work on the upstream version. that was because debian/rules clean leaves configure and Makefile.in files. maybe make distclean should be invoked? They are part of the release tarball, so no. See also [1] [1] http://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules thanks a lot for your work, and i'd be delighted to post the patches on debian, before you'ld package the latest upstream. Just note 0.20.x is a stable release serie, so only bug fixes go there. For new features, or generally for any patch, better send it upstream directly. -- Pino Toscano signature.asc Description: This is a digitally signed message part.
