On Mon, Oct 29, 2012 at 11:40:35PM +0100, gregor herrmann wrote:
> On Sun, 28 Oct 2012 23:55:10 -0700, Ivan Kohler wrote:
>
> > Importantly, IPPay changed the gateway's server name and path, and will soon
> > turn off the old gateway, so versions before 0.07 will stop working at that
> > time.
> >
> > Regarding squeeze, a 0.07 package should be uploaded to squeeze-updates.
> > Alternatively, the relevant changes (parts of
> > https://www.freeside.biz/gitweb/?p=Business-OnlinePayment-IPPay.git;a=commitdiff;h=1f19e67636476c7119cfb41920c5b176e617c697)
> > could be backported to 0.06.
>
> I think a minimal patch for 0.06 and, with approval of the release
> team, an upload to stable-proposed-updates is the most realistic
> way.
>
> > Regarding wheezy, we should ask for a freeze exception for 0.07.
> > Alternatively, like above, we could backport just the relevant chagnes
> > and uplaod to testing-proposed-updates.
>
> Again, I think a backported fix would be the best; and we don't need
> t-p-u since testing and unstable have the same version.
> So 0.06-2 with the necessary fix, uploaded to unstable + an unblock
> bug should be fine.
> (Except someone gets an approval for 0.07-1 from the RT.)
>
> (With some git branching, since 0.07-1 was already imported.)
Here is the requested patch for 0.06.
For the record, I am moving for the next several weeks and then away
visiting family, so my time is limited until December. Any help with
the suggested releng steps described above would certainly be welcome.
--
_ivan
diff -ur libbusiness-onlinepayment-ippay-perl-0.06/debian/changelog libbusiness-onlinepayment-ippay-perl-0.06-2/debian/changelog
--- libbusiness-onlinepayment-ippay-perl-0.06/debian/changelog 2011-01-27 15:14:35.0 -0800
+++ libbusiness-onlinepayment-ippay-perl-0.06-2/debian/changelog 2012-10-29 19:53:00.037565065 -0700
@@ -1,3 +1,9 @@
+libbusiness-onlinepayment-ippay-perl (0.06-2) unstable; urgency=low
+
+ * Backport gateway change from 0.07
+
+ -- Ivan Kohler Mon, 29 Oct 2012 19:52:32 -0700
+
libbusiness-onlinepayment-ippay-perl (0.06-1) unstable; urgency=low
[ Nicholas Bamber ]
diff -ur libbusiness-onlinepayment-ippay-perl-0.06/IPPay.pm libbusiness-onlinepayment-ippay-perl-0.06-2/IPPay.pm
--- libbusiness-onlinepayment-ippay-perl-0.06/IPPay.pm 2011-01-26 13:15:38.0 -0800
+++ libbusiness-onlinepayment-ippay-perl-0.06-2/IPPay.pm 2012-10-29 19:57:25.082627143 -0700
@@ -45,9 +45,9 @@
my %opts = @_;
# standard B::OP methods/data
-$self->server('gateway17.jetpay.com') unless $self->server;
+$self->server('gtwy.ippay.com') unless $self->server;
$self->port('443') unless $self->port;
-$self->path('/jetpay') unless $self->path;
+$self->path('/ippay') unless $self->path;
$self->build_subs(qw( order_number avs_code cvv2_response
response_page response_code response_headers
@@ -209,6 +209,9 @@
foreach ( keys ( %{($self->{_defaults})} ) ) {
$content{$_} = $self->{_defaults}->{$_} unless exists($content{$_});
}
+ if ($self->test_transaction()) {
+$content{'login'} = 'TESTTERMINAL';
+ }
$self->content(%content);
$self->required_fields(@required_fields);
@@ -221,12 +224,6 @@
}
}
- if ($self->test_transaction()) {
-$self->server('test1.jetpay.com');
-$self->port('443');
-$self->path('/jetpay');
- }
-
my $transaction_id = $content{'order_number'};
unless ($transaction_id) {
my ($page, $server_response, %headers) = $self->https_get('dummy' => 1);
@@ -391,7 +388,7 @@
if ( exists($response->{ActionCode}) && !exists($response->{ErrMsg})) {
$self->error_message($response->{ResponseText});
}else{
- $self->error_message($response->{Errmsg});
+ $self->error_message($response->{ErrMsg});
}
# }else{
#$self->error_message("Server Failed");
@@ -588,6 +585,9 @@
=head1 COMPATIBILITY
+Debian version 0.06-2 (upstream version 0.07) changes the server name and path
+for IPPay's late 2012 update.
+
Business::OnlinePayment::IPPay uses IPPay XML Product Specifications version
1.1.2.
diff -ur libbusiness-onlinepayment-ippay-perl-0.06/t/card.t libbusiness-onlinepayment-ippay-perl-0.06-2/t/card.t
--- libbusiness-onlinepayment-ippay-perl-0.06/t/card.t 2012-10-28 23:28:57.0 -0700
+++ libbusiness-onlinepayment-ippay-perl-0.06-2/t/card.t 2012-10-29 19:59:00.181575509 -0700
@@ -61,8 +61,8 @@
$tx,
desc => "invalid card_number",
is_success=> 0,
-result_code => '912',
-error_message => 'INVALID CARD NUMBER',
+result_code => '900', #'912' with old jetpay gw
+error_message => 'Invalid card number. ', #'INVALID CARD NUMBER' w/old gw
authorization => qr/^$/,
avs_code => '', # so rather pointless :\
cvv2_response => '', # ...
diff -ur libbusiness-onlinepayment-ippay-perl-0.06/t/lib/test_account.pl libbusiness-onlinepayment-ippay-perl-0.06-2/t/lib/test_a
