Bug#696632: initramfs-tools: Patches to clean up /run handling for jessie
On Sat, Sep 27, 2014 at 08:11:42PM +0100, Ben Hutchings wrote: On Wed, 11 Sep 2013 18:29:53 +0200 maximilian attems m...@stro.at wrote: On Mon, 24 Dec 2012, Roger Leigh wrote: 1) Migration of /run to the rootfs is mandatory, i.e. /run is required to be present on the rootfs. This will be the case for all jessie installs and upgrades (unlike wheezy, which needed the special-case logic to manually migrate udev/mdadm state). I'm not sure I understand this. Are you saying all wheezy installations have /run on the root filesystem, so we can assume this in packages targetted at jessie and wheezy-backports? Yes. It was intended that /run be added in the etch-wheezy upgrade and that packages which required it would use a conditional dependency on initscripts. For wheezy-jessie it's fully supported by all init systems, and packages no longer need to have a dependency on initscripts since it will be guaranteed to be present. This is also in Debian Policy now IIRC. For both jessie and wheezy-backports, /run is guaranteed to be present. While I agree on the patch himself, I don't see an urge for that. There is no real cost in keeping that for now and axing once Jessie is released. I like to keep one interval inbetween as it helps users.. (I know it is broken to often, but here there is no argument for the rush). [...] As I said happy about that patch, but unlikely for now, so ok for a downgrade to wishlist for the moment beeing? I assume this is directed to Max? Not sure myself--all the necessary stuff outside initramfs-tools has been present since wheezy TTBOMK. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696632: initramfs-tools: Patches to clean up /run handling for jessie
On Wed, 11 Sep 2013 18:29:53 +0200 maximilian attems m...@stro.at wrote: On Mon, 24 Dec 2012, Roger Leigh wrote: 1) Migration of /run to the rootfs is mandatory, i.e. /run is required to be present on the rootfs. This will be the case for all jessie installs and upgrades (unlike wheezy, which needed the special-case logic to manually migrate udev/mdadm state). I'm not sure I understand this. Are you saying all wheezy installations have /run on the root filesystem, so we can assume this in packages targetted at jessie and wheezy-backports? While I agree on the patch himself, I don't see an urge for that. There is no real cost in keeping that for now and axing once Jessie is released. I like to keep one interval inbetween as it helps users.. (I know it is broken to often, but here there is no argument for the rush). [...] As I said happy about that patch, but unlikely for now, so ok for a downgrade to wishlist for the moment beeing? Please can you answer this? Ben. -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
Bug#696632: initramfs-tools: Patches to clean up /run handling for jessie
On Mon, 24 Dec 2012, Roger Leigh wrote:
1) Migration of /run to the rootfs is mandatory, i.e. /run is required to
be present on the rootfs. This will be the case for all jessie installs
and upgrades (unlike wheezy, which needed the special-case logic to
manually migrate udev/mdadm state).
While I agree on the patch himself, I don't see an urge for that.
There is no real cost in keeping that for now and axing once Jessie is
released. I like to keep one interval inbetween as it helps users..
(I know it is broken to often, but here there is no argument for the
rush).
2) Create /run/initramfs if needed. This might also need fixing for wheezy,
since I can't see where it's created (if at all), so opening the debug
file might actually be broken at present.
Hmmm, init does it line 29, so not needed.
From 13d1e4b4bf8dc163ae488016aa2da6a11b284f57 Mon Sep 17 00:00:00 2001
From: Roger Leigh rle...@debian.org
Date: Mon, 24 Dec 2012 13:36:53 +
Subject: [PATCH 1/2] init: Always migrate /run to the rootfs
---
init | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/init b/init
index cb832ff..929de29 100755
--- a/init
+++ b/init
@@ -228,20 +228,8 @@ maybe_break bottom
run_scripts /scripts/init-bottom
[ $quiet != y ] log_end_msg
-# Preserve information on old systems without /run on the rootfs
-if [ -d ${rootmnt}/run ]; then
- mount -n -o move /run ${rootmnt}/run
-else
- # The initramfs udev database must be migrated:
- if [ -d /run/udev ] [ ! -d /dev/.udev ]; then
- mv /run/udev /dev/.udev
- fi
- # The initramfs debug info must be migrated:
- if [ -d /run/initramfs ] [ ! -d /dev/.initramfs ]; then
- mv /run/initramfs /dev/.initramfs
- fi
- umount /run
-fi
+# Move /run to the root
+mount -n -o move /run ${rootmnt}/run
validate_init() {
checktarget=${1}
--
As I said happy about that patch, but unlikely for now, so ok
for a downgrade to wishlist for the moment beeing?
Reviewed-by: maximilian attems m...@stro.at
From 29046070b93b4c97456ca9a8aadfbba0a54dc380 Mon Sep 17 00:00:00 2001
From: Roger Leigh rle...@debian.org
Date: Mon, 24 Dec 2012 13:38:40 +
Subject: [PATCH 2/2] init: Create /run/initramfs
Nack.
Thank you.
--
maks
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696632: initramfs-tools: Patches to clean up /run handling for jessie
On Mon, Dec 24, 2012 at 01:42:50PM +, Roger Leigh wrote: These patches may be pulled from git://git.debian.org/git/users/rleigh/initramfs-tools.git branch 696632-patches Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696632: initramfs-tools: Patches to clean up /run handling for jessie
Package: initramfs-tools
Version: 0.109
Severity: important
Tags: patch
I have attached two patches for your consideration:
1) Migration of /run to the rootfs is mandatory, i.e. /run is required to
be present on the rootfs. This will be the case for all jessie installs
and upgrades (unlike wheezy, which needed the special-case logic to
manually migrate udev/mdadm state).
2) Create /run/initramfs if needed. This might also need fixing for wheezy,
since I can't see where it's created (if at all), so opening the debug
file might actually be broken at present.
Regards,
Roger
From 13d1e4b4bf8dc163ae488016aa2da6a11b284f57 Mon Sep 17 00:00:00 2001
From: Roger Leigh rle...@debian.org
Date: Mon, 24 Dec 2012 13:36:53 +
Subject: [PATCH 1/2] init: Always migrate /run to the rootfs
---
init | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/init b/init
index cb832ff..929de29 100755
--- a/init
+++ b/init
@@ -228,20 +228,8 @@ maybe_break bottom
run_scripts /scripts/init-bottom
[ $quiet != y ] log_end_msg
-# Preserve information on old systems without /run on the rootfs
-if [ -d ${rootmnt}/run ]; then
- mount -n -o move /run ${rootmnt}/run
-else
- # The initramfs udev database must be migrated:
- if [ -d /run/udev ] [ ! -d /dev/.udev ]; then
- mv /run/udev /dev/.udev
- fi
- # The initramfs debug info must be migrated:
- if [ -d /run/initramfs ] [ ! -d /dev/.initramfs ]; then
- mv /run/initramfs /dev/.initramfs
- fi
- umount /run
-fi
+# Move /run to the root
+mount -n -o move /run ${rootmnt}/run
validate_init() {
checktarget=${1}
--
1.7.10.4
From 29046070b93b4c97456ca9a8aadfbba0a54dc380 Mon Sep 17 00:00:00 2001
From: Roger Leigh rle...@debian.org
Date: Mon, 24 Dec 2012 13:38:40 +
Subject: [PATCH 2/2] init: Create /run/initramfs
---
init |1 +
1 file changed, 1 insertion(+)
diff --git a/init b/init
index 929de29..c6c84d3 100755
--- a/init
+++ b/init
@@ -160,6 +160,7 @@ for x in $(cat /proc/cmdline); do
debug)
debug=y
quiet=n
+ mkdir -m 0700 /run/initramfs
exec /run/initramfs/initramfs.debug 21
set -x
;;
--
1.7.10.4
