Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
Oops, I somehow missed the previous mail. I just uploaded a fixed revision to t-p-u with wrapper functions marked as static and symbols file change reverted. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
On Tue, Jan 8, 2013 at 17:46:40 -0200, Otavio Salvador wrote: On Tue, Jan 8, 2013 at 5:43 PM, Luca Falavigna dktrkr...@debian.org wrote: 2013/1/7 Julien Cristau jcris...@debian.org: So yes I think I'd prefer an upload reverting the .symbols change. Unfortunately, simply reverting the .symbols change is not enough, as dpkg-gensymbols is passed -c4 option which makes freerdp FTBFS due to newly added symbols. What do you suggest? Lowering -c4 to -c3 to ignore the symbols change? Adjusting the patch to flag the recently added functions as static? I think changing the patch is the way to go. Luca? Cheers, Julien signature.asc Description: Digital signature
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
2013/1/7 Julien Cristau jcris...@debian.org: So yes I think I'd prefer an upload reverting the .symbols change. Unfortunately, simply reverting the .symbols change is not enough, as dpkg-gensymbols is passed -c4 option which makes freerdp FTBFS due to newly added symbols. What do you suggest? Lowering -c4 to -c3 to ignore the symbols change? Adjusting the patch to flag the recently added functions as static? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
On Tue, Jan 8, 2013 at 5:43 PM, Luca Falavigna dktrkr...@debian.org wrote: 2013/1/7 Julien Cristau jcris...@debian.org: So yes I think I'd prefer an upload reverting the .symbols change. Unfortunately, simply reverting the .symbols change is not enough, as dpkg-gensymbols is passed -c4 option which makes freerdp FTBFS due to newly added symbols. What do you suggest? Lowering -c4 to -c3 to ignore the symbols change? Adjusting the patch to flag the recently added functions as static? I think changing the patch is the way to go. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
2013/1/6 Julien Cristau jcris...@debian.org: If the symbols are added in this 1.0.1-1.1+deb7u1 version, why did you make the symbols file claim they're in 1.0.1? I blindly picked those suggested by dh_makeshlibs. Should I prepare a new upload fixing this? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
On Mon, Jan 7, 2013 at 20:22:16 +0100, Luca Falavigna wrote: 2013/1/6 Julien Cristau jcris...@debian.org: If the symbols are added in this 1.0.1-1.1+deb7u1 version, why did you make the symbols file claim they're in 1.0.1? I blindly picked those suggested by dh_makeshlibs. Should I prepare a new upload fixing this? Well if they're internal symbols (which from the diff seems likely, since I can't see a declaration in a header) they shouldn't be in the symbols file... (Really they should be declared static so they're not exported in the first place, but I guess that's neither here nor there.) So yes I think I'd prefer an upload reverting the .symbols change. Cheers, Julien signature.asc Description: Digital signature
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
On Tue, Jan 1, 2013 at 18:05:00 +0100, Luca Falavigna wrote: I hadn't realized the patch added new symbols (altough they're quite harmless), and I had to refresh debian/libfreerdp1.symbols accordingly. Full debdiff of the changes is attached. Otavio, as freerdp is listed as LowNMU, I uploaded it to DELAYED/5. If the symbols are added in this 1.0.1-1.1+deb7u1 version, why did you make the symbols file claim they're in 1.0.1? Cheers, Julien signature.asc Description: Digital signature
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock I'd like to see if it's feasible to upload a targeted fix to testing-proposed- updates to address #662854. This bug has been fixed in unstable already, also introducing changes [0] which should not fit release policy anymore, so I'd like to prepare an upload which provided the upstream fix only [1], plus a proper changelog entry. If that's OK for you, I'll coordinate with Otavio to have this bug finally solved in Wheezy. Thanks. [0] http://anonscm.debian.org/gitweb/?p=collab- maint/freerdp.git;a=commitdiff;h=debian/1.0.1-2;hp=debian/1.0.1-1 [1] https://github.com/FreeRDP/FreeRDP/commit/5617af901a4269d7fe9688793135b79ed43aecd4 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
Control: tags -1 + confirmed On Tue, 2013-01-01 at 14:54 +0100, Luca Falavigna wrote: I'd like to see if it's feasible to upload a targeted fix to testing-proposed- updates to address #662854. This bug has been fixed in unstable already, also introducing changes [0] which should not fit release policy anymore, so I'd like to prepare an upload which provided the upstream fix only [1], plus a proper changelog entry. Sounds good to me; thanks. Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
I hadn't realized the patch added new symbols (altough they're quite harmless), and I had to refresh debian/libfreerdp1.symbols accordingly. Full debdiff of the changes is attached. Otavio, as freerdp is listed as LowNMU, I uploaded it to DELAYED/5. 1.0.1-1.1+deb7u1.debdiff Description: Binary data
Bug#697101: tpu: freerdp/1.0.1-1.1+deb7u1 (pre-approval)
On Tue, Jan 1, 2013 at 14:54:32 +0100, Luca Falavigna wrote: Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock I'd like to see if it's feasible to upload a targeted fix to testing-proposed- updates to address #662854. This bug has been fixed in unstable already, also introducing changes [0] which should not fit release policy anymore, so I'd like to prepare an upload which provided the upstream fix only [1], plus a proper changelog entry. That wouldn't have needed tpu fwiw, it could have been a 1.0.1-2.1 to sid... Cheers, Julien signature.asc Description: Digital signature
