Bug#697146: xserver-xorg script forces vboxvideo even if virtualbox guest additions are not installed
On Tue, Jan 1, 2013 at 21:11:44 -0400, Ben Armstrong wrote: When it finds the PCI ID of the vbox graphic card, it wrongly assumes that the vboxvideo driver is installed, which it may not be true. Then it creates (or an already created configuration file is copied) a file in /etc/X11/xorg.conf.d which basically forces X to load that driver. Not sure how Xorg would automatically handle that for fglrx and nvidia. I always thought for those cases you needed to manually intervene, or else the free drivers would be used instead. So I gather this code has something to do with that. That's correct. However for other drivers you'd better leave the config empty. Cheers, Julien signature.asc Description: Digital signature
Bug#697146: xserver-xorg script forces vboxvideo even if virtualbox guest additions are not installed
Package: live-config
Version: 3.0.15-1
Tags: patch
The xserver-xorg script is forcing the 'vboxvideo' driver on virtualbox
even if the guest additions (virtualbox-guest-x11 package) are not
installed. This leads to X not starting on live systems without that
package.
The attached simple patch should resolve the issue (still not tested, I
will do in the coming hours).
Regards,
Eugenio
--
.: Eugenio Paolantonio - Semplice Linux developer :.
http://semplice-linux.org
http://medesimo.eu
Twitter: @eugenio_g7 - Homepage: http://me.medesimo.eu
--- a/scripts/config/1150-xserver-xorg
+++ b/scripts/config/1150-xserver-xorg
@@ -117,7 +117,7 @@
if [ -z ${LIVE_XORG_DRIVER} ]
then
# xorg-driver automatic override for virtualbox
-if echo ${_DEVICE} | grep -qs '^80EEBEEF'
+if [ -e /var/lib/dpkg/info/virtualbox-guest-x11.list ] echo ${_DEVICE} | grep -qs '^80EEBEEF'
then
LIVE_XORG_DRIVER=vboxvideo
fi
Bug#697146: xserver-xorg script forces vboxvideo even if virtualbox guest additions are not installed
On Wed, Jan 2, 2013 at 00:14:17 +0100, Eugenio 'g7' Paolantonio wrote: Package: live-config Version: 3.0.15-1 Tags: patch The xserver-xorg script is forcing the 'vboxvideo' driver on virtualbox even if the guest additions (virtualbox-guest-x11 package) are not installed. This leads to X not starting on live systems without that package. The attached simple patch should resolve the issue (still not tested, I will do in the coming hours). This is horribly wrong. You're poking dpkg-internal paths with some assumptions about which package contains the driver, for something which seems entirely unnecessary because you could just let Xorg do its driver-selection job. Cheers, Julien signature.asc Description: Digital signature
Bug#697146: xserver-xorg script forces vboxvideo even if virtualbox guest additions are not installed
Il 02/01/2013 00:22, Julien Cristau ha scritto: On Wed, Jan 2, 2013 at 00:14:17 +0100, Eugenio 'g7' Paolantonio wrote: Package: live-config Version: 3.0.15-1 Tags: patch The xserver-xorg script is forcing the 'vboxvideo' driver on virtualbox even if the guest additions (virtualbox-guest-x11 package) are not installed. This leads to X not starting on live systems without that package. The attached simple patch should resolve the issue (still not tested, I will do in the coming hours). This is horribly wrong. You're poking dpkg-internal paths with some assumptions about which package contains the driver, for something which seems entirely unnecessary because you could just let Xorg do its driver-selection job. Cheers, Julien The same script is poking dpkg-internal paths several lines before to check for the xserver-xorg package. The vboxvideo driver is contained into the virtualbox-guest-x11 package. Xorg does not do its driver-selection job because the driver (via a file in /etc/X11/xorg.conf.d) is forced, so when X does not find it, it exits. Regards, Eugenio -- .: Eugenio Paolantonio - Semplice Linux developer :. http://semplice-linux.org http://medesimo.eu Twitter: @eugenio_g7 - Homepage: http://me.medesimo.eu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697146: xserver-xorg script forces vboxvideo even if virtualbox guest additions are not installed
On 01/01/13 07:41 PM, Eugenio 'g7' Paolantonio wrote: The same script is poking dpkg-internal paths several lines before to check for the xserver-xorg package. The vboxvideo driver is contained into the virtualbox-guest-x11 package. Xorg does not do its driver-selection job because the driver (via a file in /etc/X11/xorg.conf.d) is forced, so when X does not find it, it exits. See the live-config man page. So far as I can see, it only does this if you use the xorg-driver boot parameter. By default, Xorg *is* allowed to do its job. If xorg-driver is set by the user and it's blowing up, I consider that user error. Ben -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697146: xserver-xorg script forces vboxvideo even if virtualbox guest additions are not installed
Il 02/01/2013 01:05, Ben Armstrong ha scritto: On 01/01/13 07:41 PM, Eugenio 'g7' Paolantonio wrote: The same script is poking dpkg-internal paths several lines before to check for the xserver-xorg package. The vboxvideo driver is contained into the virtualbox-guest-x11 package. Xorg does not do its driver-selection job because the driver (via a file in /etc/X11/xorg.conf.d) is forced, so when X does not find it, it exits. See the live-config man page. So far as I can see, it only does this if you use the xorg-driver boot parameter. By default, Xorg *is* allowed to do its job. If xorg-driver is set by the user and it's blowing up, I consider that user error. Ben The autodetecting mentioned into the live-config man page refers to the xserver-xorg script and not Xorg itself. If the xorg-driver boot parameter is blank, the script tries to detect the driver by looking at the PCI ID of the graphic card, see the code ([0]). When it finds the PCI ID of the vbox graphic card, it wrongly assumes that the vboxvideo driver is installed, which it may not be true. Then it creates (or an already created configuration file is copied) a file in /etc/X11/xorg.conf.d which basically forces X to load that driver. If the package containing vboxvideo is not installed, obviously X does exit because the driver listed into the configuration file is not installed. Regards, Eugenio [0] http://live.debian.net/gitweb/?p=live-config.git;a=blob_plain;f=scripts/config/1150-xserver-xorg;hb=266f31875df7eec8b4f4002f18ceaaf43c1f42b0 -- .: Eugenio Paolantonio - Semplice Linux developer :. http://semplice-linux.org http://medesimo.eu Twitter: @eugenio_g7 - Homepage: http://me.medesimo.eu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697146: xserver-xorg script forces vboxvideo even if virtualbox guest additions are not installed
On 01/01/13 08:24 PM, Eugenio 'g7' Paolantonio wrote: The autodetecting mentioned into the live-config man page refers to the xserver-xorg script and not Xorg itself. OK. Got it now. If the xorg-driver boot parameter is blank, the script tries to detect the driver by looking at the PCI ID of the graphic card, see the code ([0]). Yup. When it finds the PCI ID of the vbox graphic card, it wrongly assumes that the vboxvideo driver is installed, which it may not be true. Then it creates (or an already created configuration file is copied) a file in /etc/X11/xorg.conf.d which basically forces X to load that driver. Not sure how Xorg would automatically handle that for fglrx and nvidia. I always thought for those cases you needed to manually intervene, or else the free drivers would be used instead. So I gather this code has something to do with that. If the package containing vboxvideo is not installed, obviously X does exit because the driver listed into the configuration file is not installed. I see. Ben -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#697146: xserver-xorg script forces vboxvideo even if virtualbox guest additions are not installed
tag 697146 pending thanks On 01/02/2013 12:14 AM, Eugenio 'g7' Paolantonio wrote: The attached simple patch should resolve the issue yes, thanks, applied. -- Address:Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern Email: daniel.baum...@progress-technologies.net Internet: http://people.progress-technologies.net/~daniel.baumann/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
