Bug#694870: Bug#699109: unblock (pre-approval): initramfs-tools-tcos/0.89.91
El mié, 20-03-2013 a las 00:00 +, Jonathan Wiltshire escribió:
> user release.debian@packages.debian.org
> usertag 699109 + wheezy-will-remove
> usertag 694870 + wheezy-will-remove
> thanks
>
> On Fri, Mar 01, 2013 at 02:14:58PM +0100, Julien Cristau wrote:
> > On Mon, Jan 28, 2013 at 09:22:35 +, Manuel A. Fernandez Montecelo wrote:
> >
> > > 2013/1/27 Julien Cristau :
> > > > On Sun, Jan 27, 2013 at 17:42:48 +, Manuel A. Fernandez Montecelo
> > > > wrote:
> > > >>
> > > >> Could Release Team please say if the changes proposed in #694870 to
> > > >> fix an RC bug are OK to go?
> > > >>
> > > > Please include an actual diff in this bug instead of a pointer to
> > > > $somewhere_else.
> > >
> > > Attached.
> > >
> > > According to the discussion in that bug report, the patch does need to
> > > be so big to fix three separate issues, and without the fixes it seems
> > > that the software will not be functional.
> > >
> > I'm not overly happy with this patch. The multiarch "fixes" just
> > hardcode two paths in an arch:all package with no apparent x86
> > dependency. And the /etc/console-setup stuff looks like it'd break if
> > two files match the glob. I'm more tempted by a removal at this point
> > to be honest.
>
> Is there any progress on this? With a low popcon, maintainer seemingly
> unresponsive, RC buggy and never in a stable release, please note that
> removal will happen in a few days if this can't be resolved a better way.
>
> Thanks,
>
Thanks for CC me in this last email, I don't know any of this bug
comments.
I attach a new patch with a better multiarch and console-setup hacks
If you still want to remove from wheezy, not agree but ok for me, Ubuntu
have TCOS since 12.04 and I would be very disappointed that Debian not.
Best regards
--
Mario
diff --git a/bin/gentcos b/bin/gentcos
index 4999489..e1f5174 100755
--- a/bin/gentcos
+++ b/bin/gentcos
@@ -29,8 +29,10 @@ fi
# Multiarch DIR
LIB_MULTIARCH=/usr/lib/
-[ -e /usr/lib/i386-linux-gnu ] && LIB_MULTIARCH=/usr/lib/i386-linux-gnu/
-[ -e /usr/lib/x86_64-linux-gnu ] && LIB_MULTIARCH=/usr/lib/x86_64-linux-gnu/
+DEB_HOST_MULTIARCH=$(dpkg-architecture -qDEB_HOST_MULTIARCH 2>&1)
+if [ -n "$DEB_HOST_MULTIARCH" ] && [ -e "/usr/lib/$DEB_HOST_MULTIARCH" ]; then
+ LIB_MULTIARCH="/usr/lib/$DEB_HOST_MULTIARCH"
+fi
export LIB_MULTIARCH
. /etc/tcos/tcos.conf
@@ -466,14 +468,10 @@ check_modules() {
if [ "$(echo $_module | awk -F "|" '{print $2}')" != "" ]; then
for _mod in $(echo $_module | sed 's/|/ /g'); do
#_echo "searching for module $_mod"
- have_one_module=$(modprobe --set-version="${TCOS_KERNEL}" -l ${_mod} | wc -l)
- if [ ${have_one_module} != 0 ]; then
- #_echo "have $_mod !!!"
- have_module=1
- fi
+ tcos_find_module "${_mod}" && have_module=1
done
else
- have_module=$(modprobe --set-version="${TCOS_KERNEL}" -l ${_module} | wc -l)
+ tcos_find_module "${_module}" && have_module=1
fi
if [ ${have_module} = 0 ] ; then
diff --git a/bin/tcos-buildchroot b/bin/tcos-buildchroot
index 3afc892..8d6450c 100755
--- a/bin/tcos-buildchroot
+++ b/bin/tcos-buildchroot
@@ -179,13 +179,13 @@ chrootcreate() {
--divert /usr/sbin/invoke-rc.d.original \
/usr/sbin/invoke-rc.d
- # avoid calling udevadm inside chroot
- # http://bugs.debian.org/627790
- chroot ${TCOS_CHROOT} dpkg-divert --package initramfs-tools-tcos \
---add --rename --quiet \
---divert /sbin/udevadm.original \
-/sbin/udevadm
- createEmptyCMD /sbin/udevadm
+# # avoid calling udevadm inside chroot
+# # http://bugs.debian.org/627790
+# chroot ${TCOS_CHROOT} dpkg-divert --package initramfs-tools-tcos \
+#--add --rename --quiet \
+#--divert /sbin/udevadm.original \
+#/sbin/udevadm
+# createEmptyCMD /sbin/udevadm
cat << EOF > ${TCOS_CHROOT}/etc/apt/apt.conf
@@ -282,23 +282,24 @@ cat /etc/resolv.conf > ${TCOS_CHROOT}/etc/resolv.conf
[ ! -e ${TCOS_CHROOT}/sbin/start-stop-daemon ] && createEmptyCMD /sbin/start-stop-daemon
[ ! -e ${TCOS_CHROOT}/usr/sbin/invoke-rc.d ] && createEmptyCMD /usr/sbin/invoke-rc.d
-if [ ! -e /sbin/udevadm.original ]; then
- chroot ${TCOS_CHROOT} dpkg-divert --package initramfs-tools-tcos \
---add --rename --quiet \
---divert /sbin/udevadm.original \
-/sbin/udevadm
- createEmptyCMD /sbin/udevadm
-fi
+#if [ ! -e /sbin/udevadm.original ]; then
+# chroot ${TCOS_CHROOT} dpkg-divert --package initramfs-tools-tcos \
+#--add --rename --quiet \
+#
Bug#694870: Bug#699109: unblock (pre-approval): initramfs-tools-tcos/0.89.91
user release.debian@packages.debian.org usertag 699109 + wheezy-will-remove usertag 694870 + wheezy-will-remove thanks On Fri, Mar 01, 2013 at 02:14:58PM +0100, Julien Cristau wrote: > On Mon, Jan 28, 2013 at 09:22:35 +, Manuel A. Fernandez Montecelo wrote: > > > 2013/1/27 Julien Cristau : > > > On Sun, Jan 27, 2013 at 17:42:48 +, Manuel A. Fernandez Montecelo > > > wrote: > > >> > > >> Could Release Team please say if the changes proposed in #694870 to > > >> fix an RC bug are OK to go? > > >> > > > Please include an actual diff in this bug instead of a pointer to > > > $somewhere_else. > > > > Attached. > > > > According to the discussion in that bug report, the patch does need to > > be so big to fix three separate issues, and without the fixes it seems > > that the software will not be functional. > > > I'm not overly happy with this patch. The multiarch "fixes" just > hardcode two paths in an arch:all package with no apparent x86 > dependency. And the /etc/console-setup stuff looks like it'd break if > two files match the glob. I'm more tempted by a removal at this point > to be honest. Is there any progress on this? With a low popcon, maintainer seemingly unresponsive, RC buggy and never in a stable release, please note that removal will happen in a few days if this can't be resolved a better way. Thanks, -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51 i have six years of solaris sysadmin experience, from 8->10. i am well qualified to say it is made from bonghits layered on top of bonghits signature.asc Description: Digital signature
Bug#699109: unblock (pre-approval): initramfs-tools-tcos/0.89.91
On Mon, Jan 28, 2013 at 09:22:35 +, Manuel A. Fernandez Montecelo wrote: > 2013/1/27 Julien Cristau : > > On Sun, Jan 27, 2013 at 17:42:48 +, Manuel A. Fernandez Montecelo wrote: > >> > >> Could Release Team please say if the changes proposed in #694870 to > >> fix an RC bug are OK to go? > >> > > Please include an actual diff in this bug instead of a pointer to > > $somewhere_else. > > Attached. > > According to the discussion in that bug report, the patch does need to > be so big to fix three separate issues, and without the fixes it seems > that the software will not be functional. > I'm not overly happy with this patch. The multiarch "fixes" just hardcode two paths in an arch:all package with no apparent x86 dependency. And the /etc/console-setup stuff looks like it'd break if two files match the glob. I'm more tempted by a removal at this point to be honest. Cheers, Julien signature.asc Description: Digital signature
Bug#699109: unblock (pre-approval): initramfs-tools-tcos/0.89.91
2013/1/27 Julien Cristau : > On Sun, Jan 27, 2013 at 17:42:48 +, Manuel A. Fernandez Montecelo wrote: >> >> Could Release Team please say if the changes proposed in #694870 to >> fix an RC bug are OK to go? >> > Please include an actual diff in this bug instead of a pointer to > $somewhere_else. Attached. According to the discussion in that bug report, the patch does need to be so big to fix three separate issues, and without the fixes it seems that the software will not be functional. Cheers. -- Manuel A. Fernandez Montecelo bd77023afadfe96a0c6ab86343b02b695567439f.patch Description: Binary data
Bug#699109: unblock (pre-approval): initramfs-tools-tcos/0.89.91
On Sun, Jan 27, 2013 at 17:42:48 +, Manuel A. Fernandez Montecelo wrote: > Package: release.debian.org > Severity: normal > User: release.debian@packages.debian.org > Usertags: unblock > X-Debbugs-CC: mariodeb...@gmail.com > > Hi, > > Could Release Team please say if the changes proposed in #694870 to > fix an RC bug are OK to go? > Please include an actual diff in this bug instead of a pointer to $somewhere_else. Cheers, Julien signature.asc Description: Digital signature
Bug#699109: unblock (pre-approval): initramfs-tools-tcos/0.89.91
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock X-Debbugs-CC: mariodeb...@gmail.com Hi, Could Release Team please say if the changes proposed in #694870 to fix an RC bug are OK to go? Cheers. -- Manuel A. Fernandez Montecelo -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
