Bug#699326: unblock: bacula/5.2.6+dfsg-8

2013-01-30 Thread Alexander Golovko 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi!

Please unblock bacula-* packages, it fixes security bug #699244
(service run with incorrect permissions)

debdiff --diffstat output attached

Thank you!

-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru
diffstat for bacula-5.2.6+dfsg bacula-5.2.6+dfsg

 additions/common-functions.dpkg |7 ++-
 changelog   |7 +++
 2 files changed, 9 insertions(+), 5 deletions(-)

diff -Nru bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg 
bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
--- bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg2013-01-03 
00:53:46.0 +0400
+++ bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg2013-01-29 
18:46:09.0 +0400
@@ -162,16 +162,14 @@
 bacula-fd)
 SERVICE=bacula-fd
 ARGS=
-DEFAULT_ARGS=
 ;;
 bacula-sd)
 SERVICE=bacula-sd
 ARGS=-u bacula -g tape
-DEFAULT_ARGS=-u bacula -g tape
 ;;
 bacula-director-pgsql|bacula-director-mysql|bacula-director-sqlite3)
 SERVICE=bacula-dir
-DAEMONUSER=bacula:bacula
+ARGS=-u bacula -g bacula
 if ucfq -w /etc/default/bacula-dir \
 |egrep -q '^[^:]*:bacula-director-(pgsql|mysql|sqlite3):'; then
 UCFR_ARGS=-f
@@ -197,7 +195,6 @@
 else
 if [ -f $DEFAULTS ]; then
 ENABLED=$(. $DEFAULTS; echo $ENABLED)
-ARGS=$(. $DEFAULTS; echo $ARGS)
 CONFIG=$(. $DEFAULTS; echo $CONFIG)
 fi
 fi
@@ -219,7 +216,7 @@
 ENABLED=$ENABLED
 
 # Additional start arguments can be provided here
-# ARGS=$DEFAULT_ARGS
+# ARGS=$ARGS
 ARGS=$ARGS
 
 # Default config file can be changed here
diff -Nru bacula-5.2.6+dfsg/debian/changelog bacula-5.2.6+dfsg/debian/changelog
--- bacula-5.2.6+dfsg/debian/changelog  2013-01-08 16:01:40.0 +0400
+++ bacula-5.2.6+dfsg/debian/changelog  2013-01-29 18:47:28.0 +0400
@@ -1,3 +1,10 @@
+bacula (5.2.6+dfsg-8) unstable; urgency=high
+
+  * debian/additions/common-functions.dpkg:
++ Fix missed user for run bacula-director (Closes: #699244).
+
+ -- Alexander Golovko alexan...@ankalagon.ru  Tue, 29 Jan 2013 18:47:27 +0400
+
 bacula (5.2.6+dfsg-7) unstable; urgency=low
 
   * debian/bacula-sd.install, bacula-director-{sqlite3,mysql,pgsql}.install,


signature.asc
Description: PGP signature

Bug#699326: unblock: bacula/5.2.6+dfsg-8

2013-01-30 Thread Julien Cristau 
On Wed, Jan 30, 2013 at 14:33:49 +0400, Alexander Golovko wrote:

 diffstat for bacula-5.2.6+dfsg bacula-5.2.6+dfsg
 
  additions/common-functions.dpkg |7 ++-
  changelog   |7 +++
  2 files changed, 9 insertions(+), 5 deletions(-)
 
 diff -Nru bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg 
 bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
 --- bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg  2013-01-03 
 00:53:46.0 +0400
 +++ bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg  2013-01-29 
 18:46:09.0 +0400

How/where is this file used?

Cheers,
Julien


signature.asc
Description: Digital signature

Bug#699326: unblock: bacula/5.2.6+dfsg-8

2013-01-30 Thread Alexander Golovko 
В Wed, 30 Jan 2013 20:40:07 +0100
Julien Cristau jcris...@debian.org пишет:

 On Wed, Jan 30, 2013 at 14:33:49 +0400, Alexander Golovko wrote:
 
  diffstat for bacula-5.2.6+dfsg bacula-5.2.6+dfsg
  
   additions/common-functions.dpkg |7 ++-
   changelog   |7 +++
   2 files changed, 9 insertions(+), 5 deletions(-)
  
  diff -Nru bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
  bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg ---
  bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
  2013-01-03 00:53:46.0 +0400 +++
  bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
  2013-01-29 18:46:09.0 +0400
 
 How/where is this file used?

Changed code used for generate /etc/default/bacula-{fd,sd,director}
files. Defaults file for bacula-director in 5.2.6+dfsg-7 incorrectly
set empty arguments string (there is error in reverting some changes),
which lead to run service with root privileges.


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature