Bug#700588: modemmanager 0.7 for debian experimental?
On 12.03.2013 21:45, Mathieu Trudel-Lapierre wrote:
Fair enough. I started, or more precisely cleaned up what I had a bit and
rebased on 0.7.990; it builds here on Ubuntu and I shipped it to a PPA to
build cleanly:
Thanks for that!
https://launchpad.net/~network-manager/+archive/modemmanager-next/+sourcepub/3023373/+listing-archive-extra
It builds fine in sbuild here with libqmi 1.0-1. I'll track it later to see
whether it completes this build. Then there is some work done by Marius
Kotsbak I'll merge, and I'll be ready for constructive criticism (ie.
sponsoring).
I've had a quick look at it, a couple of comments:
1/ it would be nice if you could merge the 0.5.2.0-2 changelog from
Debian. Easiest is probably if for 0.7.990 you change the version number
to 0.7.990-1 and upload target to experimental and sync from there?
2/ multi-arch support [1]
- Don't hard-code the pre-depends on multiarch-support, use
Pre-Depends: ${misc:Pre-Depends} instead
- Flag the library package as Multi-Arch: same
- Haven't checked if other binary packages can be flagged as same or
foreign, but that is not that important for now
3/ Missing build-depends on autopoint
Since you are using autopoint in debian/rules and Debian buildds don't
install Recommends, you need to add that dep. On the other hand, why do
you need autopoint?
4/ debian/rules: autoreconf
You don't call dh_autoreconf correctly if autogen.sh is not available,
this way debian/rules clean will not restore to a proper state.
Use what I have 0.5.2.0-2 and add a separate autoreconf make target
autoreconf:
↦ intltoolize -f
↦ autoreconf -f -i
override_dh_autoreconf:
↦ dh_autoreconf debian/rules -- autoreconf
Fwiw, I don't think we need a if-def here.
Use the explicit calls to the individual tools and once autogen.sh is
available in the release tarball, rely on that.
Fwiw, an alternative might be to build-depend on gnome-common and use
gnome-autogen.sh, which should dtrt(tm)
export NOCONFIGURE=true
override_dh_autoreconf:
↦ dh_autoreconf -- gnome-autogen.sh
Ping me when you have an updated package. I'm happy to upload to
experimental then.
Michael
[1]
http://wiki.debian.org/Multiarch/Implementation#Recipes_for_converting_packages
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
Bug#700588: modemmanager 0.7 for debian experimental?
On 13.03.2013 08:55, Michael Biebl wrote: On 12.03.2013 21:45, Mathieu Trudel-Lapierre wrote: Fair enough. I started, or more precisely cleaned up what I had a bit and rebased on 0.7.990; it builds here on Ubuntu and I shipped it to a PPA to build cleanly: Thanks for that! https://launchpad.net/~network-manager/+archive/modemmanager-next/+sourcepub/3023373/+listing-archive-extra It builds fine in sbuild here with libqmi 1.0-1. I'll track it later to see whether it completes this build. Then there is some work done by Marius Kotsbak I'll merge, and I'll be ready for constructive criticism (ie. sponsoring). I've had a quick look at it, a couple of comments: One more: 1/ Do you really want to make libmm-glib0 depend on modemmanager? Why is that needed? This creates a nasty dependency loop. Is this for the plugins? Having them in modemmanager also results in E: modemmanager: pkg-has-shlibs-control-file-but-no-actual-shared-libs W: modemmanager: postinst-has-useless-call-to-ldconfig W: modemmanager: postrm-has-useless-call-to-ldconfig If libmm-glib0 is supposed to be a standalone library and needs those plugins, then they should be moved into libmm-glib0 (assuming upstream bumps the Version in the directory path) or have them in a libmm-glib-runtime package with libnm-glib0 depending on that. If those modules are used by ModemManager and *not* by libmm-glib0, keep them in the modemmanager package but exclude them from dh_makeshlibs. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#700588: modemmanager 0.7 for debian experimental?
On 13.03.2013 08:55, Michael Biebl wrote: On 12.03.2013 21:45, Mathieu Trudel-Lapierre wrote: 3/ Missing build-depends on autopoint Since you are using autopoint in debian/rules and Debian buildds don't install Recommends, you need to add that dep. Nvm, seems this build-dep is pulled via gtk-doc-tools → gnome-common → autopoint That's why I didn't see it immediately. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#700588: modemmanager 0.7 for debian experimental?
On Mon, Mar 11, 2013 at 7:39 PM, Andreas Henriksson andr...@fatal.sewrote: On Mon, Mar 11, 2013 at 03:59:39PM -0400, Mathieu Trudel-Lapierre wrote: [...] I started doing some work on Ubuntu for this. It's interesting though, as it's usually Michael who handles modemmanager directly in Debian. Michael is one of the primary reasons he pointed to you is that he is very busy right now with other things (also mentioning bzr). Fair enough. I started, or more precisely cleaned up what I had a bit and rebased on 0.7.990; it builds here on Ubuntu and I shipped it to a PPA to build cleanly: https://launchpad.net/~network-manager/+archive/modemmanager-next/+sourcepub/3023373/+listing-archive-extra It builds fine in sbuild here with libqmi 1.0-1. I'll track it later to see whether it completes this build. Then there is some work done by Marius Kotsbak I'll merge, and I'll be ready for constructive criticism (ie. sponsoring). Regards, Mathieu Trudel-Lapierre mathieu...@gmail.com Freenode: cyphermox, Jabber: mathieu...@gmail.com 4096R/EE018C93 1967 8F7D 03A1 8F38 732E FF82 C126 33E1 EE01 8C93
