Bug#700602: speex: Build with floating point/asm optimization on armhf.

2013-02-18 Thread Luke Yelavich
On Fri, Feb 15, 2013 at 07:54:48AM GMT, Ron wrote:
 You realise that's _not_ actually what your patch does, right?
 
  In Ubuntu, the attached patch was applied to achieve the following:
  
* Build with float on armhf (LP: #1125295)
 
 Can you share with us the results of the benchmarking you did that
 actually demonstrates this improves performance in speex, since I don't
 see any indication of that being done in the LP achievement you refer to?

Sorry, i am just the patch forwarder. I am CCing David Henningssen who wrote 
the patch. David, mind explaining how you came to doin what you did in the 
patch to get what we wanted with speex?

Thanks

Luke


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#700602: speex: Build with floating point/asm optimization on armhf.

2013-02-18 Thread David Henningsson

On 02/18/2013 01:09 PM, Luke Yelavich wrote:

On Fri, Feb 15, 2013 at 07:54:48AM GMT, Ron wrote:

You realise that's _not_ actually what your patch does, right?


In Ubuntu, the attached patch was applied to achieve the following:

   * Build with float on armhf (LP: #1125295)


Can you share with us the results of the benchmarking you did that
actually demonstrates this improves performance in speex, since I don't
see any indication of that being done in the LP achievement you refer to?


Sorry, i am just the patch forwarder. I am CCing David Henningssen who wrote 
the patch. David, mind explaining how you came to doin what you did in the 
patch to get what we wanted with speex?


My problem is not performance related, and not PulseAudio related 
either. The problem is that using fixed point completely disables some 
libspeex functions, such as automatic gain control.


Without working AGC, mumble do not function correctly. I e, in mumble 
there is no sound at all (and a long stream of error messages) if you 
build libspeex with fixed point.




--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#700602: speex: Build with floating point/asm optimization on armhf.

2013-02-15 Thread Ron

Hi Luke,

On Fri, Feb 15, 2013 at 05:00:46PM +1100, Luke Yelavich wrote:
 Package: speex
 Version: 1.2~rc1-7
 Severity: wishlist
 Tags: patch
 User: ubuntu-de...@lists.ubuntu.com
 Usertags: origin-ubuntu raring ubuntu-patch
 
 Dear Maintainer,

 In Ubuntu raring, we enabled asm optimizations on armhf to
 improve the resampling performance with PulseAudio.

You realise that's _not_ actually what your patch does, right?

 In Ubuntu, the attached patch was applied to achieve the following:
 
   * Build with float on armhf (LP: #1125295)

Can you share with us the results of the benchmarking you did that
actually demonstrates this improves performance in speex, since I don't
see any indication of that being done in the LP achievement you refer to?

  Ron


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#700602: speex: Build with floating point/asm optimization on armhf.

2013-02-14 Thread Luke Yelavich
Package: speex
Version: 1.2~rc1-7
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu raring ubuntu-patch

Dear Maintainer,
In Ubuntu raring, we enabled asm optimizations on armhf to improve the 
resampling performance with PulseAudio.

*** /tmp/tmpxt7lqr/bug_body

In Ubuntu, the attached patch was applied to achieve the following:


  * Build with float on armhf (LP: #1125295)


Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers raring-updates
  APT policy: (500, 'raring-updates'), (500, 'raring-security'), (500, 'raring')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.8.0-6-generic (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -u speex-1.2~rc1/debian/rules speex-1.2~rc1/debian/rules
--- speex-1.2~rc1/debian/rules
+++ speex-1.2~rc1/debian/rules
@@ -56,9 +56,9 @@
 arch_objs = $(objdir)
 
 ifeq ($(DEB_HOST_ARCH_CPU),arm)
-objdir = $(objdir_fixedpoint)
 
 ifneq ($(DEB_HOST_ARCH),armhf)
+objdir = $(objdir_fixedpoint)
 EXTRA_CONFIG_FLAGS = --enable-arm4-asm
 endif
 
diff -u speex-1.2~rc1/debian/changelog speex-1.2~rc1/debian/changelog