Bug#711117: Fwd: Anacron job 'cron.daily' on tglase.lan.tarent.de

2013-06-05 Thread Thorsten Glaser
tags 77 + patch
thanks

Hi,

please see the attached patch. (The initscript is ugly,
but I tried to keep the changes relatively minimal.)

bye,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-314
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Boris Esser, Sebastian Mancke

-- Forwarded message --
From: Anacron r...@tglase.lan.tarent.de
Message-ID: 20130602053545.90c13702...@tglase.lan.tarent.de
To: r...@tglase.lan.tarent.de
Date: Sun,  2 Jun 2013 07:35:45 +0200 (CEST)
Subject: Anacron job 'cron.daily' on tglase.lan.tarent.de

/etc/cron.daily/logrotate:
error: error running shared postrotate script for '/var/log/apache2/*.log '
run-parts: /etc/cron.daily/logrotate exited with return code 1From b47a2167c32559885d7cff6d72f83301aa67bfc6 Mon Sep 17 00:00:00 2001
From: Thorsten Glaser t...@debian.org
Date: Wed, 5 Jun 2013 11:04:59 +0200
Subject: [PATCH] The init script exits 0 unless an error occured. Closes:
 #77

Signed-off-by: Thorsten Glaser t...@debian.org
---
 debian/apache2.init | 25 -
 1 file changed, 20 insertions(+), 5 deletions(-)

diff --git a/debian/apache2.init b/debian/apache2.init
index a9f215f..78f84cc 100755
--- a/debian/apache2.init
+++ b/debian/apache2.init
@@ -206,7 +206,9 @@ do_stop()
 # Function that sends a SIGHUP to the daemon/service
 #
 do_reload() {
-if $APACHE2CTL configtest  /dev/null 21; then
+	$APACHE2CTL configtest /dev/null 21
+	APACHE2_INIT_CONFIGTEST_STATUS=$?
+	if test $APACHE2_INIT_CONFIGTEST_STATUS = 0; then
 	if ! pidofproc -p $PIDFILE $DAEMON  /dev/null 21 ; then
 APACHE2_INIT_MESSAGE=Apache2 is not running
 return 2
@@ -282,6 +284,7 @@ case $1 in
 [ $VERBOSE != no ]  log_end_msg 1
 [ -n $APACHE2_INIT_MESSAGE ]  echo $APACHE2_INIT_MESSAGE 2
 log_failure_msg
+			exit 1
;;
 	esac
 	;;
@@ -305,15 +308,25 @@ case $1 in
 [ $VERBOSE != no ]  log_end_msg $?
 fi
 
+	case $RET_STATUS in
+	(0|1)
+		;;
+	(*)
+		exit 1
+		;;
+	esac
+
 	;;
   status)
-	status_of_proc -p $PIDFILE apache2 $NAME  exit 0 || exit $?
+	status_of_proc -p $PIDFILE apache2 $NAME
+	exit $?
 	;;
   reload|force-reload|graceful)
 	log_daemon_msg Reloading $DESC $NAME
 	do_reload
 	log_end_msg $?
 [ $VERBOSE != no ]  [ x$APACHE2_INIT_MESSAGE != x ]  log_warning_msg $APACHE2_INIT_MESSAGE
+	test $APACHE2_INIT_CONFIGTEST_STATUS = 0 || exit 1
 	;;
   restart)
 	log_daemon_msg Restarting $DESC $NAME
@@ -322,14 +335,15 @@ case $1 in
 	  0|1)
 		do_start
 		case $? in
-			0) log_end_msg 0 ;;
-			1) log_end_msg 1 ;; # Old process is still running
-			*) log_end_msg 1 ;; # Failed to start
+		0) log_end_msg 0 ;;
+		1) log_end_msg 1; exit 1 ;; # Old process is still running
+		*) log_end_msg 1; exit 1 ;; # Failed to start
 		esac
 		;;
 	  *)
 		# Failed to stop
 		log_end_msg 1
+		exit 1
 		;;
 	esac
 	;;
@@ -348,3 +362,4 @@ case $1 in
 	exit 3
 	;;
 esac
+exit 0
-- 
1.8.3



Bug#711117:

2013-06-05 Thread Semaj Jones
Logs


Bug#711117: apache2: /etc/init.d/apache2 reload always returns 1

2013-06-04 Thread Frederik Himpe
Package: apache2
Version: 2.4.4-5
Severity: normal

/etc/init.d/apache2 reload always returns 1, even if it succeeds. apache2ctl
graceful correctly returns 0.

Default apache2 configuration, right after installation:

root@debian-sid:/home/frederik# apache2ctl graceful
AH00558: apache2: Could not reliably determine the server's fully qualified 
domain name, using 127.0.1.1. Set the 'ServerName' directive globally to 
suppress this message
root@debian-sid:/home/frederik# echo $?
0
root@debian-sid:/home/frederik# /etc/init.d/apache2 reload
[ ok ] Reloading web server: apache2.
root@debian-sid:/home/frederik# echo $?
1
root@debian-sid:/home/frederik# bash -x /etc/init.d/apache2 reload
+ DESC='web server'
+ NAME=apache2
+ DAEMON=/usr/sbin/apache2
+ SCRIPTNAME=apache2
+ SCRIPTNAME=apache2
+ '[' -n '' ']'
+ '[' apache2 '!=' apache2 ']'
+ DIR_SUFFIX=
+ APACHE_CONFDIR=/etc/apache2
+ '[' -z '' ']'
+ APACHE_ENVVARS=/etc/apache2/envvars
+ export APACHE_CONFDIR APACHE_ENVVARS
+ ENV='env -i LANG=C PATH=/usr/local/bin:/usr/bin:/bin'
+ '[' /etc/apache2 '!=' /etc/apache2 ']'
+ '[' /etc/apache2/envvars '!=' /etc/apache2/envvars ']'
+ HTCACHECLEAN_RUN=auto
+ HTCACHECLEAN_MODE=daemon
+ HTCACHECLEAN_SIZE=300M
+ HTCACHECLEAN_DAEMON_INTERVAL=120
+ HTCACHECLEAN_PATH=/var/cache/apache2/mod_disk_cache
+ HTCACHECLEAN_OPTIONS=
++ . /etc/apache2/envvars
+++ unset HOME
+++ '[' /etc/apache2 '!=' /etc/apache2 ']'
+++ SUFFIX=
+++ export APACHE_RUN_USER=www-data
+++ APACHE_RUN_USER=www-data
+++ export APACHE_RUN_GROUP=www-data
+++ APACHE_RUN_GROUP=www-data
+++ export APACHE_PID_FILE=/var/run/apache2/apache2.pid
+++ APACHE_PID_FILE=/var/run/apache2/apache2.pid
+++ export APACHE_RUN_DIR=/var/run/apache2
+++ APACHE_RUN_DIR=/var/run/apache2
+++ export APACHE_LOCK_DIR=/var/lock/apache2
+++ APACHE_LOCK_DIR=/var/lock/apache2
+++ export APACHE_LOG_DIR=/var/log/apache2
+++ APACHE_LOG_DIR=/var/log/apache2
+++ export LANG=C
+++ LANG=C
+++ export LANG
++ echo
+ APACHE_HTTPD=
+ '[' -z '' ']'
+ APACHE_HTTPD=/usr/sbin/apache2
+ '[' -f /etc/default/apache2 ']'
+ . /etc/default/apache2
++ HTCACHECLEAN_RUN=auto
++ HTCACHECLEAN_MODE=daemon
++ HTCACHECLEAN_SIZE=300M
++ HTCACHECLEAN_DAEMON_INTERVAL=120
++ HTCACHECLEAN_PATH=/var/cache/apache2/mod_cache_disk
++ HTCACHECLEAN_OPTIONS=-n
++ . /etc/apache2/envvars
+++ unset HOME
+++ '[' /etc/apache2 '!=' /etc/apache2 ']'
+++ SUFFIX=
+++ export APACHE_RUN_USER=www-data
+++ APACHE_RUN_USER=www-data
+++ export APACHE_RUN_GROUP=www-data
+++ APACHE_RUN_GROUP=www-data
+++ export APACHE_PID_FILE=/var/run/apache2/apache2.pid
+++ APACHE_PID_FILE=/var/run/apache2/apache2.pid
+++ export APACHE_RUN_DIR=/var/run/apache2
+++ APACHE_RUN_DIR=/var/run/apache2
+++ export APACHE_LOCK_DIR=/var/lock/apache2
+++ APACHE_LOCK_DIR=/var/lock/apache2
+++ export APACHE_LOG_DIR=/var/log/apache2
+++ APACHE_LOG_DIR=/var/log/apache2
+++ export LANG=C
+++ LANG=C
+++ export LANG
++ echo /var/run/apache2/apache2.pid
+ PIDFILE=/var/run/apache2/apache2.pid
+ VERBOSE=no
+ '[' -f /etc/default/rcS ']'
+ . /etc/default/rcS
+ . /lib/lsb/init-functions
+++ run-parts --lsbsysinit --list /lib/lsb/init-functions.d
++ for hook in '$(run-parts --lsbsysinit --list /lib/lsb/init-functions.d 
2/dev/null)'
++ '[' -r /lib/lsb/init-functions.d/20-left-info-blocks ']'
++ . /lib/lsb/init-functions.d/20-left-info-blocks
++ FANCYTTY=
++ '[' -e /etc/lsb-base-logging.sh ']'
++ true
+ APACHE2CTL='env -i LANG=C PATH=/usr/local/bin:/usr/bin:/bin 
/usr/sbin/apache2ctl'
+ HTCACHECLEAN='env -i LANG=C PATH=/usr/local/bin:/usr/bin:/bin 
/usr/sbin/htcacheclean'
++ . /etc/apache2/envvars
+++ unset HOME
+++ '[' /etc/apache2 '!=' /etc/apache2 ']'
+++ SUFFIX=
+++ export APACHE_RUN_USER=www-data
+++ APACHE_RUN_USER=www-data
+++ export APACHE_RUN_GROUP=www-data
+++ APACHE_RUN_GROUP=www-data
+++ export APACHE_PID_FILE=/var/run/apache2/apache2.pid
+++ APACHE_PID_FILE=/var/run/apache2/apache2.pid
+++ export APACHE_RUN_DIR=/var/run/apache2
+++ APACHE_RUN_DIR=/var/run/apache2
+++ export APACHE_LOCK_DIR=/var/lock/apache2
+++ APACHE_LOCK_DIR=/var/lock/apache2
+++ export APACHE_LOG_DIR=/var/log/apache2
+++ APACHE_LOG_DIR=/var/log/apache2
+++ export LANG=C
+++ LANG=C
+++ export LANG
++ echo /var/run/apache2/apache2.pid
+ PIDFILE=/var/run/apache2/apache2.pid
+ APACHE2_INIT_MESSAGE=
+ '[' -x /usr/sbin/apache2 ']'
+ '[' '!' -x /usr/sbin/apache2 ']'
+ '[' -z /var/run/apache2/apache2.pid ']'
+ check_htcacheclean
+ '[' daemon = daemon ']'
+ '[' auto = yes ']'
++ . /etc/apache2/envvars
+++ unset HOME
+++ '[' /etc/apache2 '!=' /etc/apache2 ']'
+++ SUFFIX=
+++ export APACHE_RUN_USER=www-data
+++ APACHE_RUN_USER=www-data
+++ export APACHE_RUN_GROUP=www-data
+++ APACHE_RUN_GROUP=www-data
+++ export APACHE_PID_FILE=/var/run/apache2/apache2.pid
+++ APACHE_PID_FILE=/var/run/apache2/apache2.pid
+++ export APACHE_RUN_DIR=/var/run/apache2
+++ APACHE_RUN_DIR=/var/run/apache2
+++ export APACHE_LOCK_DIR=/var/lock/apache2
+++ APACHE_LOCK_DIR=/var/lock/apache2
+++ export APACHE_LOG_DIR=/var/log/apache2
+++