Bug#711469: Can we have libslapi-dev back please:

[Florian Schlichting]

Hi Ryan,

On Mon, Nov 12, 2018 at 08:18:07AM -0800, Ryan Tandy wrote:
> As I understand, you are already using the proposed patch (re-adding
> slapi-dev) in your own builds? If you're confident the built package works,
> you are welcome to NMU (or team-upload :-)) the addition.

yes I am building and using the slapi-dev package, and I'm confident
that "it works". It is quite trivial really, consisting only of a single
ASCII file copied verbatim from the openldap source package, and a
symlink. Quoting from the build log:

slapi-dev_2.4.44+dfsg-5+deb9u2_amd64.deb


 new debian package, version 2.0.
 size 86504 bytes: control archive=639 bytes.
 539 bytes,14 lines  control  
 278 bytes, 4 lines  md5sums  
 Package: slapi-dev
 Source: openldap
 Version: 2.4.44+dfsg-5+deb9u2
 Architecture: amd64
 Maintainer: Debian OpenLDAP Maintainers 

 Installed-Size: 138
 Depends: slapd (= 2.4.44+dfsg-5+deb9u2)
 Section: libdevel
 Priority: optional
 Homepage: http://www.openldap.org/
 Description: OpenLDAP SLAPI plugin interface development headers
  This package allows development of plugins for the OpenLDAP slapd server
  using the SLAPI interface. It includes the headers and libraries needed
  to build such plugins.

drwxr-xr-x root/root 0 2018-05-23 04:25 ./
drwxr-xr-x root/root 0 2018-05-23 04:25 ./usr/
drwxr-xr-x root/root 0 2018-05-23 04:25 ./usr/include/
-rw-r--r-- root/root 38351 2018-05-23 04:25 ./usr/include/slapi-plugin.h
drwxr-xr-x root/root 0 2018-05-23 04:25 ./usr/lib/
drwxr-xr-x root/root 0 2018-05-23 04:25 ./usr/lib/x86_64-linux-gnu/
lrwxrwxrwx root/root 0 2018-05-23 04:25 
./usr/lib/x86_64-linux-gnu/libslapi.so -> libslapi-2.4.so.2.10.7
drwxr-xr-x root/root 0 2018-05-23 04:25 ./usr/share/
drwxr-xr-x root/root 0 2018-05-23 04:25 ./usr/share/doc/
drwxr-xr-x root/root 0 2018-05-23 04:25 ./usr/share/doc/slapi-dev/
-rw-r--r-- root/root 46965 2018-05-23 04:25 
./usr/share/doc/slapi-dev/changelog.Debian.gz
-rw-r--r-- root/root 23853 2016-02-05 23:57 
./usr/share/doc/slapi-dev/changelog.gz
-rw-r--r-- root/root 20216 2018-05-23 04:25 
./usr/share/doc/slapi-dev/copyright


(and yes, the plugin that we build with this header builds successfully,
and works - but that's beyond the scope of openldap packaging, IMHO)

> The things I would want do before uploading myself are:
> 
> - figure out what the "discussion with ftp-master" referenced in the
> 2.4.7-2 changelog was about and determine whether further follow-up is
> needed;

I think this refers to FTP masters pushing back against "trivial"
packages that only contain a few small files, where they felt the burden
on the ftpmaster and mirror infrastructure was disproportionate compared
to the benefit users might enjoy by not needing to install certain
packages. I'm not sure how big an issue this was a decade ago, but I
don't think it plays a role nowadays.

Building a new binary package does send the upload to NEW though, so I
don't think this is something to do in an NMU (and btw I'm not the
person who wrote our plugin and won't be of much help beyond packaging
questions)

> - check for file collisions with other packages (389-ds uses slapi, I'm  not
> sure whether public headers/libs are installed); and

$ apt-file search slapi-plugin.h
389-ds-base-dev: /usr/include/dirsrv/slapi-plugin.h
slapi-dev: /usr/include/slapi-plugin.h

> - build and test some kind of example SLAPI module to convince myself  the
> slapi-dev package is functional.
> 
> (hmm, shouldn't the package properly be called libslapi-dev?)

Steve's changelog entry says

  * Split slapi dev support into a new libslapi-dev package, as this is
unrelated to libldap; and drop libslapi.a since it would be insane to try
to statically link a dynamically-loaded slapi plugin.

but then there's commit 06777b964 renaming debian/libslapi-dev.install
to debian/slapi-dev.install: "be a bit more consistent about the package
name, so it can actually find its files..." - it seems in debian/control
it was always named slapi-dev?

Florian

Bug#711469: Can we have libslapi-dev back please:

[Ryan Tandy]

Hi Florian,

On Mon, Nov 12, 2018 at 10:34:14AM +0100, Florian Schlichting wrote:

what's the status on this? Having slapi-dev in buster would save me at
least several openldap recompiles :-)


Thanks for the ping. I have not had much time for working on the 
openldap package lately but I have noted this on my list of things to 
look at on my upcoming vacation. I understand it would be good to have 
this in buster.


As I understand, you are already using the proposed patch (re-adding 
slapi-dev) in your own builds? If you're confident the built package 
works, you are welcome to NMU (or team-upload :-)) the addition.


The things I would want do before uploading myself are:

- figure out what the "discussion with ftp-master" referenced in the 
 2.4.7-2 changelog was about and determine whether further follow-up is 
 needed;
- check for file collisions with other packages (389-ds uses slapi, I'm 
 not sure whether public headers/libs are installed); and
- build and test some kind of example SLAPI module to convince myself 
 the slapi-dev package is functional.


(hmm, shouldn't the package properly be called libslapi-dev?)

Thanks
Ryan

Bug#711469: Can we have libslapi-dev back please:

[Florian Schlichting]

PING!

what's the status on this? Having slapi-dev in buster would save me at
least several openldap recompiles :-)

On Tue, Nov 07, 2017 at 03:07:04PM +0100, Florian Schlichting wrote:
> Control: tags 711469 + patch
> 
> On Tue, May 31, 2016 at 10:38:34PM +0200, Florian Schlichting wrote:
> > I need slapi-plugin.h for a $work project and would like to help move
> > this issue to either solution, reinstating slapi-dev or reintegration
> > into libldap2-dev.
> 
> as debian/slapi-dev.install is still there, bringing the slapi-dev
> package back is trivial. Please apply the following patch.
> 
> Florian
> 
> 
> commit 89c084c33f8d0e9db33b620c05d710bdc9438a31 (HEAD -> master)
> Author: Florian Schlichting 
> Date:   Tue Nov 7 12:33:33 2017 +0100
> 
> bring back slapi-dev (closes: #711469)
> 
> diff --git a/debian/control b/debian/control
> index bb68a5f5a..ca86503d3 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -104,3 +104,12 @@ Description: OpenLDAP development libraries
>   This package allows development of LDAP applications using the OpenLDAP
>   libraries. It includes headers, libraries and links to allow static and
>   dynamic linking.
> +
> +Package: slapi-dev
> +Section: libdevel
> +Architecture: any
> +Depends: slapd (= ${binary:Version}), ${misc:Depends}
> +Description: OpenLDAP SLAPI plugin interface development headers
> + This package allows development of plugins for the OpenLDAP slapd server
> + using the SLAPI interface. It includes the headers and libraries needed
> + to build such plugins.
> 
> -- 
> To unsubscribe, send mail to 711469-unsubscr...@bugs.debian.org.

Bug#711469: [Pkg-openldap-devel] Bug#711469: Can we have libslapi-dev back please:

[Ryan Tandy]

On Wed, Nov 08, 2017 at 10:18:13AM +0100, Florian Schlichting wrote:

Hi, thank you for pinging the bug, and for the patch. I intend to make an
upload in the coming weeks and I will definitely evaluate this addition. Do
you have a convenient test case that I could use for verifying the result?


Like, what kind of test case? How do you test libldap2-dev?


I was thinking of source for a hello-world slapi plugin that I could 
compile and run to ensure the header(s)/library(ies) have been 
installed sanely (and contents were properly processed by the build, 
etc). It's OK, I'm sure I'll find an example out on the web once I look.



I think the issue behind this bug is the question whether a
single-header -dev package is worthwhile, or if it could just be
included in the general libldap2-dev package. I'm fine either way, I
just need include/slapi-plugin.h be available in any Debian package.


I don't think merging it into libldap2-dev is an option. 
libslapi-2.4.so.2.10.7 itself is shipped in slapd and the -dev package 
needs to depend on that to avoid shipping a broken symlink.



BTW #650501 is also a request to ship more headers that are part of the
openldap shared library API. In my understanding, shipping headers for
shared libraries is a risk-free thing to do (unless you don't want
people to use your shared library, but then what's the point of having
it in the first place?) so I think that bug could also be acted upon
without worrying too much.


I will look at that one again. I think the headers it's talking about 
(slap.h and so on) are internal to slapd and not part of any ABI 
contract. If any other package were to depend on them, we'd have to go 
through some machinations (and probably manual work) to track ABI. At 
any rate I'd be hesitant to provide them if they aren't installed by 
upstream's "make install" - I will check that.

Bug#711469: [Pkg-openldap-devel] Bug#711469: Can we have libslapi-dev back please:

[Florian Schlichting]

Hi Ryan,

thanks for taking this up, and more generally for giving the openldap
package so much love the last few years!

> Hi, thank you for pinging the bug, and for the patch. I intend to make an
> upload in the coming weeks and I will definitely evaluate this addition. Do
> you have a convenient test case that I could use for verifying the result?

Like, what kind of test case? How do you test libldap2-dev?

There's no additional binary or something being built that would need to
be tested. The build should result in a new binary package slapi-dev,
which contains the unmodified /include/slapi-plugin.h from the upstream
source, as well as a shared library symlink:

-rw-r--r-- root/root 38351 2017-08-10 19:12 ./usr/include/slapi-plugin.h
lrwxrwxrwx root/root 0 2017-08-10 19:12 
./usr/lib/x86_64-linux-gnu/libslapi.so -> libslapi-2.4.so.2.10.7

I think the issue behind this bug is the question whether a
single-header -dev package is worthwhile, or if it could just be
included in the general libldap2-dev package. I'm fine either way, I
just need include/slapi-plugin.h be available in any Debian package.

BTW #650501 is also a request to ship more headers that are part of the
openldap shared library API. In my understanding, shipping headers for
shared libraries is a risk-free thing to do (unless you don't want
people to use your shared library, but then what's the point of having
it in the first place?) so I think that bug could also be acted upon
without worrying too much.

Florian

Bug#711469: [Pkg-openldap-devel] Bug#711469: Can we have libslapi-dev back please:

[Ryan Tandy]

On Tue, Nov 07, 2017 at 03:07:04PM +0100, Florian Schlichting wrote:

Control: tags 711469 + patch


Hi, thank you for pinging the bug, and for the patch. I intend to make 
an upload in the coming weeks and I will definitely evaluate this 
addition. Do you have a convenient test case that I could use for 
verifying the result?


Thanks
Ryan

Bug#711469: Can we have libslapi-dev back please:

[Florian Schlichting]

Control: tags 711469 + patch

On Tue, May 31, 2016 at 10:38:34PM +0200, Florian Schlichting wrote:
> I need slapi-plugin.h for a $work project and would like to help move
> this issue to either solution, reinstating slapi-dev or reintegration
> into libldap2-dev.

as debian/slapi-dev.install is still there, bringing the slapi-dev
package back is trivial. Please apply the following patch.

Florian


commit 89c084c33f8d0e9db33b620c05d710bdc9438a31 (HEAD -> master)
Author: Florian Schlichting 
Date:   Tue Nov 7 12:33:33 2017 +0100

bring back slapi-dev (closes: #711469)

diff --git a/debian/control b/debian/control
index bb68a5f5a..ca86503d3 100644
--- a/debian/control
+++ b/debian/control
@@ -104,3 +104,12 @@ Description: OpenLDAP development libraries
  This package allows development of LDAP applications using the OpenLDAP
  libraries. It includes headers, libraries and links to allow static and
  dynamic linking.
+
+Package: slapi-dev
+Section: libdevel
+Architecture: any
+Depends: slapd (= ${binary:Version}), ${misc:Depends}
+Description: OpenLDAP SLAPI plugin interface development headers
+ This package allows development of plugins for the OpenLDAP slapd server
+ using the SLAPI interface. It includes the headers and libraries needed
+ to build such plugins.

Bug#711469: Can we have libslapi-dev back please:

[Florian Schlichting]

Hi Steve,

in December 2007 you split out slapi-dev from libldap2-dev, only to
"temporarily drop" slapi-dev a month later:


commit 0c845e83a77f940a29fbd51f4a208dc9767529bb
Author: Steve Langasek 
Date:   Thu Dec 20 09:52:23 2007 +

* Split slapi dev support into a new libslapi-dev package, as this is
  unrelated to libldap; and drop libslapi.a since it would be insane to try
  to statically link a dynamically-loaded slapi plugin.


commit cb91aaa489f1dbe7b2e5d8025487f7abe0729888
Author: Steve Langasek 
Date:   Mon Jan 21 14:39:36 2008 +

* Temporarily drop slapi-dev from the package to get through NEW; this
  functionality should be readded later, either by restoring the slapi-dev
  package or by moving it to libldap2-dev, depending on the outcome of
  discussion with the ftp-masters.


Do you remember the outcome of discussion with the ftp-masters? What was
the point of contention?

I need slapi-plugin.h for a $work project and would like to help move
this issue to either solution, reinstating slapi-dev or reintegration
into libldap2-dev.

Florian

Bug#711469: Can we have libslapi-dev back please:

[Peter Chubb]

Package: libldap2-dev
Version: 2.4.31-1+nmu

I can no longer compile my old slapi plugins.  Can we please have
slapi-dev back in some form?

It's been gone since this comment:
openldap2.3 (2.4.7-2) unstable; urgency=low

  * Temporarily drop slapi-dev from the package to get through NEW; this
functionality should be readded later, either by restoring the slapi-dev
package or by moving it to libldap2-dev, depending on the outcome of
discussion with the ftp-masters.

Slapd still provides libslapi but there are no header files or
development libraries.

--
Dr Peter Chubb  peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au  Software Systems Research Group/NICTA


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org