Bug#713713: [PATCH] Explicitly instantiate AbstractUI template

2013-10-04 Thread Adrian Knoth 

On 10/01/13 15:24, David Henningsson wrote:


This fixes a build failure on Debian/Ubuntu.

BugLink: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=713713
Signed-off-by: David Henningsson david.hennings...@canonical.com
---
  libs/gtkmm2ext/gtk_ui.cc | 2 ++
  1 file changed, 2 insertions(+)

I'm not a C++ template expert, so I'm not sure this is the most elegant fix,
but at least it builds now. I found it on git trunk too (2.0-ongoing branch),
so I'm including Paul Davis as well.

diff --git a/libs/gtkmm2ext/gtk_ui.cc b/libs/gtkmm2ext/gtk_ui.cc
index 291740c..0894b07 100644
--- a/libs/gtkmm2ext/gtk_ui.cc
+++ b/libs/gtkmm2ext/gtk_ui.cc
@@ -63,6 +63,8 @@ BaseUI::RequestType Gtkmm2ext::AddTimeout = 
BaseUI::new_request_type();

  #include pbd/abstract_ui.cc  /* instantiate the template */

+template class AbstractUIGtkmm2ext::UIRequest;
+
  UI::UI (string namestr, int *argc, char ***argv)
: AbstractUIUIRequest (namestr, true)
  {



Thanks for the patch, confirmed to work. Will upload in a second.



Cheers


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#713713: [PATCH] Explicitly instantiate AbstractUI template

2013-10-04 Thread David Henningsson 
On 10/04/2013 06:07 PM, Adrian Knoth wrote:
 On 10/01/13 15:24, David Henningsson wrote:
 
 This fixes a build failure on Debian/Ubuntu.

 BugLink: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=713713
 Signed-off-by: David Henningsson david.hennings...@canonical.com
 ---
   libs/gtkmm2ext/gtk_ui.cc | 2 ++
   1 file changed, 2 insertions(+)

 I'm not a C++ template expert, so I'm not sure this is the most
 elegant fix,
 but at least it builds now. I found it on git trunk too (2.0-ongoing
 branch),
 so I'm including Paul Davis as well.

 diff --git a/libs/gtkmm2ext/gtk_ui.cc b/libs/gtkmm2ext/gtk_ui.cc
 index 291740c..0894b07 100644
 --- a/libs/gtkmm2ext/gtk_ui.cc
 +++ b/libs/gtkmm2ext/gtk_ui.cc
 @@ -63,6 +63,8 @@ BaseUI::RequestType Gtkmm2ext::AddTimeout =
 BaseUI::new_request_type();

   #include pbd/abstract_ui.cc  /* instantiate the template */

 +template class AbstractUIGtkmm2ext::UIRequest;
 +
   UI::UI (string namestr, int *argc, char ***argv)
   : AbstractUIUIRequest (namestr, true)
   {

 
 Thanks for the patch, confirmed to work. Will upload in a second.
 
 
 
 Cheers
 

While you're at it, you might also be intersted in the bug below - not
sure it hits Debian too because you run 2.8.16 instead of 2.8.14 though.

https://bugs.launchpad.net/ubuntu/+source/ardour/+bug/1234866 (Linker
errors when starting ardour)

https://bugs.launchpad.net/ubuntu/+source/ardour/+bug/1234866/+attachment/3857945/+files/0001-Add-boost-linking-to-tranzport-and-generic-midi-surf.patch


-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#713713: [PATCH] Explicitly instantiate AbstractUI template

2013-10-01 Thread David Henningsson 
This fixes a build failure on Debian/Ubuntu.

BugLink: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=713713
Signed-off-by: David Henningsson david.hennings...@canonical.com
---
 libs/gtkmm2ext/gtk_ui.cc | 2 ++
 1 file changed, 2 insertions(+)

I'm not a C++ template expert, so I'm not sure this is the most elegant fix,
but at least it builds now. I found it on git trunk too (2.0-ongoing branch), 
so I'm including Paul Davis as well.

diff --git a/libs/gtkmm2ext/gtk_ui.cc b/libs/gtkmm2ext/gtk_ui.cc
index 291740c..0894b07 100644
--- a/libs/gtkmm2ext/gtk_ui.cc
+++ b/libs/gtkmm2ext/gtk_ui.cc
@@ -63,6 +63,8 @@ BaseUI::RequestType Gtkmm2ext::AddTimeout = 
BaseUI::new_request_type();
 
 #include pbd/abstract_ui.cc  /* instantiate the template */
 
+template class AbstractUIGtkmm2ext::UIRequest;
+
 UI::UI (string namestr, int *argc, char ***argv) 
: AbstractUIUIRequest (namestr, true)
 {
-- 
1.8.3.2


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org