Bug#714363: libgd2: Wrong quoting in version strings

2013-06-28 Thread Marc Deslauriers
Package: libgd2
Version: 2.1.0-1
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu saucy ubuntu-patch



*** /tmp/tmp_IJ9Y5/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/fix-compiled-in-version.patch: updated to properly quote
GD_EXTRA_VERSION and GD_VERSION_STRING.

Lack of quoting there is causing other packages, such as php5, to fail to
compile.

Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers raring-updates
  APT policy: (500, 'raring-updates'), (500, 'raring-security'), (500, 
'raring'), (100, 'raring-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.8.0-25-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru libgd2-2.1.0/debian/changelog libgd2-2.1.0/debian/changelog
diff -Nru libgd2-2.1.0/debian/patches/fix-compiled-in-version.patch libgd2-2.1.0/debian/patches/fix-compiled-in-version.patch
--- libgd2-2.1.0/debian/patches/fix-compiled-in-version.patch	2013-06-27 04:02:13.0 -0400
+++ libgd2-2.1.0/debian/patches/fix-compiled-in-version.patch	2013-06-28 08:54:20.0 -0400
@@ -1176,8 +1176,8 @@
 +#define GD_MAJOR_VERSION @GDLIB_MAJOR@
 +#define GD_MINOR_VERSION @GDLIB_MINOR@
 +#define GD_RELEASE_VERSION @GDLIB_REVISION@
-+#define GD_EXTRA_VERSION @GDLIB_EXTRA@
-+#define GD_VERSION_STRING @GDLIB_VERSION@
++#define GD_EXTRA_VERSION @GDLIB_EXTRA@
++#define GD_VERSION_STRING @GDLIB_VERSION@
 +
 +/* Do the DLL dance: dllexport when building the DLL,
 +   dllimport when importing from it, nothing when


Bug#714363: [pkg-GD-devel] Bug#714363: libgd2: Wrong quoting in version strings

2013-06-28 Thread Ondřej Surý
Thanks Marc, also merged the fix into upstream.

O.


On Fri, Jun 28, 2013 at 3:18 PM, Marc Deslauriers 
marc.deslauri...@ubuntu.com wrote:

 Package: libgd2
 Version: 2.1.0-1
 Severity: important
 Tags: patch
 User: ubuntu-de...@lists.ubuntu.com
 Usertags: origin-ubuntu saucy ubuntu-patch



 *** /tmp/tmp_IJ9Y5/bug_body

 In Ubuntu, the attached patch was applied to achieve the following:

   * debian/patches/fix-compiled-in-version.patch: updated to properly quote
 GD_EXTRA_VERSION and GD_VERSION_STRING.

 Lack of quoting there is causing other packages, such as php5, to fail to
 compile.

 Thanks for considering the patch.


 -- System Information:
 Debian Release: wheezy/sid
   APT prefers raring-updates
   APT policy: (500, 'raring-updates'), (500, 'raring-security'), (500,
 'raring'), (100, 'raring-backports')
 Architecture: amd64 (x86_64)
 Foreign Architectures: i386

 Kernel: Linux 3.8.0-25-generic (SMP w/4 CPU cores)
 Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
 Shell: /bin/sh linked to /bin/dash

 ___
 pkg-GD-devel mailing list
 pkg-gd-de...@lists.alioth.debian.org
 http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-gd-devel




-- 
Ondřej Surý ond...@sury.org