Bug#717690: hasciicam ships with invalid desktop file

[Zixing Liu]

Package: hasciicam
Version: 1.1.2-1.1
Followup-For: Bug #717690
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu oracular ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/10_desktop-file.patch: Fix invalid desktop file,
don't include extension for icons. (LP: #1198969)

Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers noble-updates
  APT policy: (500, 'noble-updates'), (500, 'noble-security'), (500, 'noble'), 
(100, 'noble-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.8.0-31-generic (SMP w/10 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru hasciicam-1.1.2/debian/patches/10_desktop-file.patch 
hasciicam-1.1.2/debian/patches/10_desktop-file.patch
--- hasciicam-1.1.2/debian/patches/10_desktop-file.patch1969-12-31 
17:00:00.0 -0700
+++ hasciicam-1.1.2/debian/patches/10_desktop-file.patch2024-05-07 
15:21:06.0 -0600
@@ -0,0 +1,15 @@
+Description: Don't include extension for icon.
+Author: Andreas Moog 
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1198969
+
+--- hasciicam-1.1.2.orig/share/hasciicam.desktop
 hasciicam-1.1.2/share/hasciicam.desktop
+@@ -5,7 +5,7 @@ GenericName=HasciiCam
+ Comment=(h)ascii for the masses!
+ Exec=hasciicam %U
+ TryExec=hasciicam
+-Icon=hasciicam.png
++Icon=hasciicam
+ Terminal=false
+ Categories=AudioVideo;
+ X-AppInstall-Package=hasciicam
diff -Nru hasciicam-1.1.2/debian/patches/series 
hasciicam-1.1.2/debian/patches/series
--- hasciicam-1.1.2/debian/patches/series   2011-04-26 07:29:30.0 
-0600
+++ hasciicam-1.1.2/debian/patches/series   2024-05-07 15:21:06.0 
-0600
@@ -1 +1,2 @@
 debian-changes-1.1.2-1
+10_desktop-file.patch

Bug#717690: hasciicam ships with invalid desktop file

[Andreas Moog]

Package: hasciicam
Version: 1.1.2-1
Severity: normal
Tags: upstream

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear maintainer,

the desktop file that comes with hasciicam is invalid:

desktop-file-validate hasciicam.desktop 
hasciicam.desktop: error: (will be fatal in the future): value "hasciicam.png" 
for key "Icon" in group "Desktop Entry" is an icon name with an extension, but 
there should be no extension as described in the Icon Theme Specification if 
the value is not an absolute path

Cheers,
  Andreas

- -- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.5.0-18-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJR7vFNAAoJEGHzRCZ03mYkQekP/3t+tpSQ/53jKjfoSKkVRQDD
EdFVRNsj/IN2PnzdqigXpRbg80IJE9VgkwZ0kjOmb1KxSOwAnn9u9hP5JRa9O1sg
xEKwdU7ymbgaUL4cz9B7A6fJutSokdt7fAKhad+qbJUkVdu/SL43JcY2Ez3Zbtkd
u/C57DZtIZLPQtRDBOZRv/a26e7+XmrPrfofTaHtoFEhN9Ve8w/zxtByJylLUfxP
yi+eAUbYSxS/RY5JDHMrTtuU/Wur+e1w8t7pkxeBI2JwrKvhJorh7XCvCxdubsgd
xjsdksfumEybWpG/8o380aMZ9YJTtpswMwZZ5eC/YlndSOaIg9/wGlxMNDw2BYZs
IMyaVLbqGUgYjwtKJIq3L4hXqMOeVbj3xdcJW2YXaoyaxq0V/1yCqrH3X/3D1MM6
GZ0JulOxaJe+jK6lH6uaQmQ+YO34vttDpWttPMoBTIPEQvAO+cHuM0XlBtjjtSoR
+i7xRYENZf4J6YRJ35MRC3g+yyBC1NxUEeWsiaB9XA7gZzwPhJtHxGNv0Ae6rQCA
u5lkyx/DJUI2lma3Dxupg7Ht0q++QuTPtpL8fYP/8VjYWs0keNOPZRpIlQgYa9DQ
foCUYp6esHqInMTSk/S5+J4jiw6FfRqT2IDDhobcoI2oLSZA5LmgnVHGolIYg686
tA195SY9oMnINfwilfmX
=HdQV
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org