Bug#717995: RFS: rawdog/2.16-1 [ITA]

2013-08-01 Thread Jakub Wilk

* Adam Sampson a...@offog.org, 2013-07-28, 23:18:

lintian4python emits:
x: rawdog: except-without-exception-type [various]
I've checked those out and they're legit (e.g. you can get pretty much 
any exception when unpickling from a corrupt file).


Agreed for persister.py:86, but not for the rest.

rawdog.py:36 - catch ImportError;
rawdog.py:41 - ditto;
rawdog.py:297 - catch UnicodeError;
rawdog.py:1217 - catch AttributeError.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#717995: RFS: rawdog/2.16-1 [ITA]

2013-08-01 Thread Adam Sampson
Jakub Wilk jw...@debian.org writes:

 rawdog.py:36 - catch ImportError;
 rawdog.py:41 - ditto;

You'll get ImportError if the module's missing. If the module's present
but raises an exception during initialisation then rawdog should still
fall back to the alternative, rather than crashing.

 rawdog.py:297 - catch UnicodeError;

Nope; it's got to deal with the wacky behaviour of any subclass of str,
and a mis-decoded string is preferable to a crash (as it is elsewhere in
rawdog and feedparser).

That bit of code existed originally because BeautifulSoup did highly
entertaining things with string subclassing, and rawdog needs to be
robust in flattening whatever feedparser returns back to standard Python
types so it can reliably pickle them. Strings are less of a concern now
that feedparser's use of BeautifulSoup is explicitly disabled, although
the dict flattening is still important for feedparser's results.

 rawdog.py:1217 - catch AttributeError.

Hmm. The behaviour's the same either way, but it's not consistent: I'm
catching AttributeError in the other places where I'm looking for
attributes added during the 2.x series, so I'll change that in the next
upstream release.

Thanks,

-- 
Adam Sampson a...@offog.org http://offog.org/


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#717995: RFS: rawdog/2.16-1 [ITA]

2013-07-28 Thread Jakub Wilk

(I don't intend to sponsor this package. Sorry!)

* Adam Sampson a...@offog.org, 2013-07-27, 19:24:

http://mentors.debian.net/debian/pool/main/r/rawdog/rawdog_2.16-1.dsc


Please honour DEB_BUILD_OPTIONS=nocheck.

Lintian emits:
I: rawdog: hyphen-used-as-minus-sign usr/share/man/man1/rawdog.1.gz:127

lintian4python emits:
x: rawdog: except-without-exception-type 
usr/share/pyshared/rawdoglib/persister.py:86
x: rawdog: except-without-exception-type 
usr/share/pyshared/rawdoglib/rawdog.py:36
x: rawdog: except-without-exception-type 
usr/share/pyshared/rawdoglib/rawdog.py:41
x: rawdog: except-without-exception-type 
usr/share/pyshared/rawdoglib/rawdog.py:297
x: rawdog: except-without-exception-type 
usr/share/pyshared/rawdoglib/rawdog.py:1217

Are the Python modules included by this package intended to be used by 
other software than rawdog itself. If yes, then the package name should 
be python-rawdoglib (or at least there should be Provides: 
python-rawdoglib). Otherwise, they should be moved to a private 
directory.



I've also asked if the python-apps-team would like it.


We would! :) You are welcome to join the team to maintain the package 
with us. (Although apparently we are quite sponsor-starved.)



 * Update package to debhelper 9 (using python2)


I would have no idea what this means if I didn't read the debdiff...

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#717995: RFS: rawdog/2.16-1 [ITA]

2013-07-27 Thread Adam Sampson
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package rawdog.

  Package name: rawdog
  Version : 2.16-1
  Upstream Author : Adam Sampson a...@offog.org (i.e. me)
  URL : http://offog.org/code/rawdog/
  License : GPL-2+
  Section : web

It builds those binary packages:

  rawdog - RSS Aggregator Without Delusions Of Grandeur

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/rawdog

Alternatively, one can download the package with dget using this
command:

  dget -x http://mentors.debian.net/debian/pool/main/r/rawdog/rawdog_2.16-1.dsc

I'm the upstream maintainer of rawdog; I'd like to adopt the existing
package, which was built by Decklin Foster but is currently orphaned.
(I've tried to contact Decklin but had no luck; I've also asked if the
python-apps-team would like it.)

More information about rawdog can be obtained from:

  http://offog.org/code/rawdog/

Changes since the last upload:

  * New maintainer (Closes: #660507)
  * New upstream release (Closes: #651080)
  * Remove Debian patch that replaced feedfinder; this was merged
upstream and extended in rawdog 2.15. (Closes: #650776, #657206)
  * Depend on python-feedparser, which is no longer bundled with
upstream rawdog. (Closes: #383422)
  * Recommend python-tidylib.
  * Update package to debhelper 9 (using python2) and Standards-Version
3.9.4.
  * Update package description.
  * Add a watch file.
  * Put the copyright file into machine-readable form.
  * Install the upstream changelog.

To clone the Git repo for the debian/ directory:

  git clone http://offog.org/git/rawdog-debian.git

Thanks very much,

--
Adam Sampson a...@offog.org http://offog.org/


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org