Bug#731803: [Pkg-systemd-maintainers] Bug#731803: dh-systemd: dh_installinit and dh_systemd_start are both present when using symlink instead of Alias

2013-12-25 Thread Michael Stapelberg
control: tags -1 + pending

Hi Laurent,

Laurent Bigonville bi...@debian.org writes:
 After switching from Alias= to mask the SysV initscript to a symlink, it
 seems that my service is (re)started twice, once with the snippet added
 by dh_installinit and the second time by dh_systemd_start.
 dh_systemd_start doesn't seems to detect that dh_installinit is already
 taking care of the same service. 

 # Automatically added by dh_installinit
 if [ -x /etc/init.d/nut-client ]; then
 update-rc.d nut-client defaults /dev/null
 if [ -n $2 ]; then
 _dh_action=restart
 else
 _dh_action=start
 fi
 invoke-rc.d nut-client $_dh_action || exit $?
 fi
 # End automatically added section
 # Automatically added by dh_systemd_start
 if [ -d /run/systemd/system ]; then
 systemctl --system daemon-reload /dev/null || true
 deb-systemd-invoke try-restart nut-monitor.service /dev/null || true
 fi
 # End automatically added section

 This might be a problem for some service I guess
Thanks for the report. I have addressed this issue with commit
http://anonscm.debian.org/gitweb/?p=collab-maint/init-system-helpers.git;a=commitdiff;h=51f7ec85551720b9cf80797996e3656e75e4e18c

Can you verify that this commit fixes the problem for you? I’ll upload a
new version then.

Thanks!

-- 
Best regards,
Michael


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#731803: [Pkg-systemd-maintainers] Bug#731803: dh-systemd: dh_installinit and dh_systemd_start are both present when using symlink instead of Alias

2013-12-25 Thread Laurent Bigonville
Le Wed, 25 Dec 2013 10:38:02 +0100,
Michael Stapelberg stapelb...@debian.org a écrit :

[...]
 Thanks for the report. I have addressed this issue with commit
 http://anonscm.debian.org/gitweb/?p=collab-maint/init-system-helpers.git;a=commitdiff;h=51f7ec85551720b9cf80797996e3656e75e4e18c
 
 Can you verify that this commit fixes the problem for you? I’ll
 upload a new version then.

Looks OK for me

Thanks!

Laurent Bigonville


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#731803: dh-systemd: dh_installinit and dh_systemd_start are both present when using symlink instead of Alias

2013-12-23 Thread Laurent Bigonville
Hi,

Ignoring the symlinks shipped in the package shouldn't be enough to fix
this?

Laurent Bigonville


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#731803: dh-systemd: dh_installinit and dh_systemd_start are both present when using symlink instead of Alias

2013-12-09 Thread Laurent Bigonville
Package: dh-systemd
Version: 1.13
Severity: important

Hi,

After switching from Alias= to mask the SysV initscript to a symlink, it
seems that my service is (re)started twice, once with the snippet added
by dh_installinit and the second time by dh_systemd_start.
dh_systemd_start doesn't seems to detect that dh_installinit is already
taking care of the same service. 

# Automatically added by dh_installinit
if [ -x /etc/init.d/nut-client ]; then
update-rc.d nut-client defaults /dev/null
if [ -n $2 ]; then
_dh_action=restart
else
_dh_action=start
fi
invoke-rc.d nut-client $_dh_action || exit $?
fi
# End automatically added section
# Automatically added by dh_systemd_start
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload /dev/null || true
deb-systemd-invoke try-restart nut-monitor.service /dev/null || true
fi
# End automatically added section

This might be a problem for some service I guess

Cheers

Laurent Bigonville

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dh-systemd depends on:
ii  debhelper  9.20131127
ii  perl   5.18.1-5

dh-systemd recommends no packages.

dh-systemd suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org