Bug#732076: e2fsprogs: please update config.guess and config.sub at build time

2013-12-14 Thread Colin Watson 
On Sat, Dec 14, 2013 at 01:48:42AM -0500, Theodore Ts'o wrote:
 Maybe I have an overly long memory, but I remember when the FSF let
 politics intrude by making changes to config.guess to promote the
 GNU/Linux name, which had the affect of breaking packages that blindly
 trusted that you could always update config.guess.

Certainly in the last ten years I've never once seen a bug caused by
updated config.{guess,sub}, but I've seen hundreds (if not thousands, by
now) of failures caused by not doing so.

 That plus the fact that I don't trust changes to autoconf not to
 randomly cause breakage, is why I ship upstream e2fsprogs sources with
 a generated configure and shiped config.guess/config.sub that I can
 personally test to be sane.

This is of course conflating two separate issues.  It's quite possible
to update config.{guess,sub} without updating autoconf.

 I've already updated the upstream e2fsprogs sources to have an updated
 version of config.guess and config.sub to support ppc64el.  It will be
 in the soon-to-be-released e2fsprogs 1.42.10.

Thanks, although it's a shame that this approach means we will
inevitably continue to run into this with new ports entirely
unnecessarily.

Regards,

-- 
Colin Watson   [cjwat...@debian.org]


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#732076: e2fsprogs: please update config.guess and config.sub at build time

2013-12-13 Thread Colin Watson 
Package: e2fsprogs
Version: 1.42.8-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch trusty

config.guess and config.sub in e2fsprogs 1.42.8 are a bit too old to
support some new ports properly, such as ppc64el.  Could you please
update them at build time so that we don't have to worry about this in
future?  Patch follows.

  * Use the autotools-dev dh addon to update config.guess/config.sub for new
ports.

diff -Nru e2fsprogs-1.42.8/debian/control e2fsprogs-1.42.8/debian/control
--- e2fsprogs-1.42.8/debian/control 2013-06-21 04:14:38.0 +0100
+++ e2fsprogs-1.42.8/debian/control 2013-12-13 16:01:32.0 +
@@ -2,7 +2,7 @@
 Section: admin
 Priority: required
 Maintainer: Theodore Y. Ts'o ty...@mit.edu
-Build-Depends: texi2html (= 1.76), gettext, texinfo, pkg-config, dietlibc-dev 
( 0.30) [alpha amd64 arm hppa i386 ia64 powerpc ppc64 s390 sparc], 
gcc-multilib [mips mipsel], debhelper (= 7.0), libblkid-dev (= 2.16), 
uuid-dev (= 2.16), m4
+Build-Depends: texi2html (= 1.76), gettext, texinfo, pkg-config, dietlibc-dev 
( 0.30) [alpha amd64 arm hppa i386 ia64 powerpc ppc64 s390 sparc], 
gcc-multilib [mips mipsel], debhelper (= 7.0), libblkid-dev (= 2.16), 
uuid-dev (= 2.16), m4, autotools-dev
 Standards-Version: 3.9.4
 Homepage: http://e2fsprogs.sourceforge.net
 
diff -Nru e2fsprogs-1.42.8/debian/control.in e2fsprogs-1.42.8/debian/control.in
--- e2fsprogs-1.42.8/debian/control.in  2013-06-16 23:39:06.0 +0100
+++ e2fsprogs-1.42.8/debian/control.in  2013-12-13 16:01:27.0 +
@@ -9,7 +9,7 @@
 Section: admin
 Priority: required
 Maintainer: Theodore Y. Ts'o ty...@mit.edu
-Build-Depends: texi2html (= 1.76), gettext, texinfo, pkg-config, 
DIETLIBC_DEFINES gcc-multilib [mips mipsel], debhelper (= 7.0), 
UTIL_LINUX_NG_DEFINES m4
+Build-Depends: texi2html (= 1.76), gettext, texinfo, pkg-config, 
DIETLIBC_DEFINES gcc-multilib [mips mipsel], debhelper (= 7.0), 
UTIL_LINUX_NG_DEFINES m4, autotools-dev
 Standards-Version: 3.9.4
 Homepage: http://e2fsprogs.sourceforge.net
 
diff -Nru e2fsprogs-1.42.8/debian/rules e2fsprogs-1.42.8/debian/rules
--- e2fsprogs-1.42.8/debian/rules   2013-06-16 23:39:06.0 +0100
+++ e2fsprogs-1.42.8/debian/rules   2013-12-13 16:03:22.0 +
@@ -100,6 +100,7 @@
 endif
 
 STAMPSDIR  ?= debian/stampdir
+AUTOTOOLSSTAMP ?= ${STAMPSDIR}/autotools-stamp
 CFGSTDSTAMP?= ${STAMPSDIR}/configure-std-stamp
 CFGBFSTAMP ?= ${STAMPSDIR}/configure-bf-stamp
 CFGSTATICSTAMP ?= ${STAMPSDIR}/configure-static-stamp
@@ -244,6 +245,10 @@
 debian/e2fsprogs.shlibs.local: debian/e2fsprogs.shlibs.local.in
m4 $(M4_ARGS)  debian/e2fsprogs.shlibs.local.in  $@
 
+${AUTOTOOLSSTAMP}:
+   dh_autotools-dev_updateconfig
+   touch ${AUTOTOOLSSTAMP}
+
 ${CFGSTDSTAMP}:
dh_testdir
 
@@ -376,6 +381,7 @@
[ ! -f ${staticbuilddir}/Makefile ] || $(MAKE) -C ${staticbuilddir} V=1 
distclean
rm -rf ${stdbuilddir} ${bfbuilddir} ${staticbuilddir} ${mipsbuilddir} 
${mipsbuilddir64}
rm -f debian/*.substvars
+   dh_autotools-dev_restoreconfig
dh_clean
 
 install: cleanup install-std

Thanks,

-- 
Colin Watson   [cjwat...@ubuntu.com]


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#732076: e2fsprogs: please update config.guess and config.sub at build time

2013-12-13 Thread Colin Watson 
On Fri, Dec 13, 2013 at 04:13:27PM +, Colin Watson wrote:
 config.guess and config.sub in e2fsprogs 1.42.8 are a bit too old to
 support some new ports properly, such as ppc64el.  Could you please
 update them at build time so that we don't have to worry about this in
 future?  Patch follows.

This time the hard rock version, with working stamp file handling.

   * Use the autotools-dev dh addon to update config.guess/config.sub for new
 ports.

diff -Nru e2fsprogs-1.42.8/debian/control e2fsprogs-1.42.8/debian/control
--- e2fsprogs-1.42.8/debian/control 2013-06-21 04:14:38.0 +0100
+++ e2fsprogs-1.42.8/debian/control 2013-12-13 16:01:32.0 +
@@ -2,7 +2,7 @@
 Section: admin
 Priority: required
 Maintainer: Theodore Y. Ts'o ty...@mit.edu
-Build-Depends: texi2html (= 1.76), gettext, texinfo, pkg-config, dietlibc-dev 
( 0.30) [alpha amd64 arm hppa i386 ia64 powerpc ppc64 s390 sparc], 
gcc-multilib [mips mipsel], debhelper (= 7.0), libblkid-dev (= 2.16), 
uuid-dev (= 2.16), m4
+Build-Depends: texi2html (= 1.76), gettext, texinfo, pkg-config, dietlibc-dev 
( 0.30) [alpha amd64 arm hppa i386 ia64 powerpc ppc64 s390 sparc], 
gcc-multilib [mips mipsel], debhelper (= 7.0), libblkid-dev (= 2.16), 
uuid-dev (= 2.16), m4, autotools-dev
 Standards-Version: 3.9.4
 Homepage: http://e2fsprogs.sourceforge.net
 
diff -Nru e2fsprogs-1.42.8/debian/control.in e2fsprogs-1.42.8/debian/control.in
--- e2fsprogs-1.42.8/debian/control.in  2013-06-16 23:39:06.0 +0100
+++ e2fsprogs-1.42.8/debian/control.in  2013-12-13 16:01:27.0 +
@@ -9,7 +9,7 @@
 Section: admin
 Priority: required
 Maintainer: Theodore Y. Ts'o ty...@mit.edu
-Build-Depends: texi2html (= 1.76), gettext, texinfo, pkg-config, 
DIETLIBC_DEFINES gcc-multilib [mips mipsel], debhelper (= 7.0), 
UTIL_LINUX_NG_DEFINES m4
+Build-Depends: texi2html (= 1.76), gettext, texinfo, pkg-config, 
DIETLIBC_DEFINES gcc-multilib [mips mipsel], debhelper (= 7.0), 
UTIL_LINUX_NG_DEFINES m4, autotools-dev
 Standards-Version: 3.9.4
 Homepage: http://e2fsprogs.sourceforge.net
 
diff -Nru e2fsprogs-1.42.8/debian/rules e2fsprogs-1.42.8/debian/rules
--- e2fsprogs-1.42.8/debian/rules   2013-06-16 23:39:06.0 +0100
+++ e2fsprogs-1.42.8/debian/rules   2013-12-13 18:15:05.0 +
@@ -100,6 +100,7 @@
 endif
 
 STAMPSDIR  ?= debian/stampdir
+AUTOTOOLSSTAMP ?= ${STAMPSDIR}/autotools-stamp
 CFGSTDSTAMP?= ${STAMPSDIR}/configure-std-stamp
 CFGBFSTAMP ?= ${STAMPSDIR}/configure-bf-stamp
 CFGSTATICSTAMP ?= ${STAMPSDIR}/configure-static-stamp
@@ -244,7 +245,12 @@
 debian/e2fsprogs.shlibs.local: debian/e2fsprogs.shlibs.local.in
m4 $(M4_ARGS)  debian/e2fsprogs.shlibs.local.in  $@
 
-${CFGSTDSTAMP}:
+${AUTOTOOLSSTAMP}:
+   dh_autotools-dev_updateconfig
+   mkdir -p ${STAMPSDIR}
+   touch ${AUTOTOOLSSTAMP}
+
+${CFGSTDSTAMP}: ${AUTOTOOLSSTAMP}
dh_testdir
 
# Make sure we don't try to rebuild the configure scripts
@@ -276,7 +282,7 @@
mkdir -p ${STAMPSDIR}
touch ${CFGSTDSTAMP}
 
-${CFGBFSTAMP}:
+${CFGBFSTAMP}: ${AUTOTOOLSSTAMP}
dh_testdir
rm -f config.cache
 
@@ -294,7 +300,7 @@
mkdir -p ${STAMPSDIR}
touch ${CFGBFSTAMP}
 
-${CFGSTATICSTAMP}:
+${CFGSTATICSTAMP}: ${AUTOTOOLSSTAMP}
dh_testdir
rm -f config.cache
 
@@ -376,6 +382,7 @@
[ ! -f ${staticbuilddir}/Makefile ] || $(MAKE) -C ${staticbuilddir} V=1 
distclean
rm -rf ${stdbuilddir} ${bfbuilddir} ${staticbuilddir} ${mipsbuilddir} 
${mipsbuilddir64}
rm -f debian/*.substvars
+   dh_autotools-dev_restoreconfig
dh_clean
 
 install: cleanup install-std

Thanks,

-- 
Colin Watson   [cjwat...@ubuntu.com]


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#732076: e2fsprogs: please update config.guess and config.sub at build time

2013-12-13 Thread Theodore Ts'o 
Maybe I have an overly long memory, but I remember when the FSF let
politics intrude by making changes to config.guess to promote the
GNU/Linux name, which had the affect of breaking packages that blindly
trusted that you could always update config.guess.  That plus the fact
that I don't trust changes to autoconf not to randomly cause breakage,
is why I ship upstream e2fsprogs sources with a generated configure
and shiped config.guess/config.sub that I can personally test to be
sane.

I've already updated the upstream e2fsprogs sources to have an updated
version of config.guess and config.sub to support ppc64el.  It will be
in the soon-to-be-released e2fsprogs 1.42.10.

Regards,

- Ted


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org