Bug#732613: RFS: xye/0.12.2+dfsg-1 [ITA]
Hi Andreas, On Thu, Dec 19, 2013 at 12:00:25PM +0100, Andreas Rönnquist wrote: I am looking for a sponsor for my package xye I like Xye, so I thought I'd give your package a look, with the intent of sponsoring it eventually. I've just got a couple of comments: * debian/repack is nice but seems like an awful lot of effort to remove two files; have you noticed the new Files-Excluded header in debian/copyright which uscan now supports? * The manpage doesn't follow the typical Unix manpage style, although if there are no command-line options then the text you've written is good enough. You might get bug reports requesting the manpage to document how to play but until then... * You should update debian/copyright to include yourself. Incidentally while trying to determine whether xye takes any command-line parameters, I discovered that specifying any parameter causes xye to crash! (I'll file a bug...) Regards, Stephen signature.asc Description: Digital signature
Bug#732613: RFS: xye/0.12.2+dfsg-1 [ITA]
Hi Andreas, On Thu, Dec 19, 2013 at 12:00:25PM +0100, Andreas Rönnquist wrote: I am looking for a sponsor for my package xye I like Xye, so I thought I'd give your package a look, with the intent of sponsoring it eventually. Thank you, much appreciated! I've just got a couple of comments: * debian/repack is nice but seems like an awful lot of effort to remove two files; have you noticed the new Files-Excluded header in debian/copyright which uscan now supports? Ah, I hadn't - thanks! Well, I am kind of irritated on that bug I mentioned in README.source (##635920) which makes it impossible to use git-import-orig --uscan in combination with a debian/repack script... I guess using the mentioned Files-Excluded would solve this? * The manpage doesn't follow the typical Unix manpage style, although if there are no command-line options then the text you've written is good enough. You might get bug reports requesting the manpage to document how to play but until then... I'll think I'll wait for those bug reports... ;) * You should update debian/copyright to include yourself. Done. Incidentally while trying to determine whether xye takes any command-line parameters, I discovered that specifying any parameter causes xye to crash! (I'll file a bug...) Oh! I have managed to include a patch that fixes this problem, but when doing so I found more related problems - if running with a folder which doesn't contain any data files it still segfaults (but later). I will try to put together a patch for this problem too. (I have pushed my current changes to alioth). Would you like me to put together a new package on mentors, or do you simply get the gbp packaging from alioth? best regards, and many thanks -- Andreas Rönnquist gus...@gusnan.se signature.asc Description: PGP signature
Bug#732613: RFS: xye/0.12.2+dfsg-1 [ITA]
On Sat, 21 Dec 2013 21:30:28 +0100, Andreas Rönnquist gus...@gusnan.se wrote: I've just got a couple of comments: * debian/repack is nice but seems like an awful lot of effort to remove two files; have you noticed the new Files-Excluded header in debian/copyright which uscan now supports? Ah, I hadn't - thanks! Well, I am kind of irritated on that bug I mentioned in README.source (##635920) which makes it impossible to use git-import-orig --uscan in combination with a debian/repack script... I guess using the mentioned Files-Excluded would solve this? I haven't actually got round to using it myself yet, so I can't say for sure... But I get the impression that uscan repacks the original tarball itself with the same name when removing excluded files, so it should work transparently with git-import-orig --uscan. I'll leave it to you to decide what you want to do for this version of the xye package, since it's too late for the 0.12.2 import anyway, and it would require rewriting debian/copyright in machine-readable format. * The manpage doesn't follow the typical Unix manpage style, although if there are no command-line options then the text you've written is good enough. You might get bug reports requesting the manpage to document how to play but until then... I'll think I'll wait for those bug reports... ;) That's fine by me! Incidentally while trying to determine whether xye takes any command-line parameters, I discovered that specifying any parameter causes xye to crash! (I'll file a bug...) Oh! I have managed to include a patch that fixes this problem, but when doing so I found more related problems - if running with a folder which doesn't contain any data files it still segfaults (but later). I will try to put together a patch for this problem too. (I have pushed my current changes to alioth). Would you like me to put together a new package on mentors, or do you simply get the gbp packaging from alioth? I'm pulling your packaging from alioth, so no need to update mentors. BTW I noticed in your email to debian-devel-games that you mentioned the newer-standards-version lintian warning; this is fixed in the latest version of lintian, currently available in unstable only. I recommend that for Debian development work you always use the unstable version of lintian; I use the following apt pinning (in /etc/apt/preferences): Package: lintian Pin: release a=unstable Pin-Priority: 500 Package: debian-policy Pin: release a=unstable Pin-Priority: 500 Let me know when you reckon you've finished preparing the package, whether or not you fix the second segfault you mention (I can't reproduce it, but I may not be testing the right thing). Regards, Stephen signature.asc Description: PGP signature
Bug#732613: RFS: xye/0.12.2+dfsg-1 [ITA]
On Sat, 21 Dec 2013 21:30:28 +0100, Andreas Rönnquist gus...@gusnan.se wrote: Ah, I hadn't - thanks! Well, I am kind of irritated on that bug I mentioned in README.source (##635920) which makes it impossible to use git-import-orig --uscan in combination with a debian/repack script... I guess using the mentioned Files-Excluded would solve this? I haven't actually got round to using it myself yet, so I can't say for sure... But I get the impression that uscan repacks the original tarball itself with the same name when removing excluded files, so it should work transparently with git-import-orig --uscan. I'll leave it to you to decide what you want to do for this version of the xye package, since it's too late for the 0.12.2 import anyway, and it would require rewriting debian/copyright in machine-readable format. Alright, lets put this conversion on hold at least to until before the next upstream import then. Would you like me to put together a new package on mentors, or do you simply get the gbp packaging from alioth? I'm pulling your packaging from alioth, so no need to update mentors. BTW I noticed in your email to debian-devel-games that you mentioned the newer-standards-version lintian warning; this is fixed in the latest version of lintian, currently available in unstable only. ---8--- Ah, I know - I get the 'newer-standards-version' lintian warning on the mentors site - seems like they havn't updated the lintian version there yet. (I have the latest lintian here on my computer, and don't get the warning here). Let me know when you reckon you've finished preparing the package, whether or not you fix the second segfault you mention (I can't reproduce it, but I may not be testing the right thing). I get it if I simply run xye /usr/ (or any folder other than /usr/share/xye/ for that matter)... I have tried to debug it, but it seems to be a harder nut to crack. I guess it can wait until another release (another debian release, or another upstream) - I will of course report it upstream. I find the package pretty much ready to upload - Would you like me to replace that UNRELEASED with unstable in the changelog, or do you take care of that? best regards, and many many thanks -- Andreas Rönnquist gus...@gusnan.se signature.asc Description: PGP signature
Bug#732613: RFS: xye/0.12.2+dfsg-1 [ITA]
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package xye * Package name: xye Version : 0.12.2+dfsg-1 Upstream Author : Víctor Hugo Solíz Kuncar vexor...@gmail.com * URL : http://xye.sourceforge.net/ * License : Xye License (PNG/ZLIB) Section : games It builds those binary packages: xye - puzzle game - get all the gems in the room xye-data - data files for xye To access further information about this package, please visit the following URL: http://mentors.debian.net/package/xye Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/x/xye/xye_0.12.2+dfsg-1.dsc Changes since the last upload: * Imported Upstream version 0.12.2+dfsg * Adopt package under the Debian Games Team (Closes: #731790) * Refresh patches * Add script to repack and make uscan/watch use this * Update package descriptions (Fixes lintian warnings extended-description-is-probably-too-short and duplicate-short-description) * Update to Standards version 3.9.5 (No change required) * Upgrade to debhelper 9 * Enable hardening flags * Add description and author fields to patches * Add a man-page * Remove Debian-provided desktop file, and add patch fix_desktop_file.diff to instead use the upstream version, but patch it instead * Add a debian/README.source describing repack script and its usage * Add Vcs-Git and Vcs-Browser fields to debian/control * Upgrade to compat level 9 I intend to adopt and maintain this in the games team, and have packaged this in the games team git repository, and configured mrconfig to include it. http://anonscm.debian.org/gitweb/?p=pkg-games/xye.git;a=summary The copyright is available here: http://anonscm.debian.org/gitweb/?p=pkg-games/xye.git;a=blob;f=debian/copyright;h=5d340a168375a0fa8dafb2b9fef720fa478b93b2;hb=bb241141fab79cabe0cbacfd7a5cae169be12106 I will add this RFS to the Games Team Sponsor Request Queue here: http://wiki.debian.org/Games/Sponsors/Queue (Just to mention it, I do have DM status). Thank you, -- Andreas Rönnquist gus...@gusnan.se -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
