Bug#735309: libconfig-model-dpkg-perl: Please support canonical Vcs fields
On Tuesday 21 January 2014 10:07:51 Andreas Tille wrote:
Please mind the '/(git/)*git/' in Vcs-Git.
Oops. I've messed up the substitution regexp. This is now fixed:
$ cme fix dpkg
Fixing from Dpkg...
Reading package lists... Done
Building dependency tree
Reading state information... Done
Warning in 'control source Standards-Version' value '3.9.4': Current standards
version is 3.9.5
Warning in 'control source Vcs-Browser' value
'http://git.debian.org/?p=debian-med/r-cran-reshape2.git;a=summary': URL to
debian system is not the recommended one (code is: '!defined $_ or !
/debian.org/ or m{^https?://anonscm.debian.org/(viewvc|gitweb|loggerhead)} ;')
Warning in 'control source Vcs-Git' value
'git://git.debian.org/git/debian-med/r-cran-reshape2.git': URL to debian system
is not the recommended one (code is: '!defined $_ or ! /debian.org/ or
m{^http://anonscm.debian.org/git/(?!git/)} or
m{^git://anonscm.debian.org/(?!git/)} ;')
Warning in 'copyright Format' value 'http://dep.debian.net/deps/dep5': Format
does not match the recommended URL for DEP-5
Changes applied to dpkg configuration:
- control source Standards-Version: '3.9.4' - '3.9.5' # applied fix
- control source Vcs-Browser:
'http://git.debian.org/?p=debian-med/r-cran-reshape2.git;a=summary' -
'http://anonscm.debian.org/gitweb/?p=debian-med/r-cran-reshape2.git;a=summary'
# applied fix
- control source Vcs-Git:
'git://git.debian.org/git/debian-med/r-cran-reshape2.git' -
'git://anonscm.debian.org/git/debian-med/r-cran-reshape2.git' # applied fix
- copyright Format: 'http://dep.debian.net/deps/dep5' -
'http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/' # applied
fix
I've added test for all Vcs-* parameter. These changes are available in
git.debian.org.
Theorically, cme will work on your packages. Can you check ?
All the best
--
https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#735309: libconfig-model-dpkg-perl: Please support canonical Vcs fields
Hi Dominique,
On Mon, Jan 20, 2014 at 07:51:07PM +0100, Dominique Dumont wrote:
On Saturday 18 January 2014 14:52:26 Andreas Tille wrote:
I'd recommend that if you find something like
git\.debian\.org/\?p=debian-med
I've pushed a fixed version. This looks good on my side:
domi@ylum:~/debian-dev/r-cran-stringr$ git reset --hard
HEAD is now at be7859a Another testcase for new `cme fix dpkg-control` -
unable to normalise Vcs-Browser
domi@ylum:~/debian-dev/r-cran-stringr$ cme fix dpkg
Fixing from Dpkg...
Reading package lists... Done
Building dependency tree
Reading state information... Done
Warning in 'control source Vcs-Browser' value
'http://git.debian.org/?p=debian-med/r-cran-stringr.git;a=summary': URL to
debian system is not the recommended one (code is: '!defined $_ or !
/debian.org/ or m{^https?://anonscm.debian.org/(viewvc|gitweb|loggerhead)} ;')
Warning in 'copyright Format' value 'http://dep.debian.net/deps/dep5': Format
does not match the recommended URL for DEP-5
Changes applied to dpkg configuration:
- control source Vcs-Browser:
'http://git.debian.org/?p=debian-med/r-cran-stringr.git;a=summary' -
'http://anonscm.debian.org/gitweb/?p=debian-med/r-cran-stringr.git;a=summary'
# applied fix
- copyright Format: 'http://dep.debian.net/deps/dep5' -
'http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/' # applied
fix
This one looks actually good.
Can you check that everything is going fine on your side ?
I have found another (new ?) problem by checking:
git://git.debian.org/git/debian-med/r-cran-reshape2.git
After `cme fix dpkg-control` I've got:
...
+Standards-Version: 3.9.5
+Vcs-Browser:
http://anonscm.debian.org/gitweb/?p=debian-med/r-cran-reshape2.git;a=summary
+Vcs-Git: git://anonscm.debian.org/(git/)*git/debian-med/r-cran-reshape2.git
Homepage: http://had.co.nz/reshape
-Vcs-Git: git://git.debian.org/git/debian-med/r-cran-reshape2.git
-Vcs-Browser: http://git.debian.org/?p=debian-med/r-cran-reshape2.git;a=summary
...
Please mind the '/(git/)*git/' in Vcs-Git.
Kind regards
Andreas.
--
http://fam-tille.de
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#735309: libconfig-model-dpkg-perl: Please support canonical Vcs fields
On Saturday 18 January 2014 14:52:26 you wrote: I'd recommend that if you find something like git\.debian\.org/\?p=debian-med Yes. I was quite close: the '\' before '?' is missing in the regexp I use. I'll fix this soon (and improve the test cases). Thanks -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#735309: libconfig-model-dpkg-perl: Please support canonical Vcs fields
On Saturday 18 January 2014 14:52:26 Andreas Tille wrote:
I'd recommend that if you find something like
git\.debian\.org/\?p=debian-med
I've pushed a fixed version. This looks good on my side:
domi@ylum:~/debian-dev/r-cran-stringr$ git reset --hard
HEAD is now at be7859a Another testcase for new `cme fix dpkg-control` - unable
to normalise Vcs-Browser
domi@ylum:~/debian-dev/r-cran-stringr$ cme fix dpkg
Fixing from Dpkg...
Reading package lists... Done
Building dependency tree
Reading state information... Done
Warning in 'control source Vcs-Browser' value
'http://git.debian.org/?p=debian-med/r-cran-stringr.git;a=summary': URL to
debian system is not the recommended one (code is: '!defined $_ or !
/debian.org/ or m{^https?://anonscm.debian.org/(viewvc|gitweb|loggerhead)} ;')
Warning in 'copyright Format' value 'http://dep.debian.net/deps/dep5': Format
does not match the recommended URL for DEP-5
Changes applied to dpkg configuration:
- control source Vcs-Browser:
'http://git.debian.org/?p=debian-med/r-cran-stringr.git;a=summary' -
'http://anonscm.debian.org/gitweb/?p=debian-med/r-cran-stringr.git;a=summary' #
applied fix
- copyright Format: 'http://dep.debian.net/deps/dep5' -
'http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/' # applied
fix
Can you check that everything is going fine on your side ?
All the best
--
https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#735309: libconfig-model-dpkg-perl: Please support canonical Vcs fields
Hi Dominique,
On Fri, Jan 17, 2014 at 06:47:12PM +0100, Dominique Dumont wrote:
ok. I've updated Dpkg model to check/fix most vcs fields using lintian's
code as an example.
Andreas, could build the package and check that these modifications are
working for you ?
The package is on
ssh://git.debian.org/git/pkg-perl/packages/libconfig-model-dpkg-perl.git
This looks good for our svn based packages which I successfully converted
to normalised Vcs fields. However, there might (or might not?) some
enhancement for some Git based packages. If you look for instanse at:
ssh://git.debian.org/git/debian-med/r-cran-stringr.git
$ LC_ALL=C cme fix dpkg-control
Fixing from Dpkg::Control...
Reading package lists... Done
Building dependency tree
Reading state information... Done
Warning in 'source Vcs-Browser' value
'http://git.debian.org/?p=debian-med/r-cran-stringr.git;a=summary': URL to
debian system is not the recommended one (code is: '!defined $_ or !
/debian.org/ or m{^https?://anonscm.debian.org/(viewvc|gitweb|loggerhead)} ;')
From my perspactive normalisation also means kicking things like
;a=summary
in the end. I have no idea whether this should be discussed or whether
you might want to use your power as cme maintainer to deal with this.
H, perhaps I'm wrong with my suspicion that ;a=summary is
responsible for the problem - since after I removed it the problem above
remained. I guess it is simply the fact that you can leave out gitweb
and apache is expanding this URL to a valid one by injecting gitweb.
I'd recommend that if you find something like
git\.debian\.org/\?p=debian-med
by
anonscm.debian.org/gitweb/?p=debian-med
Kind regards and many thanks for your work
Andreas.
--
http://fam-tille.de
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#735309: libconfig-model-dpkg-perl: Please support canonical Vcs fields
On Tuesday 14 January 2014 19:15:15 Andreas Tille wrote: Hmmm, lintian seems to be able to compute the values - at least it usually comes up with a valid value in the warning text. Since lintian is in Perl as well the code should be somehow available to some extend. ok. I've updated Dpkg model to check/fix most vcs fields using lintian's code as an example. Andreas, could build the package and check that these modifications are working for you ? The package is on ssh://git.debian.org/git/pkg-perl/packages/libconfig-model-dpkg-perl.git All the best -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#735309: libconfig-model-dpkg-perl: Please support canonical Vcs fields
Package: libconfig-model-dpkg-perl Severity: wishlist Hi, since some time lintian issues information if the Vcs fields are not canonical. IMHO it would be easy to change the Vcs fields using cme. What do you think? Kind regards Andreas. -- System Information: Debian Release: 7.3 APT prefers stable APT policy: (500, 'stable') Architecture: i386 (i686) Kernel: Linux 2.6.36-xenU-4814-i386 (SMP w/1 CPU core) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#735309: libconfig-model-dpkg-perl: Please support canonical Vcs fields
On Tuesday 14 January 2014 16:05:47 you wrote:
since some time lintian issues information if the Vcs fields are not
canonical. IMHO it would be easy to change the Vcs fields using cme.
What do you think?
Yes. It should be fairly easy to use warn_unless [1] to encourage people
to use canonical VCS fields. Cumputing the right canonical field will be
a bit of a hack though.
Something like:
warn_unless = {
canonical_field = {
code = 'my $name= $self-grab_value(- Source); m!http://$name.com/!',
fix = ' my $name= $self-grab_value(- Source); http://$name.com/;',
}
}
May be I should enhance ComputedValue to warn if a value is overridden to avoid
this hacks.
Thus defining these canonical fields will be easier...
Do you know where are these canonical fields defined ?
All the best
[1] http://search.cpan.org/dist/Config-Model/lib/Config/Model/Value.pm
--
https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#735309: libconfig-model-dpkg-perl: Please support canonical Vcs fields
Hi Dominique,
On Tue, Jan 14, 2014 at 07:03:08PM +0100, Dominique Dumont wrote:
On Tuesday 14 January 2014 16:05:47 you wrote:
since some time lintian issues information if the Vcs fields are not
canonical. IMHO it would be easy to change the Vcs fields using cme.
What do you think?
Yes. It should be fairly easy to use warn_unless [1] to encourage people
to use canonical VCS fields. Cumputing the right canonical field will be
a bit of a hack though.
Yes - that's why I have choosen wishlist severity.
Something like:
warn_unless = {
canonical_field = {
code = 'my $name= $self-grab_value(- Source); m!http://$name.com/!',
fix = ' my $name= $self-grab_value(- Source); http://$name.com/;',
}
}
May be I should enhance ComputedValue to warn if a value is overridden to
avoid this hacks.
Thus defining these canonical fields will be easier...
Do you know where are these canonical fields defined ?
Hmmm, lintian seems to be able to compute the values - at least it
usually comes up with a valid value in the warning text. Since lintian
is in Perl as well the code should be somehow available to some extend.
Unfortunately Perl is not my mother tongue and I guess you will have a
less harder time to parse this.
All the best
Hope this helps
Andreas.
--
http://fam-tille.de
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
